)]}'
{"id":"depot~11882","triplet_id":"depot~canon~I1bbfcb967d8d9b14487d069bfe3a1f762253ef4d","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-06-26 14:25:20.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-06-26 14:25:14.000000000","reason":"removed on reply"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-06-26 13:34:04.000000000","reason":"\u003cGERRIT_ACCOUNT_1000090\u003e replied on the change","reason_account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}},"1000110":{"account":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"last_update":"2024-06-26 14:25:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1bbfcb967d8d9b14487d069bfe3a1f762253ef4d","subject":"refactor(tvix/eval): prefix ctx iterators in NixString","status":"MERGED","created":"2024-06-26 11:51:21.000000000","updated":"2024-06-26 14:25:20.000000000","submitted":"2024-06-26 14:25:20.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11882","meta_rev_id":"5b05a97addb77fe4f079485cf7a1c556f91536a3","_number":11882,"virtual_id_number":11882,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-26 14:25:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-26 14:25:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-26 14:25:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-26 11:51:21.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-06-26 11:51:21.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"state":"REVIEWER"},{"updated":"2024-06-26 11:51:21.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2024-06-26 11:51:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-06-26 12:00:15.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b338785933c91c5ee7ee485b29dbc1a03a61fac9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-26 11:51:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e8970245778617923630d9b9c544a1a28c37141c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-26 11:51:23.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/34816","accounts_in_message":[],"_revision_number":1},{"id":"280366873dff1ec4995a9b27824437a69021bac8","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-26 12:00:15.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/34816","accounts_in_message":[],"_revision_number":1},{"id":"ac512eca1c4d365572c4b208e5f8c161fa92e03a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-26 12:03:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f549c930b09592d66136e5ac70ba7c47723d6e1b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-26 12:03:29.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/34818","accounts_in_message":[],"_revision_number":2},{"id":"2b4e8f68556dbee66ebe1e7b2f22223d14cba12b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-26 12:11:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/34818","accounts_in_message":[],"_revision_number":2},{"id":"0d7d919612447a7a0bc5d5ec2790c065cd9eb9d1","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-06-26 13:34:04.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"38c0f93a637ce79bfaa9c13ec170bd6f29e3a6b4","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-26 14:25:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5b05a97addb77fe4f079485cf7a1c556f91536a3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-26 14:25:20.000000000","message":"Change has been successfully rebased and submitted as aa7d125c12eb7950bf522d4dfe094223df42743b","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"aa7d125c12eb7950bf522d4dfe094223df42743b","revisions":{"8ffd3ca73b62e756757f8e77f38d0aef34e3ed6c":{"kind":"REWORK","_number":1,"created":"2024-06-26 11:51:21.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/82/11882/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/11882/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/11882/1"}}},"commit":{"parents":[{"commit":"715efcb9b3a986cd90107ea5d433f37f05d9c70d","subject":"feat(tvix/glue): implement builtins.toFile","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d715efcb9b3a986cd90107ea5d433f37f05d9c70d"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-26 11:35:03.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-26 11:48:38.000000000","tz":180},"subject":"refactor(tvix/eval): prefix ctx iterators in NixString","message":"refactor(tvix/eval): prefix ctx iterators in NixString\n\nNixString::iter_plain() didn\u0027t make much sense, especially without a docstring.\n\nRename it to iter_ctx_plain(), and copy the docstring from NixContext.\n\nDo the same for the two other context element types too.\n\nChange-Id: I1bbfcb967d8d9b14487d069bfe3a1f762253ef4d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8ffd3ca73b62e756757f8e77f38d0aef34e3ed6c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8ffd3ca73b62e756757f8e77f38d0aef34e3ed6c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"715efcb9b3a986cd90107ea5d433f37f05d9c70d","is_merged_in_target_branch":false,"change_id":"Ibdaf7a645ddc31e847faa4b87a79f2f95116a7ab","change_number":11879,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b3b8b0f5bb7cb31335ffee0e2a39f8ff0eaf5b6b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-06-26 12:03:26.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/82/11882/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/11882/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/11882/2"}}},"commit":{"parents":[{"commit":"c1b6929c10230b32e927b2efe619e35831108331","subject":"feat(tvix/glue): implement builtins.toFile","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc1b6929c10230b32e927b2efe619e35831108331"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-26 11:35:03.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-26 12:03:23.000000000","tz":180},"subject":"refactor(tvix/eval): prefix ctx iterators in NixString","message":"refactor(tvix/eval): prefix ctx iterators in NixString\n\nNixString::iter_plain() didn\u0027t make much sense, especially without a docstring.\n\nRename it to iter_ctx_plain(), and copy the docstring from NixContext.\n\nDo the same for the two other context element types too.\n\nChange-Id: I1bbfcb967d8d9b14487d069bfe3a1f762253ef4d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db3b8b0f5bb7cb31335ffee0e2a39f8ff0eaf5b6b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db3b8b0f5bb7cb31335ffee0e2a39f8ff0eaf5b6b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c1b6929c10230b32e927b2efe619e35831108331","is_merged_in_target_branch":false,"change_id":"Ibdaf7a645ddc31e847faa4b87a79f2f95116a7ab","change_number":11879,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"aa7d125c12eb7950bf522d4dfe094223df42743b":{"kind":"REWORK","_number":3,"created":"2024-06-26 14:25:20.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/82/11882/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/11882/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/11882/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/11882/3"}}},"commit":{"parents":[{"commit":"b757897e97dd86b8f0e9a8130277695e25caed12","subject":"feat(tvix/glue): implement builtins.toFile","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db757897e97dd86b8f0e9a8130277695e25caed12"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-26 11:35:03.000000000","tz":180},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-06-26 14:25:20.000000000","tz":0},"subject":"refactor(tvix/eval): prefix ctx iterators in NixString","message":"refactor(tvix/eval): prefix ctx iterators in NixString\n\nNixString::iter_plain() didn\u0027t make much sense, especially without a docstring.\n\nRename it to iter_ctx_plain(), and copy the docstring from NixContext.\n\nDo the same for the two other context element types too.\n\nChange-Id: I1bbfcb967d8d9b14487d069bfe3a1f762253ef4d\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11882\nTested-by: BuildkiteCI\nReviewed-by: Ilan Joselevich \u003cpersonal@ilanjoselevich.com\u003e\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003daa7d125c12eb7950bf522d4dfe094223df42743b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003daa7d125c12eb7950bf522d4dfe094223df42743b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b757897e97dd86b8f0e9a8130277695e25caed12","is_merged_in_target_branch":true,"change_id":"Ibdaf7a645ddc31e847faa4b87a79f2f95116a7ab","change_number":11879,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
