)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"1bc32087705a90a6bedec0c68453ac14d75cacc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f73a397a_7edf35db","updated":"2024-07-02 09:42:20.000000000","message":"should probably submit https://cl.tvl.fyi/c/depot/+/11904 prior to submitting this because we need to do some changes here (also mostly bumps of those deps) to make reqwest 0.12 work","commit_id":"19d2bf0edf0b328802e0d59ebc8c11fb9b11f4d2"}],"tvix/Cargo.lock":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4ef4a11bc23c61a8dece267b4bab37321fa0ed64","unresolved":true,"context_lines":[{"line_number":1434,"context_line":" \"js-sys\","},{"line_number":1435,"context_line":" \"libc\","},{"line_number":1436,"context_line":" \"wasi\","},{"line_number":1437,"context_line":" \"wasm-bindgen\","},{"line_number":1438,"context_line":"]"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"[[package]]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f44c866b_2c65ef12","line":1437,"updated":"2024-06-27 09:43:09.000000000","message":"oO","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"66a8362703c1f44cf3e3d9df597a8ad4ac3b25b7","unresolved":false,"context_lines":[{"line_number":1434,"context_line":" \"js-sys\","},{"line_number":1435,"context_line":" \"libc\","},{"line_number":1436,"context_line":" \"wasi\","},{"line_number":1437,"context_line":" \"wasm-bindgen\","},{"line_number":1438,"context_line":"]"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"[[package]]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e90331ae_fa57320c","line":1437,"in_reply_to":"bde033f0_8c414d7f","updated":"2024-06-29 17:46:00.000000000","message":"Yeah, it\u0027s conditional on the arch, and `Cargo.nix` only adds it if we compile for WASM, so this is fine.","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"11b7c7a3888ec0113649da45c93f51168474a504","unresolved":true,"context_lines":[{"line_number":1434,"context_line":" \"js-sys\","},{"line_number":1435,"context_line":" \"libc\","},{"line_number":1436,"context_line":" \"wasi\","},{"line_number":1437,"context_line":" \"wasm-bindgen\","},{"line_number":1438,"context_line":"]"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"[[package]]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bde033f0_8c414d7f","line":1437,"in_reply_to":"f44c866b_2c65ef12","updated":"2024-06-27 13:57:06.000000000","message":"hmm https://github.com/TrueLayer/reqwest-middleware/blob/1c31f4bc7f5b6bf0950f22cbc0936d47e5305ec5/reqwest-tracing/Cargo.toml#L54","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"}],"tvix/store/src/pathinfoservice/nix_http.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4ef4a11bc23c61a8dece267b4bab37321fa0ed64","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        Self {"},{"line_number":47,"context_line":"            base_url,"},{"line_number":48,"context_line":"            http_client: reqwest_middleware::ClientBuilder::new(reqwest::Client::new())"},{"line_number":49,"context_line":"                .with(tvix_tracing::propagate::reqwest::tracing_middleware())"},{"line_number":50,"context_line":"                .build(),"},{"line_number":51,"context_line":"            blob_service,"},{"line_number":52,"context_line":"            directory_service,"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"7cb7b140_e82d30ee","line":49,"updated":"2024-06-27 09:43:09.000000000","message":"Did you take a look at how to extend `object_store` to use it too?\n\nI only saw https://docs.rs/object_store/latest/object_store/struct.ClientOptions.html#method.with_default_headers, but no way to plug in a reqwest middleware - even though they\u0027re using it under the hood.\n\nMight be worth opening an issue upstream to open that.\n\nI\u0027m not convinced yet we should send W3C trace contexts there by default - after all, [everyone seems to require their own header formats](https://docs.aws.amazon.com/AmazonS3/latest/userguide/tracing_requests_using_xray.html), so we might need to make it configurable at some point, but I feel like we should at least make sure we have an option to do so with the `object_store` crate.","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"1bc32087705a90a6bedec0c68453ac14d75cacc5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        Self {"},{"line_number":47,"context_line":"            base_url,"},{"line_number":48,"context_line":"            http_client: reqwest_middleware::ClientBuilder::new(reqwest::Client::new())"},{"line_number":49,"context_line":"                .with(tvix_tracing::propagate::reqwest::tracing_middleware())"},{"line_number":50,"context_line":"                .build(),"},{"line_number":51,"context_line":"            blob_service,"},{"line_number":52,"context_line":"            directory_service,"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"b8cefb87_4fbb1366","line":49,"in_reply_to":"3a862c01_3f8c8354","updated":"2024-07-02 09:42:20.000000000","message":"Done","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"11b7c7a3888ec0113649da45c93f51168474a504","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        Self {"},{"line_number":47,"context_line":"            base_url,"},{"line_number":48,"context_line":"            http_client: reqwest_middleware::ClientBuilder::new(reqwest::Client::new())"},{"line_number":49,"context_line":"                .with(tvix_tracing::propagate::reqwest::tracing_middleware())"},{"line_number":50,"context_line":"                .build(),"},{"line_number":51,"context_line":"            blob_service,"},{"line_number":52,"context_line":"            directory_service,"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"e034ec2c_684a97e9","line":49,"in_reply_to":"7cb7b140_e82d30ee","updated":"2024-06-27 13:57:06.000000000","message":"yeah i forgot about object store, but it seems like they are only exposing the reqwest interface, and we dont really want `with_default_headers` because those are static. What we kinda need is a way to run a function prior to making a reqwest which then inserts the current span id. Currently the only way to achieve this is the external reqwest-middleware crate which wraps the client (and a couple of other things) to achieve this. There is an issue in reqwest upstream https://github.com/seanmonstar/reqwest/issues/155 that would be about that.\n\nSo yeah i think we need to open a new issue in object_store upstream and ask if we could wrap/extend this.\n\nregarding \"W3C trace contexts\", they also use the injector similar what we do in grpc: https://github.com/TrueLayer/reqwest-middleware/blob/reqwest-tracing-v0.4.7/reqwest-tracing/src/otel.rs#L64-L97","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"66a8362703c1f44cf3e3d9df597a8ad4ac3b25b7","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        Self {"},{"line_number":47,"context_line":"            base_url,"},{"line_number":48,"context_line":"            http_client: reqwest_middleware::ClientBuilder::new(reqwest::Client::new())"},{"line_number":49,"context_line":"                .with(tvix_tracing::propagate::reqwest::tracing_middleware())"},{"line_number":50,"context_line":"                .build(),"},{"line_number":51,"context_line":"            blob_service,"},{"line_number":52,"context_line":"            directory_service,"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"3a862c01_3f8c8354","line":49,"in_reply_to":"e034ec2c_684a97e9","updated":"2024-06-29 17:46:00.000000000","message":"Ok, would you mind opening an issue about this with `object_store` upstream? And/or update `TODO.md` to relect the current state?","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"}],"tvix/tracing/Cargo.toml":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"66a8362703c1f44cf3e3d9df597a8ad4ac3b25b7","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  \"dep:tonic\","},{"line_number":42,"context_line":"  \"dep:http\","},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":"reqwest \u003d ["},{"line_number":45,"context_line":"  \"dep:reqwest-tracing\","},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-toml","patch_set":2,"id":"c92b852f_bd8e630d","line":44,"updated":"2024-06-29 17:46:00.000000000","message":"needs an update on the feature matrix in `tracing/default.nix`.","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"1bc32087705a90a6bedec0c68453ac14d75cacc5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  \"dep:tonic\","},{"line_number":42,"context_line":"  \"dep:http\","},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":"reqwest \u003d ["},{"line_number":45,"context_line":"  \"dep:reqwest-tracing\","},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-toml","patch_set":2,"id":"879c81eb_c261cc96","line":44,"in_reply_to":"c92b852f_bd8e630d","updated":"2024-07-02 09:42:20.000000000","message":"Done","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"}],"tvix/tracing/src/lib.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"66a8362703c1f44cf3e3d9df597a8ad4ac3b25b7","unresolved":true,"context_lines":[{"line_number":17,"context_line":"#[cfg(feature \u003d \"tracy\")]"},{"line_number":18,"context_line":"use tracing_tracy::TracyLayer;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#[cfg(any(feature \u003d \"tonic\", feature \u003d \"reqwest\"))]"},{"line_number":21,"context_line":"pub mod propagate;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"lazy_static! {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"84a1cb34_65433358","line":20,"updated":"2024-06-29 17:46:00.000000000","message":"We can probably just drop that conditional, no?\n\n`mod.rs` will essentially just be an empty mod if you don\u0027t have any of these two features enabled.","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"1bc32087705a90a6bedec0c68453ac14d75cacc5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#[cfg(feature \u003d \"tracy\")]"},{"line_number":18,"context_line":"use tracing_tracy::TracyLayer;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#[cfg(any(feature \u003d \"tonic\", feature \u003d \"reqwest\"))]"},{"line_number":21,"context_line":"pub mod propagate;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"lazy_static! {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"db507cec_ee25936e","line":20,"in_reply_to":"84a1cb34_65433358","updated":"2024-07-02 09:42:20.000000000","message":"Done","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"}],"tvix/tracing/src/propagate/reqwest.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4ef4a11bc23c61a8dece267b4bab37321fa0ed64","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/// Returns a new tracing middleware which can be used with reqwest_middleware."},{"line_number":4,"context_line":"/// It will then write the `traceparent` in the header on the request and additionally records the"},{"line_number":5,"context_line":"/// `url` into `http.url`."},{"line_number":6,"context_line":"///"},{"line_number":7,"context_line":"/// If otlp feature is disabled, this will not insert a `traceparent` into the header. It will"},{"line_number":8,"context_line":"/// basically function as a noop."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"877f4c9e_923bd823","line":5,"updated":"2024-06-27 09:43:09.000000000","message":"Can you link to the RFC, or some docs describing the header that\u0027s being used by default? \n\nI assume it\u0027s https://www.w3.org/TR/trace-context/?","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"},{"author":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"change_message_id":"11b7c7a3888ec0113649da45c93f51168474a504","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/// Returns a new tracing middleware which can be used with reqwest_middleware."},{"line_number":4,"context_line":"/// It will then write the `traceparent` in the header on the request and additionally records the"},{"line_number":5,"context_line":"/// `url` into `http.url`."},{"line_number":6,"context_line":"///"},{"line_number":7,"context_line":"/// If otlp feature is disabled, this will not insert a `traceparent` into the header. It will"},{"line_number":8,"context_line":"/// basically function as a noop."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"150db0d7_7ed11cf8","line":5,"in_reply_to":"877f4c9e_923bd823","updated":"2024-06-27 13:57:06.000000000","message":"Done","commit_id":"e80bce053f9bbc4840a0aab09981ebb8291ea74e"}]}