)]}'
{"id":"depot~11897","triplet_id":"depot~canon~Ic2cb1dca2a2980a863165d81baa3323a355cf3fe","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-06-29 19:05:03.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-06-29 19:23:57.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-06-29 19:23:57.000000000","reason":"Change was submitted"},"1000106":{"account":{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"},"last_update":"2024-06-29 19:23:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic2cb1dca2a2980a863165d81baa3323a355cf3fe","subject":"fix(tvix/castore/object_store): make query pairs object_store opts","status":"MERGED","created":"2024-06-29 17:35:11.000000000","updated":"2024-06-29 19:23:57.000000000","submitted":"2024-06-29 19:23:57.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11896","meta_rev_id":"a77ece157a41d6bd02b0b7e67202f9d0ac9ad214","_number":11897,"virtual_id_number":11897,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-29 19:23:57.000000000","_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-29 19:23:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-29 19:23:57.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-29 17:35:11.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"},"state":"REVIEWER"},{"updated":"2024-06-29 17:35:11.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-06-29 17:35:13.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-06-29 17:49:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-29 18:30:16.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"}],"messages":[{"id":"0cec9a70846b49f3b0c5edb599a6d06b9b2f06e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-29 17:35:11.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"55a50c78414a3ff6cf6901289177a0d9e5d97f17","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-29 17:35:13.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/34868","accounts_in_message":[],"_revision_number":1},{"id":"0ad0b79122986fbf600ee6c9bc38cff52749a84e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-29 17:49:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/34868","accounts_in_message":[],"_revision_number":1},{"id":"7d92110ce0959a00acf920ccf1e7f4b87f6b293e","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-06-29 19:05:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a77ece157a41d6bd02b0b7e67202f9d0ac9ad214","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-29 19:23:57.000000000","message":"Change has been successfully rebased and submitted as bba64d876215e19fe588c72f168dc4b033581f6e","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bba64d876215e19fe588c72f168dc4b033581f6e","revisions":{"395e63fdb0a73eb1be1c6bbdd23fe486141f157f":{"kind":"REWORK","_number":1,"created":"2024-06-29 17:35:11.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/97/11897/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/11897/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/11897/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/11897/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/11897/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/11897/1"}}},"commit":{"parents":[{"commit":"86ab052fe037715828e2856e6c700b97d7de20ca","subject":"feat(tvix/boot/tests): closure-nixos-bigtable","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d86ab052fe037715828e2856e6c700b97d7de20ca"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-29 17:09:42.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-29 17:18:53.000000000","tz":180},"subject":"fix(tvix/castore/object_store): make query pairs object_store opts","message":"fix(tvix/castore/object_store): make query pairs object_store opts\n\nWe previously called ObjectStoreBlobService::parse_url, which passes an\nempty list of options when constructing the ObjectStore.\n\nThis is most likely not what we want. The more reasonable thing to do is\npass along the query string (pairs) as options to\n`object_store::parse_url_opts`, and remove them from the plain URL we\npass to object_store itself.\n\nChange-Id: Ic2cb1dca2a2980a863165d81baa3323a355cf3fe\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d395e63fdb0a73eb1be1c6bbdd23fe486141f157f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d395e63fdb0a73eb1be1c6bbdd23fe486141f157f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"86ab052fe037715828e2856e6c700b97d7de20ca","is_merged_in_target_branch":true,"change_id":"Icb383403cb2d1f7e19c71b6298e82b391f9c8d22","change_number":11895,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"bba64d876215e19fe588c72f168dc4b033581f6e":{"kind":"REWORK","_number":2,"created":"2024-06-29 19:23:57.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/97/11897/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/11897/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/11897/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/11897/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/11897/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/11897/2"}}},"commit":{"parents":[{"commit":"d0ef6a50df6760702bf970c0cee71a5cdbff21b8","subject":"refactor(tvix/castore/blobsvc): inline things a bit","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd0ef6a50df6760702bf970c0cee71a5cdbff21b8"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-29 17:09:42.000000000","tz":180},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-06-29 19:23:57.000000000","tz":0},"subject":"fix(tvix/castore/object_store): make query pairs object_store opts","message":"fix(tvix/castore/object_store): make query pairs object_store opts\n\nWe previously called ObjectStoreBlobService::parse_url, which passes an\nempty list of options when constructing the ObjectStore.\n\nThis is most likely not what we want. The more reasonable thing to do is\npass along the query string (pairs) as options to\n`object_store::parse_url_opts`, and remove them from the plain URL we\npass to object_store itself.\n\nChange-Id: Ic2cb1dca2a2980a863165d81baa3323a355cf3fe\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11897\nReviewed-by: Connor Brewster \u003ccbrewster@hey.com\u003e\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbba64d876215e19fe588c72f168dc4b033581f6e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbba64d876215e19fe588c72f168dc4b033581f6e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d0ef6a50df6760702bf970c0cee71a5cdbff21b8","is_merged_in_target_branch":true,"change_id":"Idc1c0f566a3b1b48da62e6f1977b07620656b16c","change_number":11884,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
