)]}'
{"id":"depot~11960","triplet_id":"depot~canon~I37225697235c22b683ca48a17d30fa8fedd12d1b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-07-07 15:01:15.000000000","reason":"\u003cGERRIT_ACCOUNT_1000036\u003e replied on the change","reason_account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-07-07 15:04:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I37225697235c22b683ca48a17d30fa8fedd12d1b","subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","status":"MERGED","created":"2024-07-07 13:26:19.000000000","updated":"2024-07-07 15:04:26.000000000","submitted":"2024-07-07 15:04:26.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11960","meta_rev_id":"99e57188a71d170c4b39615dd5130fc25e5fc4d7","_number":11960,"virtual_id_number":11960,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-07 15:04:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-07 15:04:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-07 15:04:26.000000000","_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-07 13:26:20.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-07 13:28:44.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-07 13:53:19.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-07-07 15:04:26.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e045c9be90e6e095d4a45bc101dbe4bd3013e35b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 13:26:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e689dcca9c9eaaf6a6dc51ddda91ee415310c2d9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 13:26:20.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/35006","accounts_in_message":[],"_revision_number":1},{"id":"5706068df0cca90fc5ae742c6ec33e711de1006f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 13:28:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/35006","accounts_in_message":[],"_revision_number":1},{"id":"1636ba2f4542d7e8ab53791427bac3ad19b02b87","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 13:52:43.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6af1ecc32b0b04bdd6ae4d4677f2591632707176","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 13:52:47.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/35009","accounts_in_message":[],"_revision_number":2},{"id":"ceb2d21939357cb5e03b5baea3e6a6b50e64cbfd","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 13:53:19.000000000","message":"Patch Set 2: Autosubmit+1","accounts_in_message":[],"_revision_number":2},{"id":"32e09c3db2ea157c192cd02fb117bdf21d515f9b","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 13:53:19.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/cli/src/lib.rs`\n* `tvix/cli/src/main.rs`\n* `tvix/cli/src/repl.rs`\n* `tvix/cli/tests/import.nix`\n* `tvix/cli/tests/repl.rs`\n* `tvix/cli/tests/six.nix`\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/lib.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":2},{"id":"eab2a01f2cec0a095a0bdc0bdfcfb83f07c9bbdf","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 13:54:13.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/35009","accounts_in_message":[],"_revision_number":2},{"id":"b9d4cdb7e107b0c246117674a432279fdba54fbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-07-07 14:02:36.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"0fe6c48413c01ae08bdf14ee674802673869909d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:02:37.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/35010","accounts_in_message":[],"_revision_number":3},{"id":"4653d5848da876b22c35c0fad4eb49d6ea6427ed","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:04:05.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/35010","accounts_in_message":[],"_revision_number":3},{"id":"a199c4f5d05c358f663361c6b9cd3867d0253285","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 14:26:37.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"8a4c23408581ddf4a597d3919546e4d0c4978765","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:26:38.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/35014","accounts_in_message":[],"_revision_number":4},{"id":"53ca3bca08d01391d7461a785c641494228c9709","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-07-07 14:31:25.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7f5260fe5454d6a073c32a6b18c51def63b01d55","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:33:59.000000000","message":"Patch Set 4: Verified-1\n\nBuild of patchset 4 failed: https://buildkite.com/tvl/depot/builds/35014","accounts_in_message":[],"_revision_number":4},{"id":"8cdbd282156af867ab9b964f064931967e417c0e","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-07-07 14:39:42.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"5983e3e4fcd4eedde740a0dc7ebdb5c39ceb6437","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 14:45:15.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"287f7a7d0f39b6c0af4636ac1603a0034d8358f8","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 14:45:15.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"cc6155766a358963646857d8810dcdf02dc3b128","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:45:16.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/35016","accounts_in_message":[],"_revision_number":5},{"id":"16010549c473336d8da71cb7d0549839d5003fc0","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:54:33.000000000","message":"Patch Set 5: Verified-1\n\nBuild of patchset 5 failed: https://buildkite.com/tvl/depot/builds/35016","accounts_in_message":[],"_revision_number":5},{"id":"832e59fbf42022ec01f22a2015a09dc4e5d16810","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-07 14:56:30.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"a135339d9ceb8a934ae0546e9b046221d5a1d67c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 14:56:31.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/35018","accounts_in_message":[],"_revision_number":6},{"id":"20e877c96223aeaf88b1352bf4d83dab9958265c","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-07-07 15:01:15.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"5d6d2bbc817ebfba7b906b9209ef6ce5d4537ce4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-07 15:04:08.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/35018","accounts_in_message":[],"_revision_number":6},{"id":"99e57188a71d170c4b39615dd5130fc25e5fc4d7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-07-07 15:04:26.000000000","message":"Change has been successfully rebased and submitted as 8821746d6c6c1b71774727fe1103425d903952bb","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"8821746d6c6c1b71774727fe1103425d903952bb","revisions":{"72fb86a503b7be14987ab0d80008a922669d68b4":{"kind":"REWORK","_number":1,"created":"2024-07-07 13:26:19.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/60/11960/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/1"}}},"commit":{"parents":[{"commit":"614487864c5567e44738e273c563553e6f3eaaa0","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d614487864c5567e44738e273c563553e6f3eaaa0"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72fb86a503b7be14987ab0d80008a922669d68b4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72fb86a503b7be14987ab0d80008a922669d68b4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"614487864c5567e44738e273c563553e6f3eaaa0","is_merged_in_target_branch":false,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1ecd93f0fa3306ba41ddf6c8002ea71009591875":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-07-07 13:52:43.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/60/11960/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/2"}}},"commit":{"parents":[{"commit":"8b0d919d00354a9e1c3cd4030ccc43349f5c86d9","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8b0d919d00354a9e1c3cd4030ccc43349f5c86d9"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:42:46.000000000","tz":-240},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1ecd93f0fa3306ba41ddf6c8002ea71009591875"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1ecd93f0fa3306ba41ddf6c8002ea71009591875"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8b0d919d00354a9e1c3cd4030ccc43349f5c86d9","is_merged_in_target_branch":false,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7938f1628ebb861e2ade35d31547f0b9848d250c":{"kind":"REWORK","_number":3,"created":"2024-07-07 14:02:36.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/60/11960/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/3"}}},"commit":{"parents":[{"commit":"8b0d919d00354a9e1c3cd4030ccc43349f5c86d9","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8b0d919d00354a9e1c3cd4030ccc43349f5c86d9"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-07-07 14:02:29.000000000","tz":180},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7938f1628ebb861e2ade35d31547f0b9848d250c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7938f1628ebb861e2ade35d31547f0b9848d250c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8b0d919d00354a9e1c3cd4030ccc43349f5c86d9","is_merged_in_target_branch":false,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6e26e73929ba1f7d8797110995c884d45a6abd26":{"kind":"REWORK","_number":4,"created":"2024-07-07 14:26:37.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/60/11960/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/4"}}},"commit":{"parents":[{"commit":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d01765c3717579dc985f4b6c15a5b0b2fcf1dc4da"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 14:26:31.000000000","tz":-240},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6e26e73929ba1f7d8797110995c884d45a6abd26"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6e26e73929ba1f7d8797110995c884d45a6abd26"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","is_merged_in_target_branch":true,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4846ec9750f16a65a64a7c7c642b0c31bea81e68":{"kind":"REWORK","_number":5,"created":"2024-07-07 14:45:15.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/60/11960/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/5"}}},"commit":{"parents":[{"commit":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d01765c3717579dc985f4b6c15a5b0b2fcf1dc4da"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 14:44:51.000000000","tz":-240},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4846ec9750f16a65a64a7c7c642b0c31bea81e68"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4846ec9750f16a65a64a7c7c642b0c31bea81e68"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","is_merged_in_target_branch":true,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f5cff3a9d20a7628067c3f13b25cf164a4aafef1":{"kind":"REWORK","_number":6,"created":"2024-07-07 14:56:30.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/60/11960/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/6"}}},"commit":{"parents":[{"commit":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d01765c3717579dc985f4b6c15a5b0b2fcf1dc4da"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 14:56:26.000000000","tz":-240},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df5cff3a9d20a7628067c3f13b25cf164a4aafef1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df5cff3a9d20a7628067c3f13b25cf164a4aafef1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","is_merged_in_target_branch":true,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8821746d6c6c1b71774727fe1103425d903952bb":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2024-07-07 15:04:26.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/60/11960/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/11960/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/11960/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/11960/7"}}},"commit":{"parents":[{"commit":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","subject":"test(tvix/cli): Add some additional REPL tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d01765c3717579dc985f4b6c15a5b0b2fcf1dc4da"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-07-07 13:21:52.000000000","tz":-240},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-07-07 15:04:26.000000000","tz":0},"subject":"fix(tvix/repl): Share globals and sourcemap across evaluations","message":"fix(tvix/repl): Share globals and sourcemap across evaluations\n\nNow that we can bind (potentially lazy, potentially lambda-containing)\nvalues in the REPL and then reference them in subsequent evaluations,\nit\u0027s important that the values to which we construct shared references\nare shared across those subsequent evaluations - otherwise, we get\npanics due to unknown source map locations, or dropped weak references\nto globals.\n\nThis change assigns both the globals and the source map as fields on the\nRepl after the first evaluation, and then passes those in (to the\nEvaluationBuilder) on subsequent evaluations.\n\nOn the EvaluationBuilder side, there\u0027s some panicking introduced - this\nis intentional, as my intent is for the builder to be configured\nstatically enough that panicking is the best way to report errors\nhere (it\u0027s always a bug to misconfigure an Evaluation, and we\u0027d never\nwant to handle it dynamically).\n\nChange-Id: I37225697235c22b683ca48a17d30fa8fedd12d1b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11960\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nAutosubmit: aspen \u003croot@gws.fyi\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8821746d6c6c1b71774727fe1103425d903952bb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8821746d6c6c1b71774727fe1103425d903952bb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"01765c3717579dc985f4b6c15a5b0b2fcf1dc4da","is_merged_in_target_branch":true,"change_id":"Ie21f4abf68ab12827fd15128a8ef810cd8592d07","change_number":11959,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}