)]}'
{"id":"depot~12039","triplet_id":"depot~canon~Id2ef4ee1b22c20e5b79156f40821578979105ddc","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-07-28 16:40:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id2ef4ee1b22c20e5b79156f40821578979105ddc","subject":"docs(tvix/store): Document redb in from_addr","status":"MERGED","created":"2024-07-26 20:58:12.000000000","updated":"2024-07-28 16:40:40.000000000","submitted":"2024-07-28 16:40:40.000000000","submitter":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12039","meta_rev_id":"63da19f8890f4d3f10bf7a203d6788f40e4c81bb","_number":12039,"virtual_id_number":12039,"owner":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-28 16:40:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-28 16:40:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-26 20:58:13.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-26 21:10:06.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-07-26 21:23:12.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"eeef9bcc0054127cbd582179e6b31b12a7e6054c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-07-26 20:58:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6868b811edb2461dac09f33e67ebef9116f970f8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-26 20:58:13.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/35348","accounts_in_message":[],"_revision_number":1},{"id":"962937fa51f415769a4913ce0a76b47c6aa2af72","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-07-26 21:10:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9c9e954496c017c8c0ad6447a2ade65d0eb8820f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-26 21:23:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/35348","accounts_in_message":[],"_revision_number":1},{"id":"5e2f3d6c06eaeafbe3095919b2088f19a5934757","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-28 14:15:28.000000000","message":"Patch Set 1:\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/35348","accounts_in_message":[],"_revision_number":1},{"id":"529005ca543737c8e4c6fe62bba4feb1726e333d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-28 15:03:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/35362","accounts_in_message":[],"_revision_number":1},{"id":"532f0a8381c93b0dddb78ef7391b19d6412e93b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-07-28 16:00:54.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a01b72108bfa0284730fa72a2dab97acbd355891","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-28 16:00:56.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/35365","accounts_in_message":[],"_revision_number":2},{"id":"3e4fb327e1f7087bff46d2ce9d85ce850ca55a59","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-28 16:34:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/35365","accounts_in_message":[],"_revision_number":2},{"id":"63da19f8890f4d3f10bf7a203d6788f40e4c81bb","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-07-28 16:40:40.000000000","message":"Change has been successfully rebased and submitted as d17f0592da9d80c614b393f6d3bc0a960bcd1018\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d17f0592da9d80c614b393f6d3bc0a960bcd1018","revisions":{"04833cbc84bd1f59f8ba089ec266b3c38d3ab8ee":{"kind":"REWORK","_number":1,"created":"2024-07-26 20:58:12.000000000","uploader":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"ref":"refs/changes/39/12039/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/39/12039/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/39/12039/1"}}},"commit":{"parents":[{"commit":"3bcf62aed72a60fbc02ab4817b5a355ec6888a79","subject":"feat(tvix/castore): add RedbDirectoryService","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3bcf62aed72a60fbc02ab4817b5a355ec6888a79"}]}],"author":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-26 20:54:11.000000000","tz":120},"committer":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-26 20:54:11.000000000","tz":120},"subject":"docs(tvix/store): Document redb in from_addr","message":"docs(tvix/store): Document redb in from_addr\n\nChange-Id: Id2ef4ee1b22c20e5b79156f40821578979105ddc\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04833cbc84bd1f59f8ba089ec266b3c38d3ab8ee"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04833cbc84bd1f59f8ba089ec266b3c38d3ab8ee"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3bcf62aed72a60fbc02ab4817b5a355ec6888a79","is_merged_in_target_branch":false,"change_id":"Id8f7c812e2cf401cccd1c382b19907b17a6887bc","change_number":12038,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ee5e222c0b90d560b86fae8bbc5975f435931205":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-07-28 16:00:54.000000000","uploader":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"ref":"refs/changes/39/12039/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/39/12039/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/39/12039/2"}}},"commit":{"parents":[{"commit":"038d1dd5519647c7da75e352b7a6bd284f71ad8b","subject":"feat(tvix/eval): ConstantIdx expansion for more ops","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d038d1dd5519647c7da75e352b7a6bd284f71ad8b"}]}],"author":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-26 20:54:11.000000000","tz":120},"committer":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-28 16:00:54.000000000","tz":0},"subject":"docs(tvix/store): Document redb in from_addr","message":"docs(tvix/store): Document redb in from_addr\n\nChange-Id: Id2ef4ee1b22c20e5b79156f40821578979105ddc\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee5e222c0b90d560b86fae8bbc5975f435931205"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee5e222c0b90d560b86fae8bbc5975f435931205"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"038d1dd5519647c7da75e352b7a6bd284f71ad8b","is_merged_in_target_branch":true,"change_id":"Ia212b0d52b004c87051542c093274e7106ee08e4","change_number":12044,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"d17f0592da9d80c614b393f6d3bc0a960bcd1018":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-07-28 16:40:40.000000000","uploader":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"ref":"refs/changes/39/12039/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/39/12039/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/39/12039/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/39/12039/3"}}},"commit":{"parents":[{"commit":"038d1dd5519647c7da75e352b7a6bd284f71ad8b","subject":"feat(tvix/eval): ConstantIdx expansion for more ops","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d038d1dd5519647c7da75e352b7a6bd284f71ad8b"}]}],"author":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-26 20:54:11.000000000","tz":120},"committer":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-28 16:40:40.000000000","tz":0},"subject":"docs(tvix/store): Document redb in from_addr","message":"docs(tvix/store): Document redb in from_addr\n\nChange-Id: Id2ef4ee1b22c20e5b79156f40821578979105ddc\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12039\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd17f0592da9d80c614b393f6d3bc0a960bcd1018"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd17f0592da9d80c614b393f6d3bc0a960bcd1018"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"038d1dd5519647c7da75e352b7a6bd284f71ad8b","is_merged_in_target_branch":true,"change_id":"Ia212b0d52b004c87051542c093274e7106ee08e4","change_number":12044,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}