)]}'
{"id":"depot~12044","triplet_id":"depot~canon~Ia212b0d52b004c87051542c093274e7106ee08e4","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-07-27 22:37:55.000000000","reason":"removed on reply"},"1000109":{"account":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"last_update":"2024-07-27 22:37:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia212b0d52b004c87051542c093274e7106ee08e4","subject":"feat(tvix/eval): ConstantIdx expansion for more ops","status":"MERGED","created":"2024-07-27 22:21:57.000000000","updated":"2024-07-27 22:37:59.000000000","submitted":"2024-07-27 22:37:59.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12044","meta_rev_id":"612e0bc26b1ade034da3d034ba170761d97e0895","_number":12044,"virtual_id_number":12044,"owner":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-27 22:37:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-27 22:37:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-27 22:37:59.000000000","_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-27 22:21:58.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-27 22:23:04.000000000","updated_by":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2024-07-27 22:31:03.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-27 22:37:59.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c4ca5e0fc36de8aa5f250b0a6263302075c50210","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"date":"2024-07-27 22:21:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9541ac5cccb9d135bb1b5bd15d7c89a81e3755f7","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-27 22:21:58.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/35360","accounts_in_message":[],"_revision_number":1},{"id":"bf8fd0b1da3fbf893b8994d11654d2410a31e3a8","author":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"date":"2024-07-27 22:23:04.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"7c41cd3d8adb63742db1e34ff74a4772801af8c5","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"date":"2024-07-27 22:23:04.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/chunk.rs`\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"edc7ca2cfab364cc4f1046e5c1caf60f53a91a18","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-27 22:31:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/35360","accounts_in_message":[],"_revision_number":1},{"id":"4affd686bebfaad12ee52d207e865dcfc94069e5","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-07-27 22:37:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"612e0bc26b1ade034da3d034ba170761d97e0895","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-07-27 22:37:59.000000000","message":"Change has been successfully rebased and submitted as 038d1dd5519647c7da75e352b7a6bd284f71ad8b","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"038d1dd5519647c7da75e352b7a6bd284f71ad8b","revisions":{"4aa4cdd01fce6e9718504f27a0ea703bafa45d93":{"kind":"REWORK","_number":1,"created":"2024-07-27 22:21:57.000000000","uploader":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"},"ref":"refs/changes/44/12044/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/44/12044/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/44/12044/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/44/12044/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/44/12044/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/44/12044/1"}}},"commit":{"parents":[{"commit":"f3c80c10b95b73ce4f9b334e3a9f2be128007fae","subject":"feat(tvix/tools/narinfo2parquet): preserve the deriver","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df3c80c10b95b73ce4f9b334e3a9f2be128007fae"}]}],"author":{"name":"Matthew Tromp","email":"matthewktromp@gmail.com","date":"2024-07-27 22:15:09.000000000","tz":-240},"committer":{"name":"Matthew Tromp","email":"matthewktromp@gmail.com","date":"2024-07-27 22:21:17.000000000","tz":-240},"subject":"feat(tvix/eval): ConstantIdx expansion for more ops","message":"feat(tvix/eval): ConstantIdx expansion for more ops\n\nPreviously, OpConstant would display some detail about its\nConstantIdx: whether it\u0027s a thunk or closure, and what its address\nis. This has been expanded to also show when the ConstantIdx is a\nblueprint, along with the blueprint\u0027s address, and to the other\nopcodes that use a ConstantIdx.\n\nCurrently, it seems like blueprint addresses don\u0027t correspond to the\naddress of the thunk listed in the bytecode output, but it\u0027s still\nuseful to see that the constant being grabbed is a blueprint, and\nmaybe this pointer can be made to make more sense in the future.\n\nChange-Id: Ia212b0d52b004c87051542c093274e7106ee08e4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4aa4cdd01fce6e9718504f27a0ea703bafa45d93"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4aa4cdd01fce6e9718504f27a0ea703bafa45d93"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f3c80c10b95b73ce4f9b334e3a9f2be128007fae","is_merged_in_target_branch":true,"change_id":"Idbada585b87eef81cad5d40cb7592a7890704695","change_number":12037,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"038d1dd5519647c7da75e352b7a6bd284f71ad8b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-07-27 22:37:59.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/44/12044/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/44/12044/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/44/12044/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/44/12044/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/44/12044/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/44/12044/2"}}},"commit":{"parents":[{"commit":"f3c80c10b95b73ce4f9b334e3a9f2be128007fae","subject":"feat(tvix/tools/narinfo2parquet): preserve the deriver","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df3c80c10b95b73ce4f9b334e3a9f2be128007fae"}]}],"author":{"name":"Matthew Tromp","email":"matthewktromp@gmail.com","date":"2024-07-27 22:15:09.000000000","tz":-240},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-07-27 22:37:59.000000000","tz":0},"subject":"feat(tvix/eval): ConstantIdx expansion for more ops","message":"feat(tvix/eval): ConstantIdx expansion for more ops\n\nPreviously, OpConstant would display some detail about its\nConstantIdx: whether it\u0027s a thunk or closure, and what its address\nis. This has been expanded to also show when the ConstantIdx is a\nblueprint, along with the blueprint\u0027s address, and to the other\nopcodes that use a ConstantIdx.\n\nCurrently, it seems like blueprint addresses don\u0027t correspond to the\naddress of the thunk listed in the bytecode output, but it\u0027s still\nuseful to see that the constant being grabbed is a blueprint, and\nmaybe this pointer can be made to make more sense in the future.\n\nChange-Id: Ia212b0d52b004c87051542c093274e7106ee08e4\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12044\nTested-by: BuildkiteCI\nReviewed-by: aspen \u003croot@gws.fyi\u003e\nAutosubmit: chickadee \u003cmatthewktromp@gmail.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d038d1dd5519647c7da75e352b7a6bd284f71ad8b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d038d1dd5519647c7da75e352b7a6bd284f71ad8b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f3c80c10b95b73ce4f9b334e3a9f2be128007fae","is_merged_in_target_branch":true,"change_id":"Idbada585b87eef81cad5d40cb7592a7890704695","change_number":12037,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000109,"name":"chickadee","email":"matthewktromp@gmail.com","username":"matthewtromp"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}