)]}'
{"id":"depot~12058","triplet_id":"depot~canon~Ia43c0d237d9075152490c635b05fb3fb343abcc8","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-07-29 15:32:40.000000000","reason":"removed on reply"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-07-29 15:50:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia43c0d237d9075152490c635b05fb3fb343abcc8","subject":"fix(tvix/store) RedbPathInfoService: improve logs and errors","status":"MERGED","created":"2024-07-29 15:02:19.000000000","updated":"2024-07-29 15:50:11.000000000","submitted":"2024-07-29 15:50:11.000000000","submitter":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12059","meta_rev_id":"d2233472c60478eada83e78e2a6a7c433a743c8a","_number":12058,"virtual_id_number":12058,"owner":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-29 15:50:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-29 15:50:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-29 15:02:20.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-29 15:02:33.000000000","updated_by":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-07-29 15:19:30.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d33e10eaa543fcaa59279329fc528a31dfc3876","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-07-29 15:02:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b04ad23f751b3436aacdc5ce5a9a6e89ccd6907a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-29 15:02:20.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/35410","accounts_in_message":[],"_revision_number":1},{"id":"530afc60123f0192a2695698b3a90d1926ddf232","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-07-29 15:02:33.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/store/src/pathinfoservice/redb.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"cc493fbb6f072273d0b762745dbc15ff65034543","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-07-29 15:19:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/35410","accounts_in_message":[],"_revision_number":1},{"id":"d76402494f9f9e19db9d3a7d9e605758abd9bb41","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-07-29 15:32:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d2233472c60478eada83e78e2a6a7c433a743c8a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-07-29 15:50:11.000000000","message":"Change has been successfully rebased and submitted as 9cbebfea279e0972bcedff6225ca5152a6542a3f","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9cbebfea279e0972bcedff6225ca5152a6542a3f","revisions":{"286a7794ad8916c221adbe3110f609d659761574":{"kind":"REWORK","_number":1,"created":"2024-07-29 15:02:19.000000000","uploader":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"ref":"refs/changes/58/12058/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/12058/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12058/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12058/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12058/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/12058/1"}}},"commit":{"parents":[{"commit":"a794790203b48ac50490f4fa0bfd66cbbb7e29c4","subject":"fix(tvix/nix-compat): Fix panic in nixbase32 decoding","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da794790203b48ac50490f4fa0bfd66cbbb7e29c4"}]}],"author":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-29 14:59:29.000000000","tz":180},"committer":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-29 14:59:29.000000000","tz":180},"subject":"fix(tvix/store) RedbPathInfoService: improve logs and errors","message":"fix(tvix/store) RedbPathInfoService: improve logs and errors\n\nAdd more logging and remove context from errors because that\u0027s already\nprovided by the logs (Errors also need to be refactored anyway, there\u0027s\nalso confusion about StorageError vs InvalidRequest, there\u0027s no\nconsistency)\n\nChange-Id: Ia43c0d237d9075152490c635b05fb3fb343abcc8\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d286a7794ad8916c221adbe3110f609d659761574"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d286a7794ad8916c221adbe3110f609d659761574"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a794790203b48ac50490f4fa0bfd66cbbb7e29c4","is_merged_in_target_branch":true,"change_id":"Ie27d006b8fe20f005b4a47a1763821a61e9a95c7","change_number":12051,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9cbebfea279e0972bcedff6225ca5152a6542a3f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-07-29 15:50:11.000000000","uploader":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"ref":"refs/changes/58/12058/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/12058/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12058/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12058/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12058/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/12058/2"}}},"commit":{"parents":[{"commit":"a794790203b48ac50490f4fa0bfd66cbbb7e29c4","subject":"fix(tvix/nix-compat): Fix panic in nixbase32 decoding","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da794790203b48ac50490f4fa0bfd66cbbb7e29c4"}]}],"author":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-29 14:59:29.000000000","tz":180},"committer":{"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","date":"2024-07-29 15:50:11.000000000","tz":0},"subject":"fix(tvix/store) RedbPathInfoService: improve logs and errors","message":"fix(tvix/store) RedbPathInfoService: improve logs and errors\n\nAdd more logging and remove context from errors because that\u0027s already\nprovided by the logs (Errors also need to be refactored anyway, there\u0027s\nalso confusion about StorageError vs InvalidRequest, there\u0027s no\nconsistency)\n\nChange-Id: Ia43c0d237d9075152490c635b05fb3fb343abcc8\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12058\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9cbebfea279e0972bcedff6225ca5152a6542a3f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9cbebfea279e0972bcedff6225ca5152a6542a3f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a794790203b48ac50490f4fa0bfd66cbbb7e29c4","is_merged_in_target_branch":true,"change_id":"Ie27d006b8fe20f005b4a47a1763821a61e9a95c7","change_number":12051,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}