)]}'
{"tvix/nix-compat/src/nar/listing/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4d2daffac52f4862c8360cd7d68826c67c0d8d71","unresolved":true,"context_lines":[{"line_number":5,"context_line":"//!"},{"line_number":6,"context_line":"//! Listing files contains metadata about a file and its offset in the corresponding NAR."},{"line_number":7,"context_line":"//!"},{"line_number":8,"context_line":"//! LS files do not offer any integrity field, validating the contents is the caller\u0027s"},{"line_number":9,"context_line":"//! responsibility."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"use std::collections::HashMap;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"9bd4a1a1_e8a83ea7","line":8,"updated":"2024-08-12 17:14:29.000000000","message":"Validating what? Do you mean verifying the contents of the NAR, or something like that?","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"17d7c1531b9eaa8ad50e1760ab5499e4d8804f60","unresolved":false,"context_lines":[{"line_number":5,"context_line":"//!"},{"line_number":6,"context_line":"//! Listing files contains metadata about a file and its offset in the corresponding NAR."},{"line_number":7,"context_line":"//!"},{"line_number":8,"context_line":"//! LS files do not offer any integrity field, validating the contents is the caller\u0027s"},{"line_number":9,"context_line":"//! responsibility."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"use std::collections::HashMap;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"bd4afd93_baa3b35b","line":8,"in_reply_to":"9bd4a1a1_e8a83ea7","updated":"2024-08-19 18:20:47.000000000","message":"Done","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4d2daffac52f4862c8360cd7d68826c67c0d8d71","unresolved":true,"context_lines":[{"line_number":36,"context_line":"#[derive(Debug, Deserialize)]"},{"line_number":37,"context_line":"pub struct Listing {"},{"line_number":38,"context_line":"    pub root: ListingEntry,"},{"line_number":39,"context_line":"    pub version: u64,"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"5cbedf11_21fa6cc8","line":39,"updated":"2024-08-12 17:14:29.000000000","message":"can we enforce this to be 1, and refuse deserializing otherwise?","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"dbeac0a3fc404b48af500f0789f804b2fa146ffe","unresolved":true,"context_lines":[{"line_number":36,"context_line":"#[derive(Debug, Deserialize)]"},{"line_number":37,"context_line":"pub struct Listing {"},{"line_number":38,"context_line":"    pub root: ListingEntry,"},{"line_number":39,"context_line":"    pub version: u64,"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"7ae5a086_944a3d6e","line":39,"in_reply_to":"5cbedf11_21fa6cc8","updated":"2024-08-12 17:22:16.000000000","message":"Listing could just be an enum with a V1, and this the serde tag for it - no need to implement custom deserializers.","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"change_message_id":"26b9610131f961687baa0fb6c09e009a1fc804a2","unresolved":true,"context_lines":[{"line_number":36,"context_line":"#[derive(Debug, Deserialize)]"},{"line_number":37,"context_line":"pub struct Listing {"},{"line_number":38,"context_line":"    pub root: ListingEntry,"},{"line_number":39,"context_line":"    pub version: u64,"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"8e0537d9_09fea201","line":39,"in_reply_to":"7ae5a086_944a3d6e","updated":"2024-08-19 08:54:51.000000000","message":"We should probably also mark that enum with `#[non_exhaustive]`, so that we can add future versions without hard compat breaks.","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"17d7c1531b9eaa8ad50e1760ab5499e4d8804f60","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#[derive(Debug, Deserialize)]"},{"line_number":37,"context_line":"pub struct Listing {"},{"line_number":38,"context_line":"    pub root: ListingEntry,"},{"line_number":39,"context_line":"    pub version: u64,"},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"2196a370_19b5152b","line":39,"in_reply_to":"8e0537d9_09fea201","updated":"2024-08-19 18:20:47.000000000","message":"Done","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"}],"tvix/nix-compat/src/nar/listing/test.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4d2daffac52f4862c8360cd7d68826c67c0d8d71","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#[test]"},{"line_number":4,"context_line":"fn nixos_release() {"},{"line_number":5,"context_line":"    let listing_bytes \u003d include_bytes!(\"../tests/nixos-release.ls\");"},{"line_number":6,"context_line":"    let listing: nar::listing::Listing \u003d serde_json::from_slice(listing_bytes).unwrap();"},{"line_number":7,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"40c6b597_305b7e15","line":6,"updated":"2024-08-12 17:14:29.000000000","message":"Do you want to ensure the contents equal to some expected content? Or at least ensure it does roundtrip (deriving Serialize)","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"b83cb7f44098404b70fc2db616c9f1f35dccf294","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#[test]"},{"line_number":4,"context_line":"fn nixos_release() {"},{"line_number":5,"context_line":"    let listing_bytes \u003d include_bytes!(\"../tests/nixos-release.ls\");"},{"line_number":6,"context_line":"    let listing: nar::listing::Listing \u003d serde_json::from_slice(listing_bytes).unwrap();"},{"line_number":7,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"195a2eb6_63a2d6cd","line":6,"in_reply_to":"20577505_5829d9aa","updated":"2024-08-19 18:20:49.000000000","message":"Done","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"17d7c1531b9eaa8ad50e1760ab5499e4d8804f60","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#[test]"},{"line_number":4,"context_line":"fn nixos_release() {"},{"line_number":5,"context_line":"    let listing_bytes \u003d include_bytes!(\"../tests/nixos-release.ls\");"},{"line_number":6,"context_line":"    let listing: nar::listing::Listing \u003d serde_json::from_slice(listing_bytes).unwrap();"},{"line_number":7,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"20577505_5829d9aa","line":6,"in_reply_to":"40c6b597_305b7e15","updated":"2024-08-19 18:20:47.000000000","message":"I added some expected content, I will skip the roundtrip for now.","commit_id":"2c5867a7eddcb7653a879f43a3839b46cce2551c"}]}