)]}'
{"id":"depot~12225","triplet_id":"depot~canon~Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2024-08-18 16:49:58.000000000","reason":"Change was submitted"},"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-08-18 16:49:58.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-08-18 16:49:58.000000000","reason":"Change was submitted"},"1000106":{"account":{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"},"last_update":"2024-08-18 16:49:58.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-08-18 16:49:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c","subject":"feat(tvix/castore): add Directory::try_from_iter()","status":"MERGED","created":"2024-08-17 15:39:49.000000000","updated":"2024-08-18 16:49:58.000000000","submitted":"2024-08-18 16:49:58.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12225","meta_rev_id":"ec350cc4f6a2557086695bbe628666d6a3b7bbb1","_number":12225,"virtual_id_number":12225,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-18 16:49:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-18 16:49:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-18 16:49:58.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"}],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-17 15:39:49.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-08-17 15:39:49.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2024-08-17 15:39:49.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"},"state":"REVIEWER"},{"updated":"2024-08-17 15:39:49.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2024-08-17 15:39:52.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-17 16:15:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-18 16:49:58.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"16dae0e8009131f97204f04f1f16044a7e487c63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-17 15:39:49.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"1797bffb8c99a8fc47cfecc94fd9c00969c1d385","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-17 15:39:52.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/35856","accounts_in_message":[],"_revision_number":1},{"id":"663281821d44da6c7433d209c3ef6f439a36a65c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-17 15:54:41.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"7e33824c072ba63cfc94b6b0014d4aa2e6542b8a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-17 15:54:43.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/35858","accounts_in_message":[],"_revision_number":2},{"id":"173be6ff4ae0671fd906b56b93c1cf4a75521360","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-17 16:15:19.000000000","message":"Patch Set 3: Patch Set 2 was rebased\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"a5d1d3547cce578001789c6f532f410852af1cc7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-17 16:15:47.000000000","message":"Patch Set 2: Verified-1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified-1 has been copied to patch set 3 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/35858","accounts_in_message":[],"_revision_number":2},{"id":"e79919af0ad55d5367fa38b4c60dc0482e3a2a83","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-17 17:01:53.000000000","message":"Patch Set 2: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 3 (was Verified-1) (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/35865","accounts_in_message":[],"_revision_number":2},{"id":"f485b07a8ca85e3668d0a46ca2f5094aa1f53dc9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-17 19:37:40.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"10593db6a674502997491993a9cf93c5bf92cd76","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-17 19:37:41.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/35871","accounts_in_message":[],"_revision_number":4},{"id":"34e1fea531a5c3c76b2c15b9cea1e512e2149cc5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-17 19:46:13.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/35871","accounts_in_message":[],"_revision_number":4},{"id":"61ccf54f914ce6033b33b32cc4dbaf36c4bfe35e","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-08-17 21:50:00.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"c67229abbaed7a9f94ec2cbf553809bbcaba5826","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-18 12:59:37.000000000","message":"Uploaded patch set 5: New patch set was added with same tree, parent tree, and commit message as Patch Set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR **changekind:NO_CHANGE**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":5},{"id":"bec589a72423ce8fd775385072edb9e3a16860e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-18 15:52:45.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"e30df8bb21b2f1c75d738fbbe0b9ff216dfbaf9e","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-18 15:52:45.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"aa5211e567d516690d3c0c0a32d2399f9fae875f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-18 15:52:47.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/35893","accounts_in_message":[],"_revision_number":6},{"id":"e051d360afc91a09ee8574ffcf9a7226c37c2183","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-18 16:11:15.000000000","message":"Patch Set 6: Verified-1\n\nBuild of patchset 6 failed: https://buildkite.com/tvl/depot/builds/35893","accounts_in_message":[],"_revision_number":6},{"id":"711676a5549f56beceed8eed05cd306f7164d83a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-18 16:27:02.000000000","message":"Uploaded patch set 7.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"435acea28f0c7a6f254d11a24c2eb07b514ee38a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-18 16:27:06.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/35898","accounts_in_message":[],"_revision_number":7},{"id":"c09534a4f3ac86a3f9df538317ec39e24a3dc4c7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-18 16:34:36.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/35897","accounts_in_message":[],"_revision_number":6},{"id":"dd885ed2835af42513cb5e0ec0a8a83ebcd5460f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-18 16:49:50.000000000","message":"Patch Set 7: Verified+1\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/35898","accounts_in_message":[],"_revision_number":7},{"id":"ec350cc4f6a2557086695bbe628666d6a3b7bbb1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-08-18 16:49:58.000000000","message":"Change has been successfully rebased and submitted as 96832c04116fb5a3be2d314659e701a3669ec65d\n\n4 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/castore/src/nodes/directory.rs\nInsertions: 3, Deletions: 3.\n\n@@ -1,4 +1,4 @@\n-use std::collections::BTreeMap;\n+use std::collections::btree_map::{self, BTreeMap};\n \n use crate::{errors::DirectoryError, path::PathComponent, proto, B3Digest, Node};\n \n@@ -111,10 +111,10 @@\n     .ok_or(DirectoryError::SizeOverflow)?;\n \n     match nodes.entry(name) {\n-        std::collections::btree_map::Entry::Vacant(e) \u003d\u003e {\n+        btree_map::Entry::Vacant(e) \u003d\u003e {\n             e.insert(node);\n         }\n-        std::collections::btree_map::Entry::Occupied(occupied) \u003d\u003e {\n+        btree_map::Entry::Occupied(occupied) \u003d\u003e {\n             return Err(DirectoryError::DuplicateName(occupied.key().to_owned()))\n         }\n     }\n```\n","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"96832c04116fb5a3be2d314659e701a3669ec65d","revisions":{"dd71aaec06bd11f4b8c312eb908ebd9ec45ab310":{"kind":"REWORK","_number":1,"created":"2024-08-17 15:39:49.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/1"}}},"commit":{"parents":[{"commit":"6253c3d66d40a623924abf71a5eb916ff2e44a08","subject":"chore(tvix/glue): drop some explicit allow(clippy::mutable_key_type)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6253c3d66d40a623924abf71a5eb916ff2e44a08"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 15:39:46.000000000","tz":180},"subject":"feat(tvix/castore): add Directory::from_iter()","message":"feat(tvix/castore): add Directory::from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddd71aaec06bd11f4b8c312eb908ebd9ec45ab310"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddd71aaec06bd11f4b8c312eb908ebd9ec45ab310"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6253c3d66d40a623924abf71a5eb916ff2e44a08","is_merged_in_target_branch":false,"change_id":"I2330af5781844d5f9d975793d770efcea48d371b","change_number":12223,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"35db1eaf7474fb70108d1854b5c1c6499727a8ec":{"kind":"REWORK","_number":2,"created":"2024-08-17 15:54:41.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/2"}}},"commit":{"parents":[{"commit":"6253c3d66d40a623924abf71a5eb916ff2e44a08","subject":"chore(tvix/glue): drop some explicit allow(clippy::mutable_key_type)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6253c3d66d40a623924abf71a5eb916ff2e44a08"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 15:54:06.000000000","tz":180},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d35db1eaf7474fb70108d1854b5c1c6499727a8ec"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d35db1eaf7474fb70108d1854b5c1c6499727a8ec"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6253c3d66d40a623924abf71a5eb916ff2e44a08","is_merged_in_target_branch":false,"change_id":"I2330af5781844d5f9d975793d770efcea48d371b","change_number":12223,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7d852e77d36c985845b280c2f98c7eb068c819d9":{"kind":"NO_CHANGE","_number":3,"created":"2024-08-17 16:15:19.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/3"}}},"commit":{"parents":[{"commit":"c75b0d08ce8fcf6f1e21fc090b2c4541575c485f","subject":"chore(tvix/glue): drop some explicit allow(clippy::mutable_key_type)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc75b0d08ce8fcf6f1e21fc090b2c4541575c485f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-08-17 16:15:19.000000000","tz":0},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7d852e77d36c985845b280c2f98c7eb068c819d9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7d852e77d36c985845b280c2f98c7eb068c819d9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c75b0d08ce8fcf6f1e21fc090b2c4541575c485f","is_merged_in_target_branch":true,"change_id":"I2330af5781844d5f9d975793d770efcea48d371b","change_number":12223,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"e8502b026661c8238f403fd64a9a377e38c52fba":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2024-08-17 19:37:40.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/4"}}},"commit":{"parents":[{"commit":"f963d6467ad345b0b55e75218557aa76e88e9337","subject":"fix(tvix/boot): workaround test flakiness","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df963d6467ad345b0b55e75218557aa76e88e9337"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 17:05:23.000000000","tz":180},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de8502b026661c8238f403fd64a9a377e38c52fba"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de8502b026661c8238f403fd64a9a377e38c52fba"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f963d6467ad345b0b55e75218557aa76e88e9337","is_merged_in_target_branch":false,"change_id":"I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb","change_number":12228,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ffb5657a1c4b294afb1c639f63a6d558cc19fee6":{"kind":"NO_CHANGE","_number":5,"created":"2024-08-18 12:59:37.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/5"}}},"commit":{"parents":[{"commit":"76839683a7ab0453afcdc3374a5cc80cca2f9510","subject":"fix(tvix/boot): workaround test flakiness","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d76839683a7ab0453afcdc3374a5cc80cca2f9510"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-18 12:59:27.000000000","tz":180},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dffb5657a1c4b294afb1c639f63a6d558cc19fee6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dffb5657a1c4b294afb1c639f63a6d558cc19fee6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"76839683a7ab0453afcdc3374a5cc80cca2f9510","is_merged_in_target_branch":true,"change_id":"I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb","change_number":12228,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8cb57f267b1fc76ac6bcc86f6db404c3fd785cd4":{"kind":"REWORK","_number":6,"created":"2024-08-18 15:52:45.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/6"}}},"commit":{"parents":[{"commit":"76839683a7ab0453afcdc3374a5cc80cca2f9510","subject":"fix(tvix/boot): workaround test flakiness","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d76839683a7ab0453afcdc3374a5cc80cca2f9510"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-18 15:52:21.000000000","tz":180},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8cb57f267b1fc76ac6bcc86f6db404c3fd785cd4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8cb57f267b1fc76ac6bcc86f6db404c3fd785cd4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"76839683a7ab0453afcdc3374a5cc80cca2f9510","is_merged_in_target_branch":true,"change_id":"I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb","change_number":12228,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1c7267fd92c289538c3995f6b4008130cee6f9cf":{"kind":"REWORK","_number":7,"created":"2024-08-18 16:27:02.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/25/12225/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/7"}}},"commit":{"parents":[{"commit":"76839683a7ab0453afcdc3374a5cc80cca2f9510","subject":"fix(tvix/boot): workaround test flakiness","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d76839683a7ab0453afcdc3374a5cc80cca2f9510"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-18 16:25:36.000000000","tz":180},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1c7267fd92c289538c3995f6b4008130cee6f9cf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1c7267fd92c289538c3995f6b4008130cee6f9cf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"76839683a7ab0453afcdc3374a5cc80cca2f9510","is_merged_in_target_branch":true,"change_id":"I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb","change_number":12228,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"96832c04116fb5a3be2d314659e701a3669ec65d":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2024-08-18 16:49:58.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/25/12225/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/25/12225/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/25/12225/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/25/12225/8"}}},"commit":{"parents":[{"commit":"76839683a7ab0453afcdc3374a5cc80cca2f9510","subject":"fix(tvix/boot): workaround test flakiness","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d76839683a7ab0453afcdc3374a5cc80cca2f9510"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-17 14:40:01.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-08-18 16:49:58.000000000","tz":0},"subject":"feat(tvix/castore): add Directory::try_from_iter()","message":"feat(tvix/castore): add Directory::try_from_iter()\n\nThis provides a batched variant to construct a Directory, which reuses\nthe previously calculated size.\n\nChecking and inserting code is factored out into a check_insert_node\nfunction, taking the current size as a parameter and returning the new\nsize.\n\nChange-Id: Ia6c2970a0c12181b7c40e63cf7ce8c93298ea37c\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12225\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: edef \u003cedef@edef.eu\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d96832c04116fb5a3be2d314659e701a3669ec65d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d96832c04116fb5a3be2d314659e701a3669ec65d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"76839683a7ab0453afcdc3374a5cc80cca2f9510","is_merged_in_target_branch":true,"change_id":"I1c0d25fa1d0ca940b3bdcd145ede87154b0c28eb","change_number":12228,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
