)]}'
{"id":"depot~12249","triplet_id":"depot~canon~I754736099f71d646d430aed73e558a5a7626c394","project":"depot","branch":"canon","hashtags":[],"change_id":"I754736099f71d646d430aed73e558a5a7626c394","subject":"feat(tazjin/german-string): add constructor method from owned data","status":"MERGED","created":"2024-08-19 12:05:40.000000000","updated":"2024-08-19 13:19:40.000000000","submitted":"2024-08-19 13:19:40.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12249","meta_rev_id":"21723cd4b8f52b85df47483889f245ccb265c54d","_number":12249,"virtual_id_number":12249,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-19 13:19:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-19 13:19:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-19 13:19:40.000000000","_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-19 12:05:43.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-19 12:12:30.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-19 13:19:40.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f8d10f289f4c7142a51acfb00e4ebfa484795dc0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-08-19 12:05:40.000000000","message":"Uploaded patch set 1: Autosubmit+1 Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"0285f3bb2ee38e493329a210e715298437bbb66f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-19 12:05:43.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/35984","accounts_in_message":[],"_revision_number":1},{"id":"fb8f8e05ebbb1a03947cef4a97aca4d3363981e4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-08-19 12:06:02.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"8577ee76cc85f2311db5f77f87cf1046a990d4b2","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-19 12:12:30.000000000","message":"Patch Set 1: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 2 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/35984","accounts_in_message":[],"_revision_number":1},{"id":"21723cd4b8f52b85df47483889f245ccb265c54d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-08-19 13:19:40.000000000","message":"Change has been successfully rebased and submitted as ed4f68b1d335359000a71be8ba999d221965aff8\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ed4f68b1d335359000a71be8ba999d221965aff8","revisions":{"c5e034be1ad6339ea1e8299a14c8e9a01d4b3135":{"kind":"REWORK","_number":1,"created":"2024-08-19 12:05:40.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/49/12249/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/12249/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/12249/1"}}},"commit":{"parents":[{"commit":"a76d25d3d03e13bf5120f8d8a962a8e0435045dd","subject":"feat(tazjin/german-string): add pointer equality check in Eq","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da76d25d3d03e13bf5120f8d8a962a8e0435045dd"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-08-19 12:03:54.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-08-19 12:05:35.000000000","tz":180},"subject":"feat(tazjin/german-string): add constructor method from owned data","message":"feat(tazjin/german-string): add constructor method from owned data\n\nMakes it possible to construct a GermanString from an owned byte vector, without\nhaving to clone the data.\n\nThis is done by \"disowning\" the vector using ManuallyDrop to access its internal\npointer. For transient strings, this memory is then owned (and freed) by the\nGermanString instance.\n\nSmall strings are copied out of the heap and stored inline as before, to avoid\nany dereferencing operations.\n\nChange-Id: I754736099f71d646d430aed73e558a5a7626c394\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5e034be1ad6339ea1e8299a14c8e9a01d4b3135"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5e034be1ad6339ea1e8299a14c8e9a01d4b3135"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a76d25d3d03e13bf5120f8d8a962a8e0435045dd","is_merged_in_target_branch":false,"change_id":"If45e7cf33921fe571482dc710c27ef8cc7c70885","change_number":12245,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"934aa7a580f2d5c0320e1073d28b69f6414433ce":{"kind":"NO_CHANGE","_number":2,"created":"2024-08-19 12:06:02.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/49/12249/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/12249/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/12249/2"}}},"commit":{"parents":[{"commit":"8225b1ad4ce3f949d68b23cc9c62ee6b2984db4f","subject":"feat(tazjin/german-string): add pointer equality check in Eq","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8225b1ad4ce3f949d68b23cc9c62ee6b2984db4f"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-08-19 12:03:54.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-08-19 12:05:58.000000000","tz":180},"subject":"feat(tazjin/german-string): add constructor method from owned data","message":"feat(tazjin/german-string): add constructor method from owned data\n\nMakes it possible to construct a GermanString from an owned byte vector, without\nhaving to clone the data.\n\nThis is done by \"disowning\" the vector using ManuallyDrop to access its internal\npointer. For transient strings, this memory is then owned (and freed) by the\nGermanString instance.\n\nSmall strings are copied out of the heap and stored inline as before, to avoid\nany dereferencing operations.\n\nChange-Id: I754736099f71d646d430aed73e558a5a7626c394\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d934aa7a580f2d5c0320e1073d28b69f6414433ce"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d934aa7a580f2d5c0320e1073d28b69f6414433ce"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8225b1ad4ce3f949d68b23cc9c62ee6b2984db4f","is_merged_in_target_branch":false,"change_id":"If45e7cf33921fe571482dc710c27ef8cc7c70885","change_number":12245,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ed4f68b1d335359000a71be8ba999d221965aff8":{"kind":"REWORK","_number":3,"created":"2024-08-19 13:19:40.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/49/12249/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/12249/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/12249/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/12249/3"}}},"commit":{"parents":[{"commit":"0d6d31bc66928252f2ea9d53fc7a5e13d4893c92","subject":"feat(tazjin/german-string): add pointer equality check in Eq","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0d6d31bc66928252f2ea9d53fc7a5e13d4893c92"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-08-19 12:03:54.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-08-19 13:19:40.000000000","tz":0},"subject":"feat(tazjin/german-string): add constructor method from owned data","message":"feat(tazjin/german-string): add constructor method from owned data\n\nMakes it possible to construct a GermanString from an owned byte vector, without\nhaving to clone the data.\n\nThis is done by \"disowning\" the vector using ManuallyDrop to access its internal\npointer. For transient strings, this memory is then owned (and freed) by the\nGermanString instance.\n\nSmall strings are copied out of the heap and stored inline as before, to avoid\nany dereferencing operations.\n\nChange-Id: I754736099f71d646d430aed73e558a5a7626c394\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12249\nAutosubmit: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded4f68b1d335359000a71be8ba999d221965aff8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded4f68b1d335359000a71be8ba999d221965aff8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0d6d31bc66928252f2ea9d53fc7a5e13d4893c92","is_merged_in_target_branch":true,"change_id":"If45e7cf33921fe571482dc710c27ef8cc7c70885","change_number":12245,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}