)]}'
{"id":"depot~12258","triplet_id":"depot~canon~Ife8843857a1a0a3a99177ca997649fd45b8198e6","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2024-08-20 15:14:27.000000000","reason":"Change was submitted"},"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-08-20 15:13:26.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-08-20 15:14:27.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-08-20 15:14:27.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-08-20 15:14:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ife8843857a1a0a3a99177ca997649fd45b8198e6","subject":"refactor(nix-compat/store_path): make StorePath generic on S","status":"MERGED","created":"2024-08-20 14:07:57.000000000","updated":"2024-08-20 15:14:27.000000000","submitted":"2024-08-20 15:14:27.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12258","meta_rev_id":"b7b1d6af0a513837eaa9f26e503a112803feec7b","_number":12258,"virtual_id_number":12258,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-20 15:14:27.000000000","_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-20 15:14:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-20 15:14:27.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-20 14:07:57.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2024-08-20 14:07:57.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-08-20 14:07:57.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2024-08-20 14:07:57.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-08-20 14:07:59.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-20 14:33:19.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-20 15:14:27.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dc30f05cc17beac5c8bd4dc058a97fc722977ac8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-20 14:07:57.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"63093a62ab548ca5027bbe3766b2a797f28185f7","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 14:07:59.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36035","accounts_in_message":[],"_revision_number":1},{"id":"7b64e7e8d447c9d9a65b52ff2dc2fbdee25ac4e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-20 14:12:11.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"dec591d2f8a89f2472365faa6aa1287e33d18551","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 14:12:13.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/36037","accounts_in_message":[],"_revision_number":2},{"id":"5719958c00df29dc59c1ad9ba88bc2fa39440bc4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 14:33:19.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/36037","accounts_in_message":[],"_revision_number":2},{"id":"228c47465cb3748ca0402672f62f3264a8634088","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-20 14:57:52.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"f83b990925bb0a83fc63cab9980bd2a702083fb3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 14:57:54.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/36039","accounts_in_message":[],"_revision_number":3},{"id":"42679449d0eb2508a2b3cd0c745149bdb4aa85e4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 15:12:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/36039","accounts_in_message":[],"_revision_number":3},{"id":"df970cf5e8efcbb66127a95aec918d16624feaf1","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-08-20 15:13:26.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b7b1d6af0a513837eaa9f26e503a112803feec7b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-08-20 15:14:27.000000000","message":"Change has been successfully rebased and submitted as 2beabe968ca70ce2aef8def08d7dab7340979ea6","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2beabe968ca70ce2aef8def08d7dab7340979ea6","revisions":{"1b2543a29286823eabe44ac967c4ea0db2344afd":{"kind":"REWORK","_number":1,"created":"2024-08-20 14:07:57.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/58/12258/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/12258/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/12258/1"}}},"commit":{"parents":[{"commit":"215f33facfe4b7357eae78e38f121f0ddf3fd907","subject":"refactor(nix-compat/aterm): update function names a bit","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d215f33facfe4b7357eae78e38f121f0ddf3fd907"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 13:52:07.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 14:06:17.000000000","tz":180},"subject":"refactor(nix-compat/store_path): make StorePath generic on S","message":"refactor(nix-compat/store_path): make StorePath generic on S\n\nSimilar to how cl/12253 already did this for `Signature`, we apply the\nsame logic to `StorePath`.\n\n`StorePathRef\u003c\u0027a\u003e\u0027` is now a `StorePath\u003c\u0026\u0027a str\u003e`, and there\u0027s less\nredundant code for the two different implementation.\n\n`.as_ref()` returns a `StorePathRef\u003c\u0027_\u003e`, `.to_owned()` gives a\n`StorePath\u003cString\u003e` (for now).\n\nI briefly thought about only publicly exporting `StorePath\u003cString\u003e`\nas `StorePath`, but the diff is not too large and this will make it\neasier to gradually introduce more flexibility in which store paths to\naccept.\n\nAlso, remove some silliness in `StorePath::from_absolute_path_full`,\nwhich now doesn\u0027t allocate anymore.\n\nChange-Id: Ife8843857a1a0a3a99177ca997649fd45b8198e6\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1b2543a29286823eabe44ac967c4ea0db2344afd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1b2543a29286823eabe44ac967c4ea0db2344afd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"215f33facfe4b7357eae78e38f121f0ddf3fd907","is_merged_in_target_branch":false,"change_id":"I8198551ed3ba1cfc479bf7e3cbbc13a426faf4c0","change_number":12257,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d282bbf37fb5b8ac540c309af8fa5846d5595758":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-20 14:12:11.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/58/12258/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/12258/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/12258/2"}}},"commit":{"parents":[{"commit":"e44647e40c9bddd2a663bcf89357d07e9f43843c","subject":"refactor(nix-compat/aterm): update function names a bit","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de44647e40c9bddd2a663bcf89357d07e9f43843c"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 13:52:07.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 14:12:07.000000000","tz":180},"subject":"refactor(nix-compat/store_path): make StorePath generic on S","message":"refactor(nix-compat/store_path): make StorePath generic on S\n\nSimilar to how cl/12253 already did this for `Signature`, we apply the\nsame logic to `StorePath`.\n\n`StorePathRef\u003c\u0027a\u003e\u0027` is now a `StorePath\u003c\u0026\u0027a str\u003e`, and there\u0027s less\nredundant code for the two different implementation.\n\n`.as_ref()` returns a `StorePathRef\u003c\u0027_\u003e`, `.to_owned()` gives a\n`StorePath\u003cString\u003e` (for now).\n\nI briefly thought about only publicly exporting `StorePath\u003cString\u003e`\nas `StorePath`, but the diff is not too large and this will make it\neasier to gradually introduce more flexibility in which store paths to\naccept.\n\nAlso, remove some silliness in `StorePath::from_absolute_path_full`,\nwhich now doesn\u0027t allocate anymore.\n\nChange-Id: Ife8843857a1a0a3a99177ca997649fd45b8198e6\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd282bbf37fb5b8ac540c309af8fa5846d5595758"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd282bbf37fb5b8ac540c309af8fa5846d5595758"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e44647e40c9bddd2a663bcf89357d07e9f43843c","is_merged_in_target_branch":false,"change_id":"I8198551ed3ba1cfc479bf7e3cbbc13a426faf4c0","change_number":12257,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"972c81221ca4a0e43fc4930b7215b5a33e90b0f1":{"kind":"REWORK","_number":3,"created":"2024-08-20 14:57:52.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/58/12258/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/12258/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/12258/3"}}},"commit":{"parents":[{"commit":"e3b73d7e0f69bf84b96376be3bdb5e1ba741cf95","subject":"refactor(nix-compat/aterm): update function names a bit","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de3b73d7e0f69bf84b96376be3bdb5e1ba741cf95"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 13:52:07.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 14:49:40.000000000","tz":180},"subject":"refactor(nix-compat/store_path): make StorePath generic on S","message":"refactor(nix-compat/store_path): make StorePath generic on S\n\nSimilar to how cl/12253 already did this for `Signature`, we apply the\nsame logic to `StorePath`.\n\n`StorePathRef\u003c\u0027a\u003e\u0027` is now a `StorePath\u003c\u0026\u0027a str\u003e`, and there\u0027s less\nredundant code for the two different implementation.\n\n`.as_ref()` returns a `StorePathRef\u003c\u0027_\u003e`, `.to_owned()` gives a\n`StorePath\u003cString\u003e` (for now).\n\nI briefly thought about only publicly exporting `StorePath\u003cString\u003e`\nas `StorePath`, but the diff is not too large and this will make it\neasier to gradually introduce more flexibility in which store paths to\naccept.\n\nAlso, remove some silliness in `StorePath::from_absolute_path_full`,\nwhich now doesn\u0027t allocate anymore.\n\nChange-Id: Ife8843857a1a0a3a99177ca997649fd45b8198e6\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d972c81221ca4a0e43fc4930b7215b5a33e90b0f1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d972c81221ca4a0e43fc4930b7215b5a33e90b0f1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e3b73d7e0f69bf84b96376be3bdb5e1ba741cf95","is_merged_in_target_branch":false,"change_id":"I8198551ed3ba1cfc479bf7e3cbbc13a426faf4c0","change_number":12257,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2beabe968ca70ce2aef8def08d7dab7340979ea6":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2024-08-20 15:14:27.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/58/12258/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/12258/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/12258/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/12258/4"}}},"commit":{"parents":[{"commit":"413135b9252de65c61045ade984de7b4d3319c2d","subject":"refactor(nix-compat/aterm): update function names a bit","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d413135b9252de65c61045ade984de7b4d3319c2d"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-20 13:52:07.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-08-20 15:14:27.000000000","tz":0},"subject":"refactor(nix-compat/store_path): make StorePath generic on S","message":"refactor(nix-compat/store_path): make StorePath generic on S\n\nSimilar to how cl/12253 already did this for `Signature`, we apply the\nsame logic to `StorePath`.\n\n`StorePathRef\u003c\u0027a\u003e\u0027` is now a `StorePath\u003c\u0026\u0027a str\u003e`, and there\u0027s less\nredundant code for the two different implementation.\n\n`.as_ref()` returns a `StorePathRef\u003c\u0027_\u003e`, `.to_owned()` gives a\n`StorePath\u003cString\u003e` (for now).\n\nI briefly thought about only publicly exporting `StorePath\u003cString\u003e`\nas `StorePath`, but the diff is not too large and this will make it\neasier to gradually introduce more flexibility in which store paths to\naccept.\n\nAlso, remove some silliness in `StorePath::from_absolute_path_full`,\nwhich now doesn\u0027t allocate anymore.\n\nChange-Id: Ife8843857a1a0a3a99177ca997649fd45b8198e6\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12258\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nReviewed-by: Connor Brewster \u003ccbrewster@hey.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2beabe968ca70ce2aef8def08d7dab7340979ea6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2beabe968ca70ce2aef8def08d7dab7340979ea6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"413135b9252de65c61045ade984de7b4d3319c2d","is_merged_in_target_branch":true,"change_id":"I8198551ed3ba1cfc479bf7e3cbbc13a426faf4c0","change_number":12257,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}