)]}'
{"id":"depot~12259","triplet_id":"depot~canon~I74d161ea8927362e1cb601ba163489aa96fb91b1","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000107":{"account":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"last_update":"2024-08-21 22:05:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I74d161ea8927362e1cb601ba163489aa96fb91b1","subject":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message","status":"MERGED","created":"2024-08-20 22:29:39.000000000","updated":"2024-08-21 22:05:57.000000000","submitted":"2024-08-21 22:05:57.000000000","submitter":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12259","meta_rev_id":"1904a4b0996a60f1c9898622c63f3e3412653fe7","_number":12259,"virtual_id_number":12259,"owner":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-21 22:05:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-21 22:05:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-20 22:29:40.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-20 22:47:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-21 04:38:41.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"}],"messages":[{"id":"ca6bf9e095118cb18844da0da75b776f5bd91271","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"date":"2024-08-20 22:29:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"660a5b50198902bfb5d01b1293c73fc9a510a18b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 22:29:40.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36043","accounts_in_message":[],"_revision_number":1},{"id":"31b6f092f35fbca56bb3c07c6a0e67855a18ff67","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-20 22:47:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/36043","accounts_in_message":[],"_revision_number":1},{"id":"50961234424a8fb0ce30c30402f0b2840df07e4f","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-21 04:38:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"25bfe2aefc585681b871c6156704ae0bc000a615","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"date":"2024-08-21 13:34:49.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a777fe8b427dcfc2c4533f012ffa228ba6a93c0c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 13:34:51.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/36049","accounts_in_message":[],"_revision_number":2},{"id":"3a96712f4eb8222baf6d7c10a6591c14330fd48c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 13:48:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/36049","accounts_in_message":[],"_revision_number":2},{"id":"1904a4b0996a60f1c9898622c63f3e3412653fe7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"date":"2024-08-21 22:05:57.000000000","message":"Change has been successfully rebased and submitted as 565c0fd24c616adce50e940fc33b7bf9137a21cc\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"565c0fd24c616adce50e940fc33b7bf9137a21cc","revisions":{"06729ed99bb58f6e26b12f80ec5de5024a82fd9a":{"kind":"REWORK","_number":1,"created":"2024-08-20 22:29:39.000000000","uploader":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"ref":"refs/changes/59/12259/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/59/12259/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/59/12259/1"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Ben Webb","email":"benjaminedwardwebb@gmail.com","date":"2024-08-20 22:19:26.000000000","tz":-300},"committer":{"name":"Ben Webb","email":"benjaminedwardwebb@gmail.com","date":"2024-08-20 22:20:19.000000000","tz":-300},"subject":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message","message":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message\n\nFix a discrepancy in the error message for DirectoryError::SizeOverflow.\n\nThe message indicates that the SizeOverflow error occurs when total size\nexceeds u32::MAX, but that\u0027s not true. All size fields within the\ncastore\u0027s internal Directory ADT are u64, and the SizeOverflow error is\nonly returned after a call to the checked_add implementation on u64.\n\nSee tvix/castore/nodes/directory.rs +111\nand tvix/castore/nodes/directory.rs +88\nas of this commit.\n\nChange-Id: I74d161ea8927362e1cb601ba163489aa96fb91b1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d06729ed99bb58f6e26b12f80ec5de5024a82fd9a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d06729ed99bb58f6e26b12f80ec5de5024a82fd9a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3d21fa4ca092aa194bdac1084055ef1ff4d7d457":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-21 13:34:49.000000000","uploader":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"ref":"refs/changes/59/12259/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/59/12259/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/59/12259/2"}}},"commit":{"parents":[{"commit":"e03ea11badbf40971d6bf87eede33fe3b046c98b","subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de03ea11badbf40971d6bf87eede33fe3b046c98b"}]}],"author":{"name":"Ben Webb","email":"benjaminedwardwebb@gmail.com","date":"2024-08-20 22:19:26.000000000","tz":-300},"committer":{"name":"benjaminedwardwebb","email":"benjaminedwardwebb@gmail.com","date":"2024-08-21 13:34:49.000000000","tz":0},"subject":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message","message":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message\n\nFix a discrepancy in the error message for DirectoryError::SizeOverflow.\n\nThe message indicates that the SizeOverflow error occurs when total size\nexceeds u32::MAX, but that\u0027s not true. All size fields within the\ncastore\u0027s internal Directory ADT are u64, and the SizeOverflow error is\nonly returned after a call to the checked_add implementation on u64.\n\nSee tvix/castore/nodes/directory.rs +111\nand tvix/castore/nodes/directory.rs +88\nas of this commit.\n\nChange-Id: I74d161ea8927362e1cb601ba163489aa96fb91b1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3d21fa4ca092aa194bdac1084055ef1ff4d7d457"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3d21fa4ca092aa194bdac1084055ef1ff4d7d457"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e03ea11badbf40971d6bf87eede33fe3b046c98b","is_merged_in_target_branch":true,"change_id":"Id1be9a8044814b54ce68b125c52dfe933c9c4f74","change_number":12260,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"565c0fd24c616adce50e940fc33b7bf9137a21cc":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-08-21 22:05:57.000000000","uploader":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"},"ref":"refs/changes/59/12259/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/59/12259/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/59/12259/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/59/12259/3"}}},"commit":{"parents":[{"commit":"e03ea11badbf40971d6bf87eede33fe3b046c98b","subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de03ea11badbf40971d6bf87eede33fe3b046c98b"}]}],"author":{"name":"Ben Webb","email":"benjaminedwardwebb@gmail.com","date":"2024-08-20 22:19:26.000000000","tz":-300},"committer":{"name":"benjaminedwardwebb","email":"benjaminedwardwebb@gmail.com","date":"2024-08-21 22:05:57.000000000","tz":0},"subject":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message","message":"fix(tvix/castore): u32 -\u003e u64 in DirectoryError::SizeOverflow message\n\nFix a discrepancy in the error message for DirectoryError::SizeOverflow.\n\nThe message indicates that the SizeOverflow error occurs when total size\nexceeds u32::MAX, but that\u0027s not true. All size fields within the\ncastore\u0027s internal Directory ADT are u64, and the SizeOverflow error is\nonly returned after a call to the checked_add implementation on u64.\n\nSee tvix/castore/nodes/directory.rs +111\nand tvix/castore/nodes/directory.rs +88\nas of this commit.\n\nChange-Id: I74d161ea8927362e1cb601ba163489aa96fb91b1\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12259\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d565c0fd24c616adce50e940fc33b7bf9137a21cc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d565c0fd24c616adce50e940fc33b7bf9137a21cc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e03ea11badbf40971d6bf87eede33fe3b046c98b","is_merged_in_target_branch":true,"change_id":"Id1be9a8044814b54ce68b125c52dfe933c9c4f74","change_number":12260,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000107,"name":"benjaminedwardwebb","display_name":"benwebb","email":"benjaminedwardwebb@gmail.com","username":"benjaminedwardwebb","status":"https://benwebb.site"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}