)]}'
{"id":"depot~12260","triplet_id":"depot~canon~Id1be9a8044814b54ce68b125c52dfe933c9c4f74","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-08-21 09:40:32.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2024-08-21 09:40:32.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-08-21 09:40:32.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-08-21 09:40:32.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-08-21 09:24:05.000000000","reason":"\u003cGERRIT_ACCOUNT_1000073\u003e replied on the change","reason_account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}},"hashtags":[],"change_id":"Id1be9a8044814b54ce68b125c52dfe933c9c4f74","subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","status":"MERGED","created":"2024-08-21 08:54:46.000000000","updated":"2024-08-21 09:40:32.000000000","submitted":"2024-08-21 09:40:32.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12260","meta_rev_id":"c4434e363e35ab9b24c82e3bff979d35767bb70c","_number":12260,"virtual_id_number":12260,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-21 09:40:32.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-21 09:40:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-21 09:40:32.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-21 08:54:46.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2024-08-21 08:54:46.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-08-21 08:54:46.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2024-08-21 08:54:46.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-08-21 08:54:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-21 09:16:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-21 09:40:32.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e1861d28de5dcfd8a4a329af932faadc346a907c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-21 08:54:46.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"8f35181f06f324915b2a68d3a9340da87cb29c4f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 08:54:47.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36044","accounts_in_message":[],"_revision_number":1},{"id":"a26ed4fe015111d1a72183478661fa4c4274dc22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-21 08:55:08.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"347248d1091ece4459617d67cabb81c6d2eb7ff7","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 08:55:09.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/36045","accounts_in_message":[],"_revision_number":2},{"id":"9e2325667acd83c13af766628c54b62bcf3a9ba8","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-08-21 08:59:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5780bc565eb5b56855551843a2f06470a541342c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-21 09:04:04.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e60cd0c925d80fa93404c34114ff66434fea7e9d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 09:04:06.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/36046","accounts_in_message":[],"_revision_number":3},{"id":"0e23302cc74acf5808c2928802433cc77fabcebf","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-08-21 09:06:10.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"9e432abe5b4a3a92026f335ace9e9487a2741bf1","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 09:16:47.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/36046","accounts_in_message":[],"_revision_number":3},{"id":"820ee489ffb9e5ef9eb01797bb25e483922d23b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-21 09:23:09.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"2f901ebca88516968ef558ff1dff126b62fc91ee","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 09:23:11.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/36047","accounts_in_message":[],"_revision_number":4},{"id":"78d82e8eff957f5cb3e0df144255f0193a49183c","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-08-21 09:24:05.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"7bcb3393a9d59e366a8cfa9d952ccb3fb4a501b4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-21 09:26:01.000000000","message":"Patch Set 5: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"854732b6350f88eb74edf19c62a85ce8dc80f8da","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-21 09:40:09.000000000","message":"Patch Set 4: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 5 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/36047","accounts_in_message":[],"_revision_number":4},{"id":"c4434e363e35ab9b24c82e3bff979d35767bb70c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-08-21 09:40:32.000000000","message":"Change has been successfully rebased and submitted as e03ea11badbf40971d6bf87eede33fe3b046c98b\n\n4 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"e03ea11badbf40971d6bf87eede33fe3b046c98b","revisions":{"ced51845283c63792bf8d789e752fb6048cc142d":{"kind":"REWORK","_number":1,"created":"2024-08-21 08:54:46.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/60/12260/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/12260/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/12260/1"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:06:12.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:54:33.000000000","tz":180},"subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","message":"feat(nix-compat/nix_http): init parse_nar[info]_str\n\nThis moves the URL component parsing code we had in nar-bridge to\nnix-compat.\n\nWe change the function signature to return an Option, not a\nResult\u003c_, StatusCode\u003e.\n\nThis allows returning more appropriate error codes, as we can\nok_or_else() at the callsite, which we now do: on an upload to an\ninvalid path, we now return \"unauthorized\", while on a GET/HEAD, we\nreturn \"not found\".\n\nThis also adds support to parse compression suffixes. While not\nsupported in nar-bridge, other users of nix-compat might very well want\nto parse these paths.\n\nAlso fix the error message when parsing NAR urls, it mentioned 32, not\n52, which is a copypasta error from the narinfo URL parsing code.\n\nChange-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dced51845283c63792bf8d789e752fb6048cc142d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dced51845283c63792bf8d789e752fb6048cc142d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9b8787ef8757e35e1020e95683fb5693196a5f00":{"kind":"REWORK","_number":2,"created":"2024-08-21 08:55:08.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/60/12260/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/12260/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/12260/2"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:06:12.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:55:04.000000000","tz":180},"subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","message":"feat(nix-compat/nix_http): init parse_nar[info]_str\n\nThis moves the URL component parsing code we had in nar-bridge to\nnix-compat.\n\nWe change the function signature to return an Option, not a\nResult\u003c_, StatusCode\u003e.\n\nThis allows returning more appropriate error codes, as we can\nok_or_else() at the callsite, which we now do: on an upload to an\ninvalid path, we now return \"unauthorized\", while on a GET/HEAD, we\nreturn \"not found\".\n\nThis also adds support to parse compression suffixes. While not\nsupported in nar-bridge, other users of nix-compat might very well want\nto parse these paths.\n\nAlso fix the error message when parsing NAR urls, it mentioned 32, not\n52, which is a copypasta error from the narinfo URL parsing code.\n\nChange-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9b8787ef8757e35e1020e95683fb5693196a5f00"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9b8787ef8757e35e1020e95683fb5693196a5f00"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"665650d6bc948438e2077335bce49398cbfb6b05":{"kind":"REWORK","_number":3,"created":"2024-08-21 09:04:04.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/60/12260/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/12260/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/12260/3"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:06:12.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 09:03:57.000000000","tz":180},"subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","message":"feat(nix-compat/nix_http): init parse_nar[info]_str\n\nThis moves the URL component parsing code we had in nar-bridge to\nnix-compat.\n\nWe change the function signature to return an Option, not a\nResult\u003c_, StatusCode\u003e.\n\nThis allows returning more appropriate error codes, as we can\nok_or_else() at the callsite, which we now do: on an upload to an\ninvalid path, we now return \"unauthorized\", while on a GET/HEAD, we\nreturn \"not found\".\n\nThis also adds support to parse compression suffixes. While not\nsupported in nar-bridge, other users of nix-compat might very well want\nto parse these paths.\n\nAlso fix the error message when parsing NAR urls, it mentioned 32, not\n52, which is a copypasta error from the narinfo URL parsing code.\n\nChange-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d665650d6bc948438e2077335bce49398cbfb6b05"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d665650d6bc948438e2077335bce49398cbfb6b05"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"77dc7c9f1eee1c36f3ddc0037bc49e3b24899195":{"kind":"REWORK","_number":4,"created":"2024-08-21 09:23:09.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/60/12260/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/12260/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/12260/4"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:06:12.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 09:23:04.000000000","tz":180},"subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","message":"feat(nix-compat/nix_http): init parse_nar[info]_str\n\nThis moves the URL component parsing code we had in nar-bridge to\nnix-compat.\n\nWe change the function signature to return an Option, not a\nResult\u003c_, StatusCode\u003e.\n\nThis allows returning more appropriate error codes, as we can\nok_or_else() at the callsite, which we now do: on an upload to an\ninvalid path, we now return \"unauthorized\", while on a GET/HEAD, we\nreturn \"not found\".\n\nThis also adds support to parse compression suffixes. While not\nsupported in nar-bridge, other users of nix-compat might very well want\nto parse these paths.\n\nAlso fix the error message when parsing NAR urls, it mentioned 32, not\n52, which is a copypasta error from the narinfo URL parsing code.\n\nChange-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d77dc7c9f1eee1c36f3ddc0037bc49e3b24899195"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d77dc7c9f1eee1c36f3ddc0037bc49e3b24899195"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7254252664b02c6b1d01da53e6971ef07f1be267":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-08-21 09:26:01.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/60/12260/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/12260/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/12260/5"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:06:12.000000000","tz":180},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-08-21 09:26:01.000000000","tz":0},"subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","message":"feat(nix-compat/nix_http): init parse_nar[info]_str\n\nThis moves the URL component parsing code we had in nar-bridge to\nnix-compat.\n\nWe change the function signature to return an Option, not a\nResult\u003c_, StatusCode\u003e.\n\nThis allows returning more appropriate error codes, as we can\nok_or(…) at the callsite, which we now do: on an upload to an\ninvalid path, we now return \"unauthorized\", while on a GET/HEAD, we\nreturn \"not found\".\n\nThis also adds support to parse compression suffixes. While not\nsupported in nar-bridge, other users of nix-compat might very well want\nto parse these paths.\n\nAlso fix the error message when parsing NAR urls, it mentioned 32, not\n52, which is a copypasta error from the narinfo URL parsing code.\n\nChange-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7254252664b02c6b1d01da53e6971ef07f1be267"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7254252664b02c6b1d01da53e6971ef07f1be267"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Edit commit message"},"e03ea11badbf40971d6bf87eede33fe3b046c98b":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2024-08-21 09:40:32.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/60/12260/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/12260/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/12260/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/12260/6"}}},"commit":{"parents":[{"commit":"2357079891819c679821ea58a7715de7be431aaa","subject":"feat(kontemplate): defaults can now have nested values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2357079891819c679821ea58a7715de7be431aaa"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-08-21 08:06:12.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-08-21 09:40:32.000000000","tz":0},"subject":"feat(nix-compat/nix_http): init parse_nar[info]_str","message":"feat(nix-compat/nix_http): init parse_nar[info]_str\n\nThis moves the URL component parsing code we had in nar-bridge to\nnix-compat.\n\nWe change the function signature to return an Option, not a\nResult\u003c_, StatusCode\u003e.\n\nThis allows returning more appropriate error codes, as we can\nok_or(…) at the callsite, which we now do: on an upload to an\ninvalid path, we now return \"unauthorized\", while on a GET/HEAD, we\nreturn \"not found\".\n\nThis also adds support to parse compression suffixes. While not\nsupported in nar-bridge, other users of nix-compat might very well want\nto parse these paths.\n\nAlso fix the error message when parsing NAR urls, it mentioned 32, not\n52, which is a copypasta error from the narinfo URL parsing code.\n\nChange-Id: Id1be9a8044814b54ce68b125c52dfe933c9c4f74\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12260\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de03ea11badbf40971d6bf87eede33fe3b046c98b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de03ea11badbf40971d6bf87eede33fe3b046c98b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2357079891819c679821ea58a7715de7be431aaa","is_merged_in_target_branch":true,"change_id":"Ibb54fab7a78e0e5f708c2a7dc8bb26ac0b2b4689","change_number":11972,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}