)]}'
{"id":"depot~12375","triplet_id":"depot~canon~Ifea7a3b84bb8f6f8c76e277979833713bdf51f46","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000082":{"account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"last_update":"2024-08-28 13:55:20.000000000","reason":"\u003cGERRIT_ACCOUNT_1000082\u003e replied on the change","reason_account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}}},"hashtags":[],"change_id":"Ifea7a3b84bb8f6f8c76e277979833713bdf51f46","subject":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80","status":"MERGED","created":"2024-08-28 13:53:39.000000000","updated":"2024-08-28 14:08:39.000000000","submitted":"2024-08-28 14:08:39.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12375","meta_rev_id":"f149d496e69fb918ac0824640c9a1decae5f2469","_number":12375,"virtual_id_number":12375,"owner":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-28 14:08:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-28 14:08:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-28 14:08:39.000000000","_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-28 13:53:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-28 13:54:36.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-08-28 14:08:29.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-28 14:08:39.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d84d2fdd0795cdcc369ba99934f79f9d0a121e03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-08-28 13:53:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00b0fb4c09d4c326478bcb4aa98eddf7260d5620","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-28 13:53:39.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36257","accounts_in_message":[],"_revision_number":1},{"id":"51940d89f53c01e1ad456ddd94508468aed384c1","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-28 13:54:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6f86dfe85c663a5602a6c69c422464da921760a4","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-08-28 13:55:20.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"da4a1a8c672867502b1467cf377105fd99b7c7c8","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-28 14:08:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/36257","accounts_in_message":[],"_revision_number":1},{"id":"f149d496e69fb918ac0824640c9a1decae5f2469","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-08-28 14:08:39.000000000","message":"Change has been successfully rebased and submitted as 743407e7abf9cf56274c8c9bcb1edb10d8f943ed","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"743407e7abf9cf56274c8c9bcb1edb10d8f943ed","revisions":{"0366d3c5c1fa6c5dfc6e65bc069d8c442e5c4768":{"kind":"REWORK","_number":1,"created":"2024-08-28 13:53:39.000000000","uploader":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"ref":"refs/changes/75/12375/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/75/12375/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/75/12375/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/75/12375/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/75/12375/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/75/12375/1"}}},"commit":{"parents":[{"commit":"7bf6563da1b6c2989289c5a753e1dd806aae4570","subject":"fix(ops/users): fix email address for yl3dy","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bf6563da1b6c2989289c5a753e1dd806aae4570"}]}],"author":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:39:56.000000000","tz":120},"committer":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:53:21.000000000","tz":120},"subject":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80","message":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80\n\nExclusive range patterns were stabilized in Rust version 1.80 but Tvix\nstill uses Rust 1.79 and so would fail this one test when you ran\ndoctests from `mg shell //tvix:shell`.\n\nIt was not caught by CI because that does not currently run doctests.\n\nThe fix is just to use an inclusive pattern instead.\n\nFixes: b/417\nChange-Id: Ifea7a3b84bb8f6f8c76e277979833713bdf51f46\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0366d3c5c1fa6c5dfc6e65bc069d8c442e5c4768"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0366d3c5c1fa6c5dfc6e65bc069d8c442e5c4768"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7bf6563da1b6c2989289c5a753e1dd806aae4570","is_merged_in_target_branch":true,"change_id":"Id943cbb486073173a8391074c326749bffb990f7","change_number":12361,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"743407e7abf9cf56274c8c9bcb1edb10d8f943ed":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-08-28 14:08:39.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/75/12375/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/75/12375/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/75/12375/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/75/12375/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/75/12375/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/75/12375/2"}}},"commit":{"parents":[{"commit":"7bf6563da1b6c2989289c5a753e1dd806aae4570","subject":"fix(ops/users): fix email address for yl3dy","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bf6563da1b6c2989289c5a753e1dd806aae4570"}]}],"author":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:39:56.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-08-28 14:08:39.000000000","tz":0},"subject":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80","message":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80\n\nExclusive range patterns were stabilized in Rust version 1.80 but Tvix\nstill uses Rust 1.79 and so would fail this one test when you ran\ndoctests from `mg shell //tvix:shell`.\n\nIt was not caught by CI because that does not currently run doctests.\n\nThe fix is just to use an inclusive pattern instead.\n\nFixes: b/417\nChange-Id: Ifea7a3b84bb8f6f8c76e277979833713bdf51f46\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12375\nAutosubmit: Brian Olsen \u003cme@griff.name\u003e\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d743407e7abf9cf56274c8c9bcb1edb10d8f943ed"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d743407e7abf9cf56274c8c9bcb1edb10d8f943ed"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7bf6563da1b6c2989289c5a753e1dd806aae4570","is_merged_in_target_branch":true,"change_id":"Id943cbb486073173a8391074c326749bffb990f7","change_number":12361,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}