)]}'
{"id":"depot~12376","triplet_id":"depot~canon~Ia3e89c6c350c3fb22ca87f974a39c21542aae152","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000082":{"account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"last_update":"2024-08-28 14:43:00.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-08-28 14:42:44.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ia3e89c6c350c3fb22ca87f974a39c21542aae152","subject":"fix(tvix/nix-compat-derive): Get rid of external feature flag","status":"MERGED","created":"2024-08-28 13:53:39.000000000","updated":"2024-08-28 14:43:00.000000000","submitted":"2024-08-28 14:43:00.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12376","meta_rev_id":"dc940260a339851650d0bd29cd70688765f296b4","_number":12376,"virtual_id_number":12376,"owner":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-28 14:43:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-28 14:43:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-28 14:43:00.000000000","_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-28 13:53:40.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-28 13:54:51.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-08-28 14:15:28.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-28 14:43:00.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ec700b9985e3b7715b693efca7ed834a0fb3d0d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-08-28 13:53:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"752ad76229e53bfe4465486642b84f57669075c3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-28 13:53:40.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36258","accounts_in_message":[],"_revision_number":1},{"id":"fb9a357c2b5f5ad6e96e492edf879d003d434ac2","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-28 13:54:51.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8e361e86c5d9800bba00fed84a27a553d40d392e","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-08-28 13:55:27.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"b6fb7780029e5dfd5f2781a42edb94ece5d6e327","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-28 14:15:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/36258","accounts_in_message":[],"_revision_number":1},{"id":"00313442600c918e8115dc08bd8de1bd412160b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-08-28 14:18:37.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f6a9dba76a5181e0daea6c513f853feea96beff4","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-28 14:18:38.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/36260","accounts_in_message":[],"_revision_number":2},{"id":"8f51b3f79ab4660fe3722493f82b0a6010fc9e37","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-08-28 14:32:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/36260","accounts_in_message":[],"_revision_number":2},{"id":"7fcb3ad231c336805a8f60ccafa8d0ea7a1485d9","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-08-28 14:42:44.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dc940260a339851650d0bd29cd70688765f296b4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-08-28 14:43:00.000000000","message":"Change has been successfully rebased and submitted as a5fcfd80a16d985bcef7011ad94eab86cc0b4a72","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a5fcfd80a16d985bcef7011ad94eab86cc0b4a72","revisions":{"383d364983a84242836fae233bebbf500f7c2e17":{"kind":"REWORK","_number":1,"created":"2024-08-28 13:53:39.000000000","uploader":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"ref":"refs/changes/76/12376/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/76/12376/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/76/12376/1"}}},"commit":{"parents":[{"commit":"0366d3c5c1fa6c5dfc6e65bc069d8c442e5c4768","subject":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0366d3c5c1fa6c5dfc6e65bc069d8c442e5c4768"}]}],"author":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:45:50.000000000","tz":120},"committer":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:53:21.000000000","tz":120},"subject":"fix(tvix/nix-compat-derive): Get rid of external feature flag","message":"fix(tvix/nix-compat-derive): Get rid of external feature flag\n\nThe external feature flag was there because I couldn\u0027t find a way to\nrefer to crate and nix-compat with the same name so that the generated\ncode could be the same.\n\nIn essence `use nix_compat::nix_daemon::de::NixDeserialize` is an error\nwhen used inside nix_compat crate.\n\nSo my best fix was the external feature flag until I found the solution\nused here which also removes the flag completely.\n\nChange-Id: Ia3e89c6c350c3fb22ca87f974a39c21542aae152\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d383d364983a84242836fae233bebbf500f7c2e17"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d383d364983a84242836fae233bebbf500f7c2e17"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0366d3c5c1fa6c5dfc6e65bc069d8c442e5c4768","is_merged_in_target_branch":false,"change_id":"Ifea7a3b84bb8f6f8c76e277979833713bdf51f46","change_number":12375,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d7a4ecf090a9a0def71866570bb086a798d3bba1":{"kind":"REWORK","_number":2,"created":"2024-08-28 14:18:37.000000000","uploader":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"ref":"refs/changes/76/12376/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/76/12376/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/76/12376/2"}}},"commit":{"parents":[{"commit":"743407e7abf9cf56274c8c9bcb1edb10d8f943ed","subject":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d743407e7abf9cf56274c8c9bcb1edb10d8f943ed"}]}],"author":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:45:50.000000000","tz":120},"committer":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 14:18:22.000000000","tz":120},"subject":"fix(tvix/nix-compat-derive): Get rid of external feature flag","message":"fix(tvix/nix-compat-derive): Get rid of external feature flag\n\nThe external feature flag was there because I couldn\u0027t find a way to\nrefer to crate and nix-compat with the same name so that the generated\ncode could be the same.\n\nIn essence `use nix_compat::nix_daemon::de::NixDeserialize` is an error\nwhen used inside nix_compat crate.\n\nSo my best fix was the external feature flag until I found the solution\nused here which also removes the flag completely.\n\nChange-Id: Ia3e89c6c350c3fb22ca87f974a39c21542aae152\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd7a4ecf090a9a0def71866570bb086a798d3bba1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd7a4ecf090a9a0def71866570bb086a798d3bba1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"743407e7abf9cf56274c8c9bcb1edb10d8f943ed","is_merged_in_target_branch":true,"change_id":"Ifea7a3b84bb8f6f8c76e277979833713bdf51f46","change_number":12375,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a5fcfd80a16d985bcef7011ad94eab86cc0b4a72":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-08-28 14:43:00.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/76/12376/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/76/12376/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/76/12376/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/76/12376/3"}}},"commit":{"parents":[{"commit":"743407e7abf9cf56274c8c9bcb1edb10d8f943ed","subject":"fix(tvix/nix-compat-derive): Fix doctest for Rust older than 1.80","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d743407e7abf9cf56274c8c9bcb1edb10d8f943ed"}]}],"author":{"name":"Brian Olsen","email":"brian@maven-group.org","date":"2024-08-28 13:45:50.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-08-28 14:43:00.000000000","tz":0},"subject":"fix(tvix/nix-compat-derive): Get rid of external feature flag","message":"fix(tvix/nix-compat-derive): Get rid of external feature flag\n\nThe external feature flag was there because I couldn\u0027t find a way to\nrefer to crate and nix-compat with the same name so that the generated\ncode could be the same.\n\nIn essence `use nix_compat::nix_daemon::de::NixDeserialize` is an error\nwhen used inside nix_compat crate.\n\nSo my best fix was the external feature flag until I found the solution\nused here which also removes the flag completely.\n\nChange-Id: Ia3e89c6c350c3fb22ca87f974a39c21542aae152\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12376\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nAutosubmit: Brian Olsen \u003cme@griff.name\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da5fcfd80a16d985bcef7011ad94eab86cc0b4a72"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da5fcfd80a16d985bcef7011ad94eab86cc0b4a72"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"743407e7abf9cf56274c8c9bcb1edb10d8f943ed","is_merged_in_target_branch":true,"change_id":"Ifea7a3b84bb8f6f8c76e277979833713bdf51f46","change_number":12375,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}