)]}'
{"tvix/Cargo.toml":[{"author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"change_message_id":"3b3cb598f8ee9bd72a9a189f1bd6a8a8010266ce","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  \"nix-compat-derive-tests\","},{"line_number":32,"context_line":"  \"serde\","},{"line_number":33,"context_line":"  \"store\","},{"line_number":34,"context_line":"  \"tools/tvix-eval-jobs\","},{"line_number":35,"context_line":"  \"tracing\","},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-toml","patch_set":16,"id":"628b0eda_278608a0","line":34,"updated":"2024-09-07 15:29:34.000000000","message":"Why does this need to be part of the tvix workspace? It can just be an independent program that uses tvix, no?","commit_id":"5eb9161f67e432072f498f72f5db72df967f9630"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"73d945f56ef95f9061bdfba0065a4a906171f3d6","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  \"nix-compat-derive-tests\","},{"line_number":32,"context_line":"  \"serde\","},{"line_number":33,"context_line":"  \"store\","},{"line_number":34,"context_line":"  \"tools/tvix-eval-jobs\","},{"line_number":35,"context_line":"  \"tracing\","},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-toml","patch_set":16,"id":"476b7e74_cea6bd2a","line":34,"in_reply_to":"628b0eda_278608a0","updated":"2024-09-14 21:15:37.000000000","message":"Yes, I agree.","commit_id":"5eb9161f67e432072f498f72f5db72df967f9630"}],"tvix/tools/tvix-eval-jobs/src/main.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"/// Provides a CLI interface to trigger mass evaluation jobs"},{"line_number":15,"context_line":"///"},{"line_number":16,"context_line":"/// Does not configure a store or a build component."},{"line_number":17,"context_line":"/// Sets a default set of builtins similar to these present in Nix."},{"line_number":18,"context_line":"///"},{"line_number":19,"context_line":"/// No `.drv` is written to the local `/nix/store` location."}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"618b8bac_ed140791","line":16,"updated":"2024-09-03 11:30:33.000000000","message":"it does configure, it\u0027s at service_addrs and build_service_addr!","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"/// Provides a CLI interface to trigger mass evaluation jobs"},{"line_number":15,"context_line":"///"},{"line_number":16,"context_line":"/// Does not configure a store or a build component."},{"line_number":17,"context_line":"/// Sets a default set of builtins similar to these present in Nix."},{"line_number":18,"context_line":"///"},{"line_number":19,"context_line":"/// No `.drv` is written to the local `/nix/store` location."}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"c4eb7aa2_ae0d20d4","line":16,"in_reply_to":"618b8bac_ed140791","updated":"2024-09-06 14:24:36.000000000","message":"Done","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":21,"context_line":"/// The CLI interface is not stable and subject to change."},{"line_number":22,"context_line":"#[derive(Parser, Clone)]"},{"line_number":23,"context_line":"struct Args {"},{"line_number":24,"context_line":"    /// A global log level to use when printing logs."},{"line_number":25,"context_line":"    /// It\u0027s also possible to set `RUST_LOG` according to"},{"line_number":26,"context_line":"    /// `tracing_subscriber::filter::EnvFilter`, which will always have"},{"line_number":27,"context_line":"    /// priority."}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"dbb6f81d_e7a4b8e0","line":24,"updated":"2024-09-03 11:30:33.000000000","message":"this is copy pasted from somewhere, only use RUST_LOG please.","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"/// The CLI interface is not stable and subject to change."},{"line_number":22,"context_line":"#[derive(Parser, Clone)]"},{"line_number":23,"context_line":"struct Args {"},{"line_number":24,"context_line":"    /// A global log level to use when printing logs."},{"line_number":25,"context_line":"    /// It\u0027s also possible to set `RUST_LOG` according to"},{"line_number":26,"context_line":"    /// `tracing_subscriber::filter::EnvFilter`, which will always have"},{"line_number":27,"context_line":"    /// priority."}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"34e64613_182a534f","line":24,"in_reply_to":"dbb6f81d_e7a4b8e0","updated":"2024-09-06 14:24:36.000000000","message":"Okay","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        Self {"},{"line_number":54,"context_line":"            drv_path: drv_path"},{"line_number":55,"context_line":"                .to_contextful_str()"},{"line_number":56,"context_line":"                .expect(\"Did not found a string derivation path\")"},{"line_number":57,"context_line":"                .to_string(),"},{"line_number":58,"context_line":"            out_path: out_path"},{"line_number":59,"context_line":"                .to_contextful_str()"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"29bc86d3_e05647a0","line":56,"updated":"2024-09-03 11:30:33.000000000","message":"```suggestion\n                .expect(\"Did not find a string derivation path\")\n```\n\n\"did\" already makes it past tense.","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        Self {"},{"line_number":54,"context_line":"            drv_path: drv_path"},{"line_number":55,"context_line":"                .to_contextful_str()"},{"line_number":56,"context_line":"                .expect(\"Did not found a string derivation path\")"},{"line_number":57,"context_line":"                .to_string(),"},{"line_number":58,"context_line":"            out_path: out_path"},{"line_number":59,"context_line":"                .to_contextful_str()"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"d571ab63_c0782353","line":56,"in_reply_to":"29bc86d3_e05647a0","updated":"2024-09-06 14:24:36.000000000","message":"Done","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                .to_string(),"},{"line_number":58,"context_line":"            out_path: out_path"},{"line_number":59,"context_line":"                .to_contextful_str()"},{"line_number":60,"context_line":"                .expect(\"Did not found a string output path\")"},{"line_number":61,"context_line":"                .to_string(),"},{"line_number":62,"context_line":"        }"},{"line_number":63,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"6f6621f5_6e63a5ca","line":60,"updated":"2024-09-03 11:30:33.000000000","message":"```suggestion\n                .expect(\"Did not find a string output path\")\n```\n\n\n\"did\" already makes it past tense.","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                .to_string(),"},{"line_number":58,"context_line":"            out_path: out_path"},{"line_number":59,"context_line":"                .to_contextful_str()"},{"line_number":60,"context_line":"                .expect(\"Did not found a string output path\")"},{"line_number":61,"context_line":"                .to_string(),"},{"line_number":62,"context_line":"        }"},{"line_number":63,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"6a1c685c_748a250d","line":60,"in_reply_to":"6f6621f5_6e63a5ca","updated":"2024-09-06 14:24:36.000000000","message":"Done","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        .expect(\"unable to setup buildservice before interpreter setup\");"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Rc::new(TvixStoreIO::new("},{"line_number":97,"context_line":"        blob_service.clone(),"},{"line_number":98,"context_line":"        directory_service.clone(),"},{"line_number":99,"context_line":"        path_info_service,"},{"line_number":100,"context_line":"        nar_calculation_service.into(),"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"7a8a0b04_503154f5","line":97,"updated":"2024-09-03 11:30:33.000000000","message":"why clones here?","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        .expect(\"unable to setup buildservice before interpreter setup\");"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Rc::new(TvixStoreIO::new("},{"line_number":97,"context_line":"        blob_service.clone(),"},{"line_number":98,"context_line":"        directory_service.clone(),"},{"line_number":99,"context_line":"        path_info_service,"},{"line_number":100,"context_line":"        nar_calculation_service.into(),"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"915b3610_25b4b3b1","line":97,"in_reply_to":"7a8a0b04_503154f5","updated":"2024-09-06 14:24:36.000000000","message":"\u003e why clones here?\n\nonly necessary for the tokio runtime indeed","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        span: codemap::Span,"},{"line_number":201,"context_line":"        path: Option\u003cString\u003e,"},{"line_number":202,"context_line":"    ) {"},{"line_number":203,"context_line":"        println!(\"path: {:?}\", path);"},{"line_number":204,"context_line":"        match toplevel {"},{"line_number":205,"context_line":"            Value::Attrs(attrs) \u003d\u003e {"},{"line_number":206,"context_line":"                let mut recurse \u003d"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"c15e9c9f_789ad36d","line":203,"updated":"2024-09-03 11:30:33.000000000","message":"this should probably be a field of the method annotated with the instrument macro.","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        span: codemap::Span,"},{"line_number":201,"context_line":"        path: Option\u003cString\u003e,"},{"line_number":202,"context_line":"    ) {"},{"line_number":203,"context_line":"        println!(\"path: {:?}\", path);"},{"line_number":204,"context_line":"        match toplevel {"},{"line_number":205,"context_line":"            Value::Attrs(attrs) \u003d\u003e {"},{"line_number":206,"context_line":"                let mut recurse \u003d"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"4d017bad_b2291063","line":203,"in_reply_to":"c15e9c9f_789ad36d","updated":"2024-09-06 14:24:36.000000000","message":"Acknowledged","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":217,"context_line":"                    }"},{"line_number":218,"context_line":"                }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"                println!(\"Will recurse? {:?}\", recurse);"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"                if recurse {"},{"line_number":223,"context_line":"                    for (key, value) in attrs.into_iter_sorted() {"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"528dd8ab_3fc39c20","line":220,"updated":"2024-09-03 11:30:33.000000000","message":"trace!, or remove?","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                    }"},{"line_number":218,"context_line":"                }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"                println!(\"Will recurse? {:?}\", recurse);"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"                if recurse {"},{"line_number":223,"context_line":"                    for (key, value) in attrs.into_iter_sorted() {"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"53b9cc9b_37745f12","line":220,"in_reply_to":"528dd8ab_3fc39c20","updated":"2024-09-06 14:24:36.000000000","message":"Done","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"089c467a20a34a2084ae7cdb411ad5d0fa19bedf","unresolved":true,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    walker.boot(args.expr.unwrap());"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    println!(\"drvs: {:#?}\", walker.derivations);"},{"line_number":279,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"d4e66b00_ea18e678","line":278,"updated":"2024-09-03 11:30:33.000000000","message":"I\u0027d prefer derivations to be private. It\u0027s a bit unclear what we want to get from this later on, but maybe provide access to KnownPaths somehow?","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c4e53d629d567b46c2b6e23eccec7f97742872e0","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    walker.boot(args.expr.unwrap());"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    println!(\"drvs: {:#?}\", walker.derivations);"},{"line_number":279,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":9,"id":"7e9b3064_72d96241","line":278,"in_reply_to":"d4e66b00_ea18e678","updated":"2024-09-06 14:24:36.000000000","message":"Acknowledged","commit_id":"cb5e6267ce8ec10cceeb889f016ca99b1aab62d4"}]}
