)]}'
{"id":"depot~12504","triplet_id":"depot~canon~I2996cdd2e0107133e502748947298f512f1cc521","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000128":{"account":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"last_update":"2024-09-24 09:45:33.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-09-23 18:00:58.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-09-24 09:45:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2996cdd2e0107133e502748947298f512f1cc521","subject":"fix(tvix/nar-bridge): Remove name check for root node in nar generation","status":"MERGED","created":"2024-09-23 11:28:30.000000000","updated":"2024-09-24 09:45:33.000000000","submitted":"2024-09-24 09:45:33.000000000","submitter":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12504","meta_rev_id":"8f0b5f8d07f5504ae8b34166e560527a64731065","_number":12504,"virtual_id_number":12504,"owner":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-24 09:45:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-24 09:45:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"all":[{"value":0,"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"all":[{"value":0,"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-23 11:28:31.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-09-23 11:37:59.000000000","updated_by":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-09-23 11:37:59.000000000","updated_by":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-09-23 11:45:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9308342adf101de10c6916148bfff18baa2823e6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-23 11:28:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a431a656a00b4c045b66ad7edd8d5dafd38ec8f5","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-09-23 11:28:31.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36685","accounts_in_message":[],"_revision_number":1},{"id":"0995903cd802ed71c4f65f9fbd8ecebffa1a280e","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-23 11:37:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2039a52fc187d9a2c408d087621cd01e4daa4c75","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-23 11:37:59.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/castore/src/errors.rs`\n* `tvix/castore/src/proto/mod.rs`\n* `tvix/nar-bridge/src/nar.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"2b50055bab9703edfa201f7a8366575f54d3ec74","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-09-23 11:45:39.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/36685","accounts_in_message":[],"_revision_number":1},{"id":"7b626b5dd1cf35c9e69f7a0beea51b3c8eda6e10","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-09-23 11:54:16.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ea024532fafb5ccfd5128bbbf9514de6ec269fd0","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-09-23 11:56:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1331e6fcb777deb5b644b925bc0a0d18499a387e","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-09-23 12:02:40.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"baede02419b476d9368959c962d111103d36189c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-23 16:22:13.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"50b1c943a0c780c745d4a87c22b33d7f64ae62e2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-09-23 16:22:14.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/36689","accounts_in_message":[],"_revision_number":2},{"id":"ede5aea8ebb72e7fefda431be7ffde7b750b92ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-23 16:28:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"45104a206eef92852ff05c2693efb060924a63e9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-09-23 16:28:39.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/36690","accounts_in_message":[],"_revision_number":3},{"id":"05eb233325b5bec3451c9a1f769e99769d0d394a","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-23 16:29:09.000000000","message":"Patch Set 1:\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4d2a601e841843fc8d70f041b2787bb16dc4b77d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-09-23 16:45:21.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/36690","accounts_in_message":[],"_revision_number":3},{"id":"e64d7f2a9a15165b033478eff3e06b8e4a70efa3","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-09-23 18:00:58.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"78ff68117cd277572c54891b976388c097bba84b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-24 09:44:14.000000000","message":"Uploaded patch set 4: Commit message was updated.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"8f0b5f8d07f5504ae8b34166e560527a64731065","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"date":"2024-09-24 09:45:33.000000000","message":"Change has been successfully rebased and submitted as 0f924001122b41a3f2a239a2f9f9edea9da96c7d\n\n3 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"0f924001122b41a3f2a239a2f9f9edea9da96c7d","revisions":{"a9be785c9281b96c9bb2cf5f29fb5e4783e59ae0":{"kind":"REWORK","_number":1,"created":"2024-09-23 11:28:30.000000000","uploader":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"ref":"refs/changes/04/12504/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/12504/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/12504/1"}}},"commit":{"parents":[{"commit":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","subject":"chore(tazjin/koptevo): allow other device\u0027s public keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f028165f2c710578ad3941eb303e1bc9f8a8c0b"}]}],"author":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-22 19:28:39.000000000","tz":120},"committer":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-23 11:27:59.000000000","tz":120},"subject":"fix(nar_bridge): Don\u0027t check if root node has a name in nar generation","message":"fix(nar_bridge): Don\u0027t check if root node has a name in nar generation\n\nNar-bridge tried to parse the name of the protobuf node encoded in the\nURL into a PathComponent but this name was empty, leading to an error\nwhen the user tried to retrieve the nar file. This commit removes this\nuseless step and fixes the errors caused by it\n\nChange-Id: I2996cdd2e0107133e502748947298f512f1cc521\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9be785c9281b96c9bb2cf5f29fb5e4783e59ae0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9be785c9281b96c9bb2cf5f29fb5e4783e59ae0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","is_merged_in_target_branch":true,"change_id":"I4955c2cde3cb1ec4d7b72eaaf7f6acc80150dd73","change_number":12503,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"553311894940c8718427eabafa0c0ee242624e4f":{"kind":"REWORK","_number":2,"created":"2024-09-23 16:22:13.000000000","uploader":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"ref":"refs/changes/04/12504/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/12504/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/12504/2"}}},"commit":{"parents":[{"commit":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","subject":"chore(tazjin/koptevo): allow other device\u0027s public keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f028165f2c710578ad3941eb303e1bc9f8a8c0b"}]}],"author":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-22 19:28:39.000000000","tz":120},"committer":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-23 16:21:12.000000000","tz":120},"subject":"fix(tvix/nar_bridge): Don\u0027t check if root node has a name in nar generation","message":"fix(tvix/nar_bridge): Don\u0027t check if root node has a name in nar generation\n\nNar-bridge tried to parse the name of the protobuf node encoded in the\nURL into a PathComponent but this name was empty, leading to an error\nwhen the user tried to retrieve the nar file.\n\nThis was an oversight from the conversion to stricter types (some of the\nCLs in the serious containing cl/12217).\n\nWe need a version converting a protobuf without a name to our stricter\ntypes, but an empty PathComponent cannot be constructed.\n\nSo we need a into_name_and_node() version that returns the name as\nBytes, not PathComponent.\n\nChange-Id: I2996cdd2e0107133e502748947298f512f1cc521\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d553311894940c8718427eabafa0c0ee242624e4f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d553311894940c8718427eabafa0c0ee242624e4f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","is_merged_in_target_branch":true,"change_id":"I4955c2cde3cb1ec4d7b72eaaf7f6acc80150dd73","change_number":12503,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"bd2a570c480df426c1711d18369adf63b2acedb7":{"kind":"REWORK","_number":3,"created":"2024-09-23 16:28:38.000000000","uploader":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"ref":"refs/changes/04/12504/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/12504/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/12504/3"}}},"commit":{"parents":[{"commit":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","subject":"chore(tazjin/koptevo): allow other device\u0027s public keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f028165f2c710578ad3941eb303e1bc9f8a8c0b"}]}],"author":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-22 19:28:39.000000000","tz":120},"committer":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-23 16:28:31.000000000","tz":120},"subject":"fix(tvix/nar_bridge): Don\u0027t check if root node has a name in nar generation","message":"fix(tvix/nar_bridge): Don\u0027t check if root node has a name in nar generation\n\nNar-bridge tried to parse the name of the protobuf node encoded in the\nURL into a PathComponent but this name was empty, leading to an error\nwhen the user tried to retrieve the nar file.\n\nThis was an oversight from the conversion to stricter types (some of the\nCLs in the serious containing cl/12217).\n\nWe need a version converting a protobuf without a name to our stricter\ntypes, but an empty PathComponent cannot be constructed.\n\nSo we need a into_name_and_node() version that returns the name as\nBytes, not PathComponent.\n\nChange-Id: I2996cdd2e0107133e502748947298f512f1cc521\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd2a570c480df426c1711d18369adf63b2acedb7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd2a570c480df426c1711d18369adf63b2acedb7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","is_merged_in_target_branch":true,"change_id":"I4955c2cde3cb1ec4d7b72eaaf7f6acc80150dd73","change_number":12503,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"66072834142ef82d935ebb319b7eb0b4ff202455":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2024-09-24 09:44:14.000000000","uploader":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"ref":"refs/changes/04/12504/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/12504/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/12504/4"}}},"commit":{"parents":[{"commit":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","subject":"chore(tazjin/koptevo): allow other device\u0027s public keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f028165f2c710578ad3941eb303e1bc9f8a8c0b"}]}],"author":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-22 19:28:39.000000000","tz":120},"committer":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-24 09:43:59.000000000","tz":120},"subject":"fix(tvix/nar-bridge): Remove name check for root node in nar generation","message":"fix(tvix/nar-bridge): Remove name check for root node in nar generation\n\nNar-bridge tried to parse the name of the protobuf node encoded in the\nURL into a PathComponent but this name was empty, leading to an error\nwhen the user tried to retrieve the nar file.\n\nThis was an oversight from the conversion to stricter types (some of the\nCLs in the serious containing cl/12217).\n\nWe need a version converting a protobuf without a name to our stricter\ntypes, but an empty PathComponent cannot be constructed.\n\nSo we need a into_name_and_node() version that returns the name as\nBytes, not PathComponent.\n\nChange-Id: I2996cdd2e0107133e502748947298f512f1cc521\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d66072834142ef82d935ebb319b7eb0b4ff202455"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d66072834142ef82d935ebb319b7eb0b4ff202455"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6f028165f2c710578ad3941eb303e1bc9f8a8c0b","is_merged_in_target_branch":true,"change_id":"I4955c2cde3cb1ec4d7b72eaaf7f6acc80150dd73","change_number":12503,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0f924001122b41a3f2a239a2f9f9edea9da96c7d":{"kind":"REWORK","_number":5,"created":"2024-09-24 09:45:33.000000000","uploader":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"},"ref":"refs/changes/04/12504/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/12504/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/12504/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/12504/5"}}},"commit":{"parents":[{"commit":"cd0c3a96ab7355f7e6c0309a3088ac185bef9355","subject":"feat(tvix/nix-compat/nar/writer/sync): add file_manual_write","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcd0c3a96ab7355f7e6c0309a3088ac185bef9355"}]}],"author":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-22 19:28:39.000000000","tz":120},"committer":{"name":"sinavir","email":"tvix@sinavir.fr","date":"2024-09-24 09:45:33.000000000","tz":0},"subject":"fix(tvix/nar-bridge): Remove name check for root node in nar generation","message":"fix(tvix/nar-bridge): Remove name check for root node in nar generation\n\nNar-bridge tried to parse the name of the protobuf node encoded in the\nURL into a PathComponent but this name was empty, leading to an error\nwhen the user tried to retrieve the nar file.\n\nThis was an oversight from the conversion to stricter types (some of the\nCLs in the serious containing cl/12217).\n\nWe need a version converting a protobuf without a name to our stricter\ntypes, but an empty PathComponent cannot be constructed.\n\nSo we need a into_name_and_node() version that returns the name as\nBytes, not PathComponent.\n\nChange-Id: I2996cdd2e0107133e502748947298f512f1cc521\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12504\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0f924001122b41a3f2a239a2f9f9edea9da96c7d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0f924001122b41a3f2a239a2f9f9edea9da96c7d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cd0c3a96ab7355f7e6c0309a3088ac185bef9355","is_merged_in_target_branch":true,"change_id":"I447c09914fb0c99044e2fa910d4213660dc51c64","change_number":12437,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000128,"name":"sinavir","email":"tvix@sinavir.fr","username":"sinavir"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}