)]}'
{"tvix/nar-bridge/src/nar.rs":[{"author":{"_account_id":1000106,"name":"yuka","email":"yuka@yuka.dev","username":"yuka"},"change_message_id":"8bbab1ff9c2b71d38e763316d7fed28eb0710ccf","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                        StatusCode::INTERNAL_SERVER_ERROR"},{"line_number":82,"context_line":"                    })?;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            Ranged::new(Some(ranges), KnownSize::sized(r, nar_size)).into_response()"},{"line_number":85,"context_line":"        } else {"},{"line_number":86,"context_line":"            let (w, r) \u003d tokio::io::duplex(1024 * 8);"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"aea21cad_d16b9d3b","line":84,"updated":"2024-09-27 13:06:57.000000000","message":"Is it a good idea to rely on the nar size received from the client here?","commit_id":"9e0a9e9f86a931e46fe192e023732919ece8e6b0"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"7de34f6111cf71971fb5189d48c41a619fc506d6","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                        StatusCode::INTERNAL_SERVER_ERROR"},{"line_number":82,"context_line":"                    })?;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            Ranged::new(Some(ranges), KnownSize::sized(r, nar_size)).into_response()"},{"line_number":85,"context_line":"        } else {"},{"line_number":86,"context_line":"            let (w, r) \u003d tokio::io::duplex(1024 * 8);"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"d5c5d15e_7bb86e16","line":84,"in_reply_to":"358070d8_de8dfb04","updated":"2024-09-29 17:03:59.000000000","message":"I just realized we know the nar_size we\u0027re expecting, it\u0027s in stream_len(). will update the CL in a minute.","commit_id":"9e0a9e9f86a931e46fe192e023732919ece8e6b0"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"6d0e3ce63991364886360dd7baac31ce9134b318","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                        StatusCode::INTERNAL_SERVER_ERROR"},{"line_number":82,"context_line":"                    })?;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            Ranged::new(Some(ranges), KnownSize::sized(r, nar_size)).into_response()"},{"line_number":85,"context_line":"        } else {"},{"line_number":86,"context_line":"            let (w, r) \u003d tokio::io::duplex(1024 * 8);"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"358070d8_de8dfb04","line":84,"in_reply_to":"aea21cad_d16b9d3b","updated":"2024-09-27 13:37:04.000000000","message":"As long as our seekable reader doesn\u0027t panic if you seek past the file, it should be fine, no?\n\nWe probably can determine the total length (and expose) and reject if it differs, but that\u0027s probably something for a follow-up.","commit_id":"9e0a9e9f86a931e46fe192e023732919ece8e6b0"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"56131dc1e84dcc9e93dc859cd4760779a664fe58","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                        StatusCode::INTERNAL_SERVER_ERROR"},{"line_number":82,"context_line":"                    })?;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            Ranged::new(Some(ranges), KnownSize::sized(r, nar_size)).into_response()"},{"line_number":85,"context_line":"        } else {"},{"line_number":86,"context_line":"            let (w, r) \u003d tokio::io::duplex(1024 * 8);"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"41ae1fe4_123ca052","line":84,"in_reply_to":"d5c5d15e_7bb86e16","updated":"2024-09-29 17:15:11.000000000","message":"Done. also removed setting some headers redundantly.","commit_id":"9e0a9e9f86a931e46fe192e023732919ece8e6b0"}]}