)]}'
{"id":"depot~12564","triplet_id":"depot~canon~Ifc3eb272af761670ec83305665ec2103eb4f269e","project":"depot","branch":"canon","hashtags":[],"change_id":"Ifc3eb272af761670ec83305665ec2103eb4f269e","subject":"feat(tazjin/niri-reap): improve reaping of workspaces above","status":"MERGED","created":"2024-10-02 14:05:39.000000000","updated":"2024-10-02 14:35:48.000000000","submitted":"2024-10-02 14:35:48.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"12564","meta_rev_id":"3ab0786db1275f1315fecf507e537b4dd2afdb5c","_number":12564,"virtual_id_number":12564,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-02 14:35:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-02 14:35:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-02 14:35:48.000000000","_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-02 14:05:40.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-10-02 14:35:40.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-10-02 14:35:48.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"94ad518718829729cf949c2a78c362238a925987","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-10-02 14:05:39.000000000","message":"Uploaded patch set 1: Autosubmit+1 Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"c41067da9874a1a33787108c8a9c5a7691577989","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-10-02 14:05:40.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/36884","accounts_in_message":[],"_revision_number":1},{"id":"6e7a5aa12236247d41754d66aa5b9bd6593509c5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-10-02 14:29:17.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"48218dc0b127e292a1a768b99320ac9baf62ebbe","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-10-02 14:29:18.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/36886","accounts_in_message":[],"_revision_number":2},{"id":"43a07d5c4c341530e6cb86531d741a55e6f4818c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-10-02 14:35:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/36886","accounts_in_message":[],"_revision_number":2},{"id":"3ab0786db1275f1315fecf507e537b4dd2afdb5c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-10-02 14:35:48.000000000","message":"Change has been successfully rebased and submitted as cd050400db8decdc08061b7450e50dc72abb58fb\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"cd050400db8decdc08061b7450e50dc72abb58fb","revisions":{"bd3b175e81351d776560f835427f2fc09f3f84ca":{"kind":"REWORK","_number":1,"created":"2024-10-02 14:05:39.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/64/12564/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/12564/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/12564/1"}}},"commit":{"parents":[{"commit":"f0d5ed7074097ca44a86865ef82cdbd1d1bddff7","subject":"docs(tvix/TODO): add PathInfo data types and ca reference items","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df0d5ed7074097ca44a86865ef82cdbd1d1bddff7"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-10-02 14:04:15.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-10-02 14:04:15.000000000","tz":180},"subject":"feat(tazjin/niri-reap): improve reaping of workspaces above","message":"feat(tazjin/niri-reap): improve reaping of workspaces above\n\nPreviously the script ignored workspaces that were further up, but in practice I\ndon\u0027t care about their order, I just want them to be gone.\n\nTo keep IDs stable, this implements a fix where the current workspace is first\nmoved to the first position (invisible), and windows are then reaped afterwards.\n\nI\u0027ve tried this in various combinations and it seems to work fine.\n\nChange-Id: Ifc3eb272af761670ec83305665ec2103eb4f269e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd3b175e81351d776560f835427f2fc09f3f84ca"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd3b175e81351d776560f835427f2fc09f3f84ca"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f0d5ed7074097ca44a86865ef82cdbd1d1bddff7","is_merged_in_target_branch":true,"change_id":"I26f9215312c258bba222efd390bc135f1a3a3d6d","change_number":12560,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5d3f9c8738a9a6bf412c34a527808d8e515114ce":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-10-02 14:29:17.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/64/12564/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/12564/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/12564/2"}}},"commit":{"parents":[{"commit":"3606d7acc3300ec29d25e1c14c9450cf288195dd","subject":"test(tvix/castore/refscan): add empty pattern regression test","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3606d7acc3300ec29d25e1c14c9450cf288195dd"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-10-02 14:04:15.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-10-02 14:28:15.000000000","tz":180},"subject":"feat(tazjin/niri-reap): improve reaping of workspaces above","message":"feat(tazjin/niri-reap): improve reaping of workspaces above\n\nPreviously the script ignored workspaces that were further up, but in practice I\ndon\u0027t care about their order, I just want them to be gone.\n\nTo keep IDs stable, this implements a fix where the current workspace is first\nmoved to the first position (invisible), and windows are then reaped afterwards.\n\nI\u0027ve tried this in various combinations and it seems to work fine.\n\nChange-Id: Ifc3eb272af761670ec83305665ec2103eb4f269e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d3f9c8738a9a6bf412c34a527808d8e515114ce"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d3f9c8738a9a6bf412c34a527808d8e515114ce"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3606d7acc3300ec29d25e1c14c9450cf288195dd","is_merged_in_target_branch":true,"change_id":"I165261170edaabfc56f6ac0a6baae388332b3f73","change_number":12559,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"cd050400db8decdc08061b7450e50dc72abb58fb":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-10-02 14:35:48.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/64/12564/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/12564/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/12564/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/12564/3"}}},"commit":{"parents":[{"commit":"3606d7acc3300ec29d25e1c14c9450cf288195dd","subject":"test(tvix/castore/refscan): add empty pattern regression test","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3606d7acc3300ec29d25e1c14c9450cf288195dd"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-10-02 14:04:15.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-10-02 14:35:48.000000000","tz":0},"subject":"feat(tazjin/niri-reap): improve reaping of workspaces above","message":"feat(tazjin/niri-reap): improve reaping of workspaces above\n\nPreviously the script ignored workspaces that were further up, but in practice I\ndon\u0027t care about their order, I just want them to be gone.\n\nTo keep IDs stable, this implements a fix where the current workspace is first\nmoved to the first position (invisible), and windows are then reaped afterwards.\n\nI\u0027ve tried this in various combinations and it seems to work fine.\n\nChange-Id: Ifc3eb272af761670ec83305665ec2103eb4f269e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/12564\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nAutosubmit: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcd050400db8decdc08061b7450e50dc72abb58fb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcd050400db8decdc08061b7450e50dc72abb58fb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3606d7acc3300ec29d25e1c14c9450cf288195dd","is_merged_in_target_branch":true,"change_id":"I165261170edaabfc56f6ac0a6baae388332b3f73","change_number":12559,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}