)]}'
{"id":"depot~1273","triplet_id":"depot~canon~I0047c98e2096010797316bff3ea4faf722fab86a","project":"depot","branch":"canon","topic":"tvix","hashtags":[],"change_id":"I0047c98e2096010797316bff3ea4faf722fab86a","subject":"fix(3p/nix): nix-build: don\u0027t accept --(im)pure","status":"MERGED","created":"2020-07-18 21:32:40.000000000","updated":"2020-08-29 13:59:50.000000000","submitted":"2020-07-18 21:40:36.000000000","submitter":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1273","meta_rev_id":"0a5fa420ad0942b2527218db2790057ba5f28cab","_number":1273,"virtual_id_number":1273,"owner":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-18 21:40:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-18 21:40:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-18 21:34:21.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-18 21:35:00.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"501cb66f5dc2b35ebdc1579d75937a0d0123eb8f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2020-07-18 21:32:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f86a1c006b5de484d4a4e998c739f0a6c5ba57c7","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-18 21:34:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/1308","accounts_in_message":[],"_revision_number":1},{"id":"1d2baaa04ba854041d063b0291b28b5f5cd8f3f8","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-18 21:35:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c1c9d478a1775fa04c46df91ec63823d04172f6a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2020-07-18 21:40:36.000000000","message":"Change has been successfully rebased and submitted as 7010d4dc8641b350d33cf2634638b7cba6c93ae2 by Alyssa Ross","accounts_in_message":[],"_revision_number":2},{"id":"7bd183546b80bd013444a0f1bc2a8b72da39b80a","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-18 21:42:26.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/1309","accounts_in_message":[],"_revision_number":2},{"id":"0a5fa420ad0942b2527218db2790057ba5f28cab","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-29 13:59:50.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7010d4dc8641b350d33cf2634638b7cba6c93ae2","revisions":{"f960b157a999108b0adae8821bb4cd6548fd9393":{"kind":"REWORK","_number":1,"created":"2020-07-18 21:32:40.000000000","uploader":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"ref":"refs/changes/73/1273/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/73/1273/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/73/1273/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/73/1273/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/73/1273/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/73/1273/1"}}},"commit":{"parents":[{"commit":"cbea59c5f65e616d5fe2a76c4577f7e806936272","subject":"chore(3p/nix): don\u0027t rebuild nix-proto-srcs as much","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcbea59c5f65e616d5fe2a76c4577f7e806936272"}]}],"author":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-18 21:30:28.000000000","tz":0},"committer":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-18 21:30:28.000000000","tz":0},"subject":"fix(3p/nix): nix-build: don\u0027t accept --(im)pure","message":"fix(3p/nix): nix-build: don\u0027t accept --(im)pure\n\nThese options only apply to nix-shell.  The fact that nix-build\npreviously accepted them was an accident that resulted from the two\nprograms sharing an implementation.\n\nChange-Id: I0047c98e2096010797316bff3ea4faf722fab86a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df960b157a999108b0adae8821bb4cd6548fd9393"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df960b157a999108b0adae8821bb4cd6548fd9393"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cbea59c5f65e616d5fe2a76c4577f7e806936272","is_merged_in_target_branch":true,"change_id":"I8dd750f6bc5902b74ffb56470bc8a5f2c01c8cf1","change_number":1263,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7010d4dc8641b350d33cf2634638b7cba6c93ae2":{"kind":"REWORK","_number":2,"created":"2020-07-18 21:40:36.000000000","uploader":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"ref":"refs/changes/73/1273/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/73/1273/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/73/1273/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/73/1273/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/73/1273/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/73/1273/2"}}},"commit":{"parents":[{"commit":"3c9ee249299955c415f536a81ea7b4c218b3a36b","subject":"chore(whitby): add riking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c9ee249299955c415f536a81ea7b4c218b3a36b"}]}],"author":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-18 21:30:28.000000000","tz":0},"committer":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-18 21:40:36.000000000","tz":0},"subject":"fix(3p/nix): nix-build: don\u0027t accept --(im)pure","message":"fix(3p/nix): nix-build: don\u0027t accept --(im)pure\n\nThese options only apply to nix-shell.  The fact that nix-build\npreviously accepted them was an accident that resulted from the two\nprograms sharing an implementation.\n\nChange-Id: I0047c98e2096010797316bff3ea4faf722fab86a\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1273\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7010d4dc8641b350d33cf2634638b7cba6c93ae2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7010d4dc8641b350d33cf2634638b7cba6c93ae2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3c9ee249299955c415f536a81ea7b4c218b3a36b","is_merged_in_target_branch":true,"change_id":"I33cc1324eac9a13be56d296d09cfdbe066d90e13","change_number":1256,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}
