)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"59b22df817508ced541dc4ff4a3c4f474de611e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0353e7f_c645936e","updated":"2025-01-07 19:59:39.000000000","message":"Disclaimer: Haven\u0027t used Go in 8 years or so…","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"2b2676907c119970b1a88d001ce19d2d6d26e1dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d732142_0c9d8322","in_reply_to":"f0353e7f_c645936e","updated":"2025-01-08 20:44:52.000000000","message":"Acknowledged","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"}],"ops/builderball/discovery/caches.go":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"59b22df817508ced541dc4ff4a3c4f474de611e1","unresolved":true,"context_lines":[{"line_number":52,"context_line":"\tfound :\u003d make([]string, len(config.Caches))"},{"line_number":53,"context_line":"\tcopy(found, config.Caches)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"\tif !*config.Tailscale {"},{"line_number":56,"context_line":"\t\tc.setWhileHoldingLock(found)"},{"line_number":57,"context_line":"\t\treturn found, nil"},{"line_number":58,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"0b996ffc_04814875","line":55,"updated":"2025-01-07 19:59:39.000000000","message":"Couldn\u0027t you instead wrap the entire block below in an `if *config.Tailscale { … }`? You could then use just one `setWhileHoldingLock(found)` (the one at the end of the function) or not even need to move the functionality into a separate function.","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"2b2676907c119970b1a88d001ce19d2d6d26e1dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\tfound :\u003d make([]string, len(config.Caches))"},{"line_number":53,"context_line":"\tcopy(found, config.Caches)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"\tif !*config.Tailscale {"},{"line_number":56,"context_line":"\t\tc.setWhileHoldingLock(found)"},{"line_number":57,"context_line":"\t\treturn found, nil"},{"line_number":58,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"4f335323_20a9cfac","line":55,"in_reply_to":"0b996ffc_04814875","updated":"2025-01-08 20:44:52.000000000","message":"Yep, thanks for the fresh eyes perspective)","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"},{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"59b22df817508ced541dc4ff4a3c4f474de611e1","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\tfor _, peer :\u003d range status.Peer {"},{"line_number":68,"context_line":"\t\tif peer.Online \u0026\u0026 peer.Tags !\u003d nil \u0026\u0026 status.Self !\u003d peer \u0026\u0026 len(peer.TailscaleIPs) \u003e 0 {"},{"line_number":69,"context_line":"\t\t\tfor _, tag :\u003d range peer.Tags.All() {"},{"line_number":70,"context_line":"\t\t\t\tif tag \u003d\u003d *config.TSTag {"},{"line_number":71,"context_line":"\t\t\t\t\tfound \u003d append(found, fmt.Sprintf(\"http://%s:%d\", peer.TailscaleIPs[0].String(), *config.CachePort))"},{"line_number":72,"context_line":"\t\t\t\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"7cfcfe78_d31eae1f","line":69,"updated":"2025-01-07 19:59:39.000000000","message":"Should the debug log also inform about peer discovery in this loop to some extent?","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"2b2676907c119970b1a88d001ce19d2d6d26e1dc","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"\tfor _, peer :\u003d range status.Peer {"},{"line_number":68,"context_line":"\t\tif peer.Online \u0026\u0026 peer.Tags !\u003d nil \u0026\u0026 status.Self !\u003d peer \u0026\u0026 len(peer.TailscaleIPs) \u003e 0 {"},{"line_number":69,"context_line":"\t\t\tfor _, tag :\u003d range peer.Tags.All() {"},{"line_number":70,"context_line":"\t\t\t\tif tag \u003d\u003d *config.TSTag {"},{"line_number":71,"context_line":"\t\t\t\t\tfound \u003d append(found, fmt.Sprintf(\"http://%s:%d\", peer.TailscaleIPs[0].String(), *config.CachePort))"},{"line_number":72,"context_line":"\t\t\t\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"97a6c769_0069ee93","line":69,"in_reply_to":"7cfcfe78_d31eae1f","updated":"2025-01-08 20:44:52.000000000","message":"Done","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"}],"ops/builderball/main.go":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"59b22df817508ced541dc4ff4a3c4f474de611e1","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"\tif *config.Debug {"},{"line_number":44,"context_line":"\t\tslog.SetLogLoggerLevel(slog.LevelDebug)"},{"line_number":45,"context_line":"\t\tslog.Debug(\"enabled debug logging\")"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\tif len(config.Caches) \u003e 0 {"}],"source_content_type":"text/x-go","patch_set":2,"id":"1958db5c_62569e73","line":45,"updated":"2025-01-07 19:59:39.000000000","message":"Redundant with lines :31 and :41, respectively?","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"2b2676907c119970b1a88d001ce19d2d6d26e1dc","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"\tif *config.Debug {"},{"line_number":44,"context_line":"\t\tslog.SetLogLoggerLevel(slog.LevelDebug)"},{"line_number":45,"context_line":"\t\tslog.Debug(\"enabled debug logging\")"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\tif len(config.Caches) \u003e 0 {"}],"source_content_type":"text/x-go","patch_set":2,"id":"e9fd574b_3d62edf0","line":45,"in_reply_to":"1958db5c_62569e73","updated":"2025-01-08 20:44:52.000000000","message":"Done","commit_id":"7a103aec67cd8a38139ee8cb706488c3375185d2"}]}