)]}'
{"id":"depot~13162","triplet_id":"depot~canon~Iee349557ef4761807af1fb3942387de1942ab12b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2025-02-19 16:37:38.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2025-02-19 15:25:47.000000000","reason":"removed on reply"},"1000140":{"account":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"last_update":"2025-02-19 16:37:38.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iee349557ef4761807af1fb3942387de1942ab12b","subject":"refactor(tvix/castore): use \"blake3\" for Display impl","status":"MERGED","created":"2025-02-19 14:17:57.000000000","updated":"2025-02-19 16:37:38.000000000","submitted":"2025-02-19 16:37:38.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"13162","meta_rev_id":"66e7135e1fc49d5654e36eda99b4223e9413bb79","_number":13162,"virtual_id_number":13162,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-02-19 16:37:38.000000000","_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-19 16:37:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-02-19 16:37:38.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-19 14:17:57.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"state":"REVIEWER"},{"updated":"2025-02-19 14:17:57.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2025-02-19 14:17:59.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-02-19 16:30:10.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-19 16:37:38.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"47f8a15a2f37029156afee71896c12a3519c363c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-02-19 14:17:57.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"872d6ffdf9bb5c2aa3aecc7ae52c49cf5f823cd9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-02-19 14:17:59.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/38712","accounts_in_message":[],"_revision_number":1},{"id":"1e5e2fbfe4de6d5e49abd5adf6e39897dda7e705","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2025-02-19 15:25:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6f17af95a77216a0ef1d3f3e9567c2881b2e1e85","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-02-19 16:30:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/38712","accounts_in_message":[],"_revision_number":1},{"id":"5c23c2bd5af4cfc88b480afcbb716422ff63277d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-02-19 16:37:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/38715","accounts_in_message":[],"_revision_number":1},{"id":"66e7135e1fc49d5654e36eda99b4223e9413bb79","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2025-02-19 16:37:38.000000000","message":"Change has been successfully rebased and submitted as 3491a7e679d16608f6b80aad2f9180ea87576020","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3491a7e679d16608f6b80aad2f9180ea87576020","revisions":{"5432eedf981f9bd90a18465e0d65cbccc209ec2f":{"kind":"REWORK","_number":1,"created":"2025-02-19 14:17:57.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/62/13162/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/62/13162/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/62/13162/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/62/13162/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/62/13162/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/62/13162/1"}}},"commit":{"parents":[{"commit":"c224c7a75019ccba11b358dc90d3da20a414cf6a","subject":"refactor(nix-compat/nixhash): use SRI hashes for Display","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc224c7a75019ccba11b358dc90d3da20a414cf6a"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-02-19 14:13:54.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-02-19 14:17:20.000000000","tz":60},"subject":"refactor(tvix/castore): use \"blake3\" for Display impl","message":"refactor(tvix/castore): use \"blake3\" for Display impl\n\nmake the Display impl of B3Digest use the `blake3-` prefix rather than\n`b3:`, which is more close to the SRI hashes we use in NixHash.\n\nAlso use Span::current().record() to record the `blob.digest` field (and\nonly when the digest has the right lenght). It doesn\u0027t make sense to\nbrand it as blake3 before anyways, and allows us to get rid of the\nmanual implementation.\n\nChange-Id: Iee349557ef4761807af1fb3942387de1942ab12b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5432eedf981f9bd90a18465e0d65cbccc209ec2f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5432eedf981f9bd90a18465e0d65cbccc209ec2f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c224c7a75019ccba11b358dc90d3da20a414cf6a","is_merged_in_target_branch":false,"change_id":"I3a8f18607c305dbf9fb93a2e2dd02ad07cd99f24","change_number":13161,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3491a7e679d16608f6b80aad2f9180ea87576020":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-02-19 16:37:38.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/62/13162/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/62/13162/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/62/13162/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/62/13162/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/62/13162/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/62/13162/2"}}},"commit":{"parents":[{"commit":"51ea9c78016a2d1884a77626b9a189784aa1bba5","subject":"refactor(nix-compat/nixhash): use SRI hashes for Display","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d51ea9c78016a2d1884a77626b9a189784aa1bba5"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-02-19 14:13:54.000000000","tz":60},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2025-02-19 16:37:38.000000000","tz":0},"subject":"refactor(tvix/castore): use \"blake3\" for Display impl","message":"refactor(tvix/castore): use \"blake3\" for Display impl\n\nmake the Display impl of B3Digest use the `blake3-` prefix rather than\n`b3:`, which is more close to the SRI hashes we use in NixHash.\n\nAlso use Span::current().record() to record the `blob.digest` field (and\nonly when the digest has the right lenght). It doesn\u0027t make sense to\nbrand it as blake3 before anyways, and allows us to get rid of the\nmanual implementation.\n\nChange-Id: Iee349557ef4761807af1fb3942387de1942ab12b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/13162\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: Ilan Joselevich \u003cpersonal@ilanjoselevich.com\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3491a7e679d16608f6b80aad2f9180ea87576020"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3491a7e679d16608f6b80aad2f9180ea87576020"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"51ea9c78016a2d1884a77626b9a189784aa1bba5","is_merged_in_target_branch":true,"change_id":"I3a8f18607c305dbf9fb93a2e2dd02ad07cd99f24","change_number":13161,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
