)]}'
{"id":"depot~13238","triplet_id":"depot~canon~I7aa6d99dc26e24eb22ef56ffd4d2db5c6978ad48","project":"depot","branch":"canon","hashtags":[],"change_id":"I7aa6d99dc26e24eb22ef56ffd4d2db5c6978ad48","subject":"feat(users/Profpatsch/whatcd-resolver): add simple favourites","status":"MERGED","created":"2025-03-10 12:48:39.000000000","updated":"2025-03-10 16:55:15.000000000","submitted":"2025-03-10 16:55:15.000000000","submitter":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"13240","meta_rev_id":"b3547baa51fedc79cdf0a2ea339e41c525323ff3","_number":13238,"virtual_id_number":13238,"owner":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-10 16:55:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-10 16:55:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-10 12:48:41.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-03-10 12:52:35.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a99509e579911a2e8922f3ada4873cb79547ed23","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2025-03-10 12:48:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4630b794cc07582a1e79c33352cc427f7f67936f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-10 12:48:41.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/38934","accounts_in_message":[],"_revision_number":1},{"id":"31d131e346c24e1088b911a4e32c16d9b42f9c4a","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-10 12:52:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/38934","accounts_in_message":[],"_revision_number":1},{"id":"e3f621badc5023608040814428a99146ed3dae1e","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2025-03-10 16:52:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b3547baa51fedc79cdf0a2ea339e41c525323ff3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2025-03-10 16:55:15.000000000","message":"Change has been successfully rebased and submitted as bc09c01dfdb1f33c5884f1c9858bc7f8a9a3fc6b","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc09c01dfdb1f33c5884f1c9858bc7f8a9a3fc6b","revisions":{"4f728399364ca7ef8145f64cde630dc86860daf4":{"kind":"REWORK","_number":1,"created":"2025-03-10 12:48:39.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/38/13238/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/38/13238/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/38/13238/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/38/13238/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/38/13238/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/38/13238/1"}}},"commit":{"parents":[{"commit":"106522962d4d9ae814e3feac153305de5541feda","subject":"refactor(users/Profpatsch/whatcd-resolver): prepare SQL changes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d106522962d4d9ae814e3feac153305de5541feda"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2025-03-10 12:45:42.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2025-03-10 12:48:30.000000000","tz":60},"subject":"feat(users/Profpatsch/whatcd-resolver): add simple favourites","message":"feat(users/Profpatsch/whatcd-resolver): add simple favourites\n\nA simple favourite system that adds an artist to your favourites when\nyou go to their artist page for the first time.\n\nAlso, if you fetch something from an artist, they get automatically\nadded to the favourites.\n\nThis is pretty much just done by adding more crap to the main SQL\nquery, and has the disadvantage that the `artist_has_been_snatched`\nCTE slows down the query a lot for the favourite filter (by 50% or\neven sometimes 150% in a weird degenerate case). I think we can\noptimize this somewhat, but that needs a small rewrite of the query\nCTE stages.\n\nChange-Id: I7aa6d99dc26e24eb22ef56ffd4d2db5c6978ad48\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4f728399364ca7ef8145f64cde630dc86860daf4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4f728399364ca7ef8145f64cde630dc86860daf4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"106522962d4d9ae814e3feac153305de5541feda","is_merged_in_target_branch":false,"change_id":"Ibd5b67c77c87ce3d6aa0ab04ca3d66f9b90dc856","change_number":13237,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"bc09c01dfdb1f33c5884f1c9858bc7f8a9a3fc6b":{"kind":"REWORK","_number":2,"created":"2025-03-10 16:55:15.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/38/13238/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/38/13238/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/38/13238/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/38/13238/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/38/13238/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/38/13238/2"}}},"commit":{"parents":[{"commit":"1e188ee116632fdf34c231d45b94cb8e9f8c8875","subject":"refactor(users/Profpatsch/whatcd-resolver): prepare SQL changes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e188ee116632fdf34c231d45b94cb8e9f8c8875"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2025-03-10 12:45:42.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2025-03-10 16:55:15.000000000","tz":0},"subject":"feat(users/Profpatsch/whatcd-resolver): add simple favourites","message":"feat(users/Profpatsch/whatcd-resolver): add simple favourites\n\nA simple favourite system that adds an artist to your favourites when\nyou go to their artist page for the first time.\n\nAlso, if you fetch something from an artist, they get automatically\nadded to the favourites.\n\nThis is pretty much just done by adding more crap to the main SQL\nquery, and has the disadvantage that the `artist_has_been_snatched`\nCTE slows down the query a lot for the favourite filter (by 50% or\neven sometimes 150% in a weird degenerate case). I think we can\noptimize this somewhat, but that needs a small rewrite of the query\nCTE stages.\n\nChange-Id: I7aa6d99dc26e24eb22ef56ffd4d2db5c6978ad48\nReviewed-on: https://cl.tvl.fyi/c/depot/+/13238\nReviewed-by: Profpatsch \u003cmail@profpatsch.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbc09c01dfdb1f33c5884f1c9858bc7f8a9a3fc6b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbc09c01dfdb1f33c5884f1c9858bc7f8a9a3fc6b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1e188ee116632fdf34c231d45b94cb8e9f8c8875","is_merged_in_target_branch":true,"change_id":"Ibd5b67c77c87ce3d6aa0ab04ca3d66f9b90dc856","change_number":13237,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}