)]}'
{"id":"depot~13252","triplet_id":"depot~canon~I5457949136e19204b32c8182b6c89e66cc2183e2","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2025-03-13 11:37:57.000000000","reason":"Change was submitted"},"1000139":{"account":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"last_update":"2025-03-13 11:31:24.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2025-03-13 11:37:57.000000000","reason":"Change was submitted"},"1000140":{"account":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"last_update":"2025-03-13 09:41:33.000000000","reason":"\u003cGERRIT_ACCOUNT_1000140\u003e replied on the change","reason_account":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}}},"hashtags":[],"change_id":"I5457949136e19204b32c8182b6c89e66cc2183e2","subject":"docs(tvix/glue/builtins): drop TODO","status":"MERGED","created":"2025-03-13 09:15:47.000000000","updated":"2025-03-13 11:37:57.000000000","submitted":"2025-03-13 11:37:57.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"13253","meta_rev_id":"c95de2a9823749a5f27705cfdd7ed03a08b7c50d","_number":13252,"virtual_id_number":13252,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-13 11:37:57.000000000","_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-13 11:37:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-13 11:37:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-13 11:37:57.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}]}},"removable_reviewers":[{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-13 09:15:47.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"state":"REVIEWER"},{"updated":"2025-03-13 09:15:47.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"state":"REVIEWER"},{"updated":"2025-03-13 09:15:53.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-03-13 09:27:59.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2025-03-13 10:12:59.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-03-13 11:37:57.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3bece6d17375f2b88f917723e01ef56320914e19","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 09:15:47.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"a6f31bbff27d4c7267293094ed8ff22a109dfa04","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 09:15:53.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/38965","accounts_in_message":[],"_revision_number":1},{"id":"a3b844da09ab64f6fb96b044895c24054e751006","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 09:26:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f0511a7e687f44d0a2e2d57f5eb49f852b2a292e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 09:27:01.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/38972","accounts_in_message":[],"_revision_number":2},{"id":"3377fc829cff4a9bf48a0c6ac5ba7b07e16ca50a","author":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"date":"2025-03-13 09:41:33.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"4f8969e15b184fe3d69cc33f85ca745a9618f2f0","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 10:12:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/38972","accounts_in_message":[],"_revision_number":2},{"id":"009c1add1e78ab3e58d8b2fcf33ebc0f3c35a663","author":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"date":"2025-03-13 11:31:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2383f14af942e59a961d88a9b9f09710c3503fb1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 11:34:54.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n* Code-Review+1, Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR **changekind:NO_CHANGE**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c95de2a9823749a5f27705cfdd7ed03a08b7c50d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2025-03-13 11:37:57.000000000","message":"Change has been successfully rebased and submitted as f9ceebe03128c7b3636d39e7f7f7a9f47dc37fd6\n\n2 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f9ceebe03128c7b3636d39e7f7f7a9f47dc37fd6","revisions":{"9aac04ed0d28cf0db803d7d57e64b452cebf5301":{"kind":"REWORK","_number":1,"created":"2025-03-13 09:15:47.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/52/13252/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/13252/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/13252/1"}}},"commit":{"parents":[{"commit":"3fb5eb1dda20c036b49f5739a2f2071c7a874ec7","subject":"docs(tvix/store): fix docstrings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3fb5eb1dda20c036b49f5739a2f2071c7a874ec7"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 06:40:36.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 09:14:43.000000000","tz":60},"subject":"docs(tvix/glue/builtins): drop TODO","message":"docs(tvix/glue/builtins): drop TODO\n\nbuiltins.filterSource and builtins.path itself are very short these\ndays, and use the same underlying (private) helper function.\n\nDescribing builtins.filterSource with builtins.path won\u0027t lead to less\ncode, so this TODO can be dropped.\n\nChange-Id: I5457949136e19204b32c8182b6c89e66cc2183e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9aac04ed0d28cf0db803d7d57e64b452cebf5301"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9aac04ed0d28cf0db803d7d57e64b452cebf5301"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3fb5eb1dda20c036b49f5739a2f2071c7a874ec7","is_merged_in_target_branch":false,"change_id":"I8fd2d6db3ac260bf7265fe15cb5bc010b8911dbf","change_number":13251,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7d8841d9cef35579a2e92974b9002135e55a0a5a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-03-13 09:26:56.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/52/13252/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/13252/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/13252/2"}}},"commit":{"parents":[{"commit":"00dafef3488a777d74fd3e3edea66fa72b608a89","subject":"docs(tvix/store): fix docstrings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d00dafef3488a777d74fd3e3edea66fa72b608a89"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 06:40:36.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 09:22:51.000000000","tz":60},"subject":"docs(tvix/glue/builtins): drop TODO","message":"docs(tvix/glue/builtins): drop TODO\n\nbuiltins.filterSource and builtins.path itself are very short these\ndays, and use the same underlying (private) helper function.\n\nDescribing builtins.filterSource with builtins.path won\u0027t lead to less\ncode, so this TODO can be dropped.\n\nChange-Id: I5457949136e19204b32c8182b6c89e66cc2183e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7d8841d9cef35579a2e92974b9002135e55a0a5a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7d8841d9cef35579a2e92974b9002135e55a0a5a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"00dafef3488a777d74fd3e3edea66fa72b608a89","is_merged_in_target_branch":false,"change_id":"I8fd2d6db3ac260bf7265fe15cb5bc010b8911dbf","change_number":13251,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"efd9d368d4d1483aa635a85a0e19926e277d27ba":{"kind":"NO_CHANGE","_number":3,"created":"2025-03-13 11:34:54.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/52/13252/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/13252/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/13252/3"}}},"commit":{"parents":[{"commit":"cccd24acf59b11e33f07867c13415d87a5ea650b","subject":"docs(tvix/store): fix docstrings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcccd24acf59b11e33f07867c13415d87a5ea650b"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 06:40:36.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 11:34:39.000000000","tz":60},"subject":"docs(tvix/glue/builtins): drop TODO","message":"docs(tvix/glue/builtins): drop TODO\n\nbuiltins.filterSource and builtins.path itself are very short these\ndays, and use the same underlying (private) helper function.\n\nDescribing builtins.filterSource with builtins.path won\u0027t lead to less\ncode, so this TODO can be dropped.\n\nChange-Id: I5457949136e19204b32c8182b6c89e66cc2183e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003defd9d368d4d1483aa635a85a0e19926e277d27ba"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003defd9d368d4d1483aa635a85a0e19926e277d27ba"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cccd24acf59b11e33f07867c13415d87a5ea650b","is_merged_in_target_branch":false,"change_id":"I8fd2d6db3ac260bf7265fe15cb5bc010b8911dbf","change_number":13251,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f9ceebe03128c7b3636d39e7f7f7a9f47dc37fd6":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-03-13 11:37:57.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/52/13252/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/13252/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/13252/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/13252/4"}}},"commit":{"parents":[{"commit":"7fa53d22295763141b450903361200aa04ce662c","subject":"docs(tvix/store): fix docstrings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7fa53d22295763141b450903361200aa04ce662c"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 06:40:36.000000000","tz":60},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2025-03-13 11:37:57.000000000","tz":0},"subject":"docs(tvix/glue/builtins): drop TODO","message":"docs(tvix/glue/builtins): drop TODO\n\nbuiltins.filterSource and builtins.path itself are very short these\ndays, and use the same underlying (private) helper function.\n\nDescribing builtins.filterSource with builtins.path won\u0027t lead to less\ncode, so this TODO can be dropped.\n\nChange-Id: I5457949136e19204b32c8182b6c89e66cc2183e2\nReviewed-on: https://cl.tvl.fyi/c/depot/+/13252\nReviewed-by: Domen Kožar \u003cdomen@cachix.org\u003e\nTested-by: BuildkiteCI\nReviewed-by: Marijan Petričević \u003cmarijan.petricevic94@gmail.com\u003e\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df9ceebe03128c7b3636d39e7f7f7a9f47dc37fd6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df9ceebe03128c7b3636d39e7f7f7a9f47dc37fd6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7fa53d22295763141b450903361200aa04ce662c","is_merged_in_target_branch":true,"change_id":"I8fd2d6db3ac260bf7265fe15cb5bc010b8911dbf","change_number":13251,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}