)]}'
{"id":"depot~13254","triplet_id":"depot~canon~Iec3c422c12270ee111f864d2b78c0861f78edfa4","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2025-03-13 12:08:04.000000000","reason":"Change was submitted"},"1000139":{"account":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"last_update":"2025-03-13 11:32:49.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2025-03-13 12:05:44.000000000","reason":"\u003cGERRIT_ACCOUNT_1000073\u003e replied on the change","reason_account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}},"1000140":{"account":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"last_update":"2025-03-13 12:08:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iec3c422c12270ee111f864d2b78c0861f78edfa4","subject":"refactor(tvix/glue): move toFile to import builtins","status":"MERGED","created":"2025-03-13 09:15:47.000000000","updated":"2025-03-13 12:08:04.000000000","submitted":"2025-03-13 12:08:04.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"13254","meta_rev_id":"55c90e29bda22bf61c717a86caed0103a83f9290","_number":13254,"virtual_id_number":13254,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-13 12:08:04.000000000","_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-13 12:08:04.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-13 12:08:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"tag":"autogenerated:gerrit:merged","value":0,"date":"2025-03-13 12:08:04.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-13 09:15:47.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"state":"REVIEWER"},{"updated":"2025-03-13 09:15:47.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000140,"name":"Marijan Petričević","display_name":"marijan","email":"marijan.petricevic94@gmail.com","username":"marijanp"},"state":"REVIEWER"},{"updated":"2025-03-13 09:15:54.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-03-13 09:27:50.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2025-03-13 10:13:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"863c32113167b32509badc8aad68be5dafa7ade3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 09:15:47.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"12d37b6a30606be6675965841c3f9d5e64128eb1","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 09:15:54.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/38967","accounts_in_message":[],"_revision_number":1},{"id":"39b8d8b28ebd155d6890e8eb019b6d2a751eb7a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 09:26:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"81338484fea74da6cfc6ec9f945b533480057b98","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 09:27:04.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/38974","accounts_in_message":[],"_revision_number":2},{"id":"471ccce37d617ef852fe610e300e03c54f5afc44","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 10:13:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/38974","accounts_in_message":[],"_revision_number":2},{"id":"e91ef824e444abeef9f671d61a9fc720f18ac54b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 10:48:36.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"755d81b2ed9e842e5d35cec5b577f5af92da1120","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 10:48:38.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/38977","accounts_in_message":[],"_revision_number":3},{"id":"f822b55d6711098e53a9efa73a2deaa017a7eb63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 10:51:01.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"3d1036af620dbe0110455b624083ff23fa541960","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 10:51:03.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/38980","accounts_in_message":[],"_revision_number":4},{"id":"593beeee69a6a834fce4c86d10f947ba7a7b780a","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 10:58:17.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/38980","accounts_in_message":[],"_revision_number":4},{"id":"fe0f55ca43ae70f86d92698ac45de67de123b89d","author":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"},"date":"2025-03-13 11:32:49.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"56b7f2e16b0aa5378452b99445e92fe7328b8c71","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 11:34:54.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"3bf06834824241973cab31035ee8486862dd4c5c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 11:34:55.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/38986","accounts_in_message":[],"_revision_number":5},{"id":"b6abfd3962bb3ae7d9ac4bb967679023d28c2293","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 11:37:35.000000000","message":"Patch Set 5: -Autosubmit","accounts_in_message":[],"_revision_number":5},{"id":"d42022539d5144565b5eb9a3614d2a81314a25e4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2025-03-13 11:45:28.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/38986","accounts_in_message":[],"_revision_number":5},{"id":"6fb8f864bf172b48e0bece2d99661cd694df2aa4","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2025-03-13 12:05:44.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"55c90e29bda22bf61c717a86caed0103a83f9290","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-13 12:08:04.000000000","message":"Change has been successfully rebased and submitted as 4535824166c9e42304f19c34d56d2281b2b886ab","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"4535824166c9e42304f19c34d56d2281b2b886ab","revisions":{"7cc565bce277349d9fc01890515d4d415cea8957":{"kind":"REWORK","_number":1,"created":"2025-03-13 09:15:47.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/54/13254/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/13254/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/13254/1"}}},"commit":{"parents":[{"commit":"c5aa94daa176ebff1be89ed168ec972c4b052974","subject":"docs(tvix/glue): add_*_builtins: fix docstring","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5aa94daa176ebff1be89ed168ec972c4b052974"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 08:30:44.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 09:14:43.000000000","tz":60},"subject":"refactor(tvix/glue): move toFile to import builtins","message":"refactor(tvix/glue): move toFile to import builtins\n\nThis does import the contents into the store, so it should belong in there.\n\nWhile moving, I also noticed the code copying to the BlobService can be\nshared with the one used when importing a blob via import helper.\nIt was a bit hidden - due to the contents being available as a bytes, we\nused a Cursor and wrote it with tokio::io::copy.\n\nHowever, Cursor implements both AsyncRead and Read, so we can factor out\nthe copying code into a copy_to_blobservice helper function and use it\nin both places.\n\nThe output name being wrong error kind arguably is still a bit misplaced\nhere, but that\u0027s left for later.\n\nChange-Id: Iec3c422c12270ee111f864d2b78c0861f78edfa4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7cc565bce277349d9fc01890515d4d415cea8957"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7cc565bce277349d9fc01890515d4d415cea8957"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c5aa94daa176ebff1be89ed168ec972c4b052974","is_merged_in_target_branch":false,"change_id":"Ibf76b496874158fb85b21e52e7c3561e66cffaba","change_number":13253,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"22777e7e8d68e90953c8198197c0a90cbb78da10":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-03-13 09:26:56.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/54/13254/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/13254/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/13254/2"}}},"commit":{"parents":[{"commit":"399db23f1ab7f7f884812332ba155dc9c8454cf3","subject":"docs(tvix/glue): add_*_builtins: fix docstring","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d399db23f1ab7f7f884812332ba155dc9c8454cf3"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 08:30:44.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 09:22:51.000000000","tz":60},"subject":"refactor(tvix/glue): move toFile to import builtins","message":"refactor(tvix/glue): move toFile to import builtins\n\nThis does import the contents into the store, so it should belong in there.\n\nWhile moving, I also noticed the code copying to the BlobService can be\nshared with the one used when importing a blob via import helper.\nIt was a bit hidden - due to the contents being available as a bytes, we\nused a Cursor and wrote it with tokio::io::copy.\n\nHowever, Cursor implements both AsyncRead and Read, so we can factor out\nthe copying code into a copy_to_blobservice helper function and use it\nin both places.\n\nThe output name being wrong error kind arguably is still a bit misplaced\nhere, but that\u0027s left for later.\n\nChange-Id: Iec3c422c12270ee111f864d2b78c0861f78edfa4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d22777e7e8d68e90953c8198197c0a90cbb78da10"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d22777e7e8d68e90953c8198197c0a90cbb78da10"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"399db23f1ab7f7f884812332ba155dc9c8454cf3","is_merged_in_target_branch":false,"change_id":"Ibf76b496874158fb85b21e52e7c3561e66cffaba","change_number":13253,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5ca7220a4d6eccb817a3f630b461f9df8e45cc42":{"kind":"REWORK","_number":3,"created":"2025-03-13 10:48:36.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/54/13254/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/13254/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/13254/3"}}},"commit":{"parents":[{"commit":"399db23f1ab7f7f884812332ba155dc9c8454cf3","subject":"docs(tvix/glue): add_*_builtins: fix docstring","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d399db23f1ab7f7f884812332ba155dc9c8454cf3"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 08:30:44.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 10:48:21.000000000","tz":60},"subject":"refactor(tvix/glue): move toFile to import builtins","message":"refactor(tvix/glue): move toFile to import builtins\n\nThis does import the contents into the store, so it should belong in there.\n\nWhile moving, I also noticed the code copying to the BlobService can be\nshared with the one used when importing a blob via import helper.\nIt was a bit hidden - due to the contents being available as a bytes, we\nused a Cursor and wrote it with tokio::io::copy.\n\nHowever, Cursor implements both AsyncRead and Read, so we can factor out\nthe copying code into a copy_to_blobservice helper function and use it\nin both places.\n\nThe output name being wrong error kind arguably is still a bit misplaced\nhere, but that\u0027s left for later.\n\nChange-Id: Iec3c422c12270ee111f864d2b78c0861f78edfa4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5ca7220a4d6eccb817a3f630b461f9df8e45cc42"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5ca7220a4d6eccb817a3f630b461f9df8e45cc42"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"399db23f1ab7f7f884812332ba155dc9c8454cf3","is_merged_in_target_branch":false,"change_id":"Ibf76b496874158fb85b21e52e7c3561e66cffaba","change_number":13253,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f8137e407fd9a92b6c0809e54f358ae053c9fe62":{"kind":"REWORK","_number":4,"created":"2025-03-13 10:51:01.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/54/13254/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/13254/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/13254/4"}}},"commit":{"parents":[{"commit":"399db23f1ab7f7f884812332ba155dc9c8454cf3","subject":"docs(tvix/glue): add_*_builtins: fix docstring","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d399db23f1ab7f7f884812332ba155dc9c8454cf3"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 08:30:44.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 10:50:56.000000000","tz":60},"subject":"refactor(tvix/glue): move toFile to import builtins","message":"refactor(tvix/glue): move toFile to import builtins\n\nThis does import the contents into the store, so it should belong in there.\n\nWhile moving, I also noticed the code copying to the BlobService can be\nshared with the one used when importing a blob via import helper.\nIt was a bit hidden - due to the contents being available as a bytes, we\nused a Cursor and wrote it with tokio::io::copy.\n\nHowever, Cursor implements both AsyncRead and Read, so we can factor out\nthe copying code into a copy_to_blobservice helper function and use it\nin both places.\n\nThe output name being wrong error kind arguably is still a bit misplaced\nhere, but that\u0027s left for later.\n\nChange-Id: Iec3c422c12270ee111f864d2b78c0861f78edfa4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8137e407fd9a92b6c0809e54f358ae053c9fe62"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8137e407fd9a92b6c0809e54f358ae053c9fe62"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"399db23f1ab7f7f884812332ba155dc9c8454cf3","is_merged_in_target_branch":false,"change_id":"Ibf76b496874158fb85b21e52e7c3561e66cffaba","change_number":13253,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7967170de8469265e93afbf00183fd4b36f9550d":{"kind":"REWORK","_number":5,"created":"2025-03-13 11:34:54.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/54/13254/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/13254/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/13254/5"}}},"commit":{"parents":[{"commit":"47631849e26694fe6fb963592fc0ca379dfaaa15","subject":"docs(tvix/glue): add_*_builtins: fix docstring","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47631849e26694fe6fb963592fc0ca379dfaaa15"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 08:30:44.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 11:34:39.000000000","tz":60},"subject":"refactor(tvix/glue): move toFile to import builtins","message":"refactor(tvix/glue): move toFile to import builtins\n\nThis does import the contents into the store, so it should belong in there.\n\nWhile moving, I also noticed the code copying to the BlobService can be\nshared with the one used when importing a blob via import helper.\nIt was a bit hidden - due to the contents being available as a bytes, we\nused a Cursor and wrote it with tokio::io::copy.\n\nHowever, Cursor implements both AsyncRead and Read, so we can factor out\nthe copying code into a copy_to_blobservice helper function and use it\nin both places.\n\nThe output name being wrong error kind arguably is still a bit misplaced\nhere, but that\u0027s left for later.\n\nChange-Id: Iec3c422c12270ee111f864d2b78c0861f78edfa4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7967170de8469265e93afbf00183fd4b36f9550d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7967170de8469265e93afbf00183fd4b36f9550d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"47631849e26694fe6fb963592fc0ca379dfaaa15","is_merged_in_target_branch":false,"change_id":"Ibf76b496874158fb85b21e52e7c3561e66cffaba","change_number":13253,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4535824166c9e42304f19c34d56d2281b2b886ab":{"kind":"REWORK","_number":6,"created":"2025-03-13 12:08:04.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/54/13254/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/13254/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/13254/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/13254/6"}}},"commit":{"parents":[{"commit":"ba54ba47eefc6f109cca9f1fa462c3f8ea6238ed","subject":"docs(tvix/cli): fix docstring","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dba54ba47eefc6f109cca9f1fa462c3f8ea6238ed"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-13 08:30:44.000000000","tz":60},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2025-03-13 12:08:04.000000000","tz":0},"subject":"refactor(tvix/glue): move toFile to import builtins","message":"refactor(tvix/glue): move toFile to import builtins\n\nThis does import the contents into the store, so it should belong in there.\n\nWhile moving, I also noticed the code copying to the BlobService can be\nshared with the one used when importing a blob via import helper.\nIt was a bit hidden - due to the contents being available as a bytes, we\nused a Cursor and wrote it with tokio::io::copy.\n\nHowever, Cursor implements both AsyncRead and Read, so we can factor out\nthe copying code into a copy_to_blobservice helper function and use it\nin both places.\n\nThe output name being wrong error kind arguably is still a bit misplaced\nhere, but that\u0027s left for later.\n\nChange-Id: Iec3c422c12270ee111f864d2b78c0861f78edfa4\nReviewed-on: https://cl.tvl.fyi/c/depot/+/13254\nReviewed-by: Domen Kožar \u003cdomen@cachix.org\u003e\nTested-by: BuildkiteCI\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4535824166c9e42304f19c34d56d2281b2b886ab"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4535824166c9e42304f19c34d56d2281b2b886ab"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ba54ba47eefc6f109cca9f1fa462c3f8ea6238ed","is_merged_in_target_branch":true,"change_id":"I7ce7932e35ee1b01bccbc142a7bdc7af9ce7e51e","change_number":13256,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000139,"name":"Domen Kožar","email":"domen@cachix.org","username":"domenkozar"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}