)]}'
{"id":"depot~1382","triplet_id":"depot~canon~I7e88d1231dd402e0ad764e16b28e9a51964c6293","project":"depot","branch":"canon","hashtags":[],"change_id":"I7e88d1231dd402e0ad764e16b28e9a51964c6293","subject":"feat(3p/cgit): add \"this commit\" option to switch form","status":"MERGED","created":"2020-07-23 20:39:53.000000000","updated":"2020-07-23 20:53:39.000000000","submitted":"2020-07-23 20:53:04.000000000","submitter":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1382","meta_rev_id":"8a78b14502ce37dddd9952f2cd2c4abeb3e577cf","_number":1382,"virtual_id_number":1382,"owner":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-23 20:53:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-23 20:53:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-23 20:39:53.000000000","updated_by":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"reviewer":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"state":"CC"},{"updated":"2020-07-23 20:42:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-23 20:48:05.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"db5eea07e769303cfa0078dd790b32647f40f044","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2020-07-23 20:39:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"377b0f5b1f0caa813905c45bc529c68e820e83b2","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-23 20:42:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/1660","accounts_in_message":[],"_revision_number":1},{"id":"bbbec51a4ae07fd59c62dfc7ffad9de07feb59ad","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-23 20:48:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"77c1c120cfb7e1f7a248513582608f5cc704e697","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2020-07-23 20:52:26.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ccb9fc72433030d2ea8b81a3ae06f7f333cc868b","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-23 20:53:00.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/1662","accounts_in_message":[],"_revision_number":2},{"id":"d255261b702542514f852dbecc64d40439d38687","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2020-07-23 20:53:04.000000000","message":"Change has been successfully rebased and submitted as be98295dc24492f6607cce04ba586e3897a83543 by Alyssa Ross","accounts_in_message":[],"_revision_number":3},{"id":"8a78b14502ce37dddd9952f2cd2c4abeb3e577cf","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-23 20:53:39.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/1663","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"be98295dc24492f6607cce04ba586e3897a83543","revisions":{"4d8165e4fd7a7454d01e9450a840e72dfff9034f":{"kind":"REWORK","_number":1,"created":"2020-07-23 20:39:53.000000000","uploader":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"ref":"refs/changes/82/1382/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1382/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1382/1"}}},"commit":{"parents":[{"commit":"fa01f515e278d3b8d0c8af20d0668fb7baa98d6a","subject":"feat(web/panettone): The start of a very simple issue tracker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa01f515e278d3b8d0c8af20d0668fb7baa98d6a"}]}],"author":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-23 19:54:13.000000000","tz":0},"committer":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-23 20:39:25.000000000","tz":0},"subject":"feat(3p/cgit): add \"this commit\" option to switch form","message":"feat(3p/cgit): add \"this commit\" option to switch form\n\nBranches are grouped into their own section to make the \"this commit\"\noption visually distinct.\n\nAdding this option will result in two options being marked as selected\nif a branch has the same name as a commit oid.  But that would cause\nall sorts of other problems anyway (attempting to switch to the branch\nwould actually give you the commit, etc.), so let\u0027s not worry about\nthat.\n\nA \"permalink\" link on the blob view next to the \"plain\" link would\nprobably be more discoverable, but that would only work for the blob\nview.  The switch UI is visible everywhere.\n\nThis patch is in use already at \u003chttps://git.qyliss.net/\u003e and\n\u003chttps://spectrum-os.org/git/\u003e.\n\nCc: Profpatsch \u003cmail@profpatsch.de\u003e\nChange-Id: I7e88d1231dd402e0ad764e16b28e9a51964c6293\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4d8165e4fd7a7454d01e9450a840e72dfff9034f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4d8165e4fd7a7454d01e9450a840e72dfff9034f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fa01f515e278d3b8d0c8af20d0668fb7baa98d6a","is_merged_in_target_branch":true,"change_id":"I704f0996d15199329bbd5450f3d959046bf13973","change_number":1337,"patch_set_number":21,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9ec566dcbd891f18720ec98ceeff41def46982b0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-07-23 20:52:26.000000000","uploader":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"ref":"refs/changes/82/1382/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1382/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1382/2"}}},"commit":{"parents":[{"commit":"fa01f515e278d3b8d0c8af20d0668fb7baa98d6a","subject":"feat(web/panettone): The start of a very simple issue tracker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa01f515e278d3b8d0c8af20d0668fb7baa98d6a"}]}],"author":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-23 19:54:13.000000000","tz":0},"committer":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-23 20:51:24.000000000","tz":0},"subject":"feat(3p/cgit): add \"this commit\" option to switch form","message":"feat(3p/cgit): add \"this commit\" option to switch form\n\nBranches are grouped into their own section to make the \"this commit\"\noption visually distinct.\n\nAdding this option will result in two options being marked as selected\nif a branch has the same name as a commit oid.  But that would cause\nall sorts of other problems anyway (attempting to switch to the branch\nwould actually give you the commit, etc.), so let\u0027s not worry about\nthat.\n\nA \"permalink\" link on the blob view next to the \"plain\" link would\nprobably be more discoverable, but that would only work for the blob\nview.  The switch UI is visible everywhere.\n\nThis patch is in use already at \u003chttps://git.qyliss.net/\u003e and\n\u003chttps://spectrum-os.org/git/\u003e.\n\nSigned-off-by: Alyssa Ross \u003chi@alyssa.is\u003e\nMessage-Id: \u003c20200723204820.16776-1-hi@alyssa.is\u003e\nCc: Profpatsch \u003cmail@profpatsch.de\u003e\nChange-Id: I7e88d1231dd402e0ad764e16b28e9a51964c6293\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9ec566dcbd891f18720ec98ceeff41def46982b0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9ec566dcbd891f18720ec98ceeff41def46982b0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fa01f515e278d3b8d0c8af20d0668fb7baa98d6a","is_merged_in_target_branch":true,"change_id":"I704f0996d15199329bbd5450f3d959046bf13973","change_number":1337,"patch_set_number":21,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"be98295dc24492f6607cce04ba586e3897a83543":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-07-23 20:53:04.000000000","uploader":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"ref":"refs/changes/82/1382/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1382/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1382/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1382/3"}}},"commit":{"parents":[{"commit":"fa01f515e278d3b8d0c8af20d0668fb7baa98d6a","subject":"feat(web/panettone): The start of a very simple issue tracker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa01f515e278d3b8d0c8af20d0668fb7baa98d6a"}]}],"author":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-23 19:54:13.000000000","tz":0},"committer":{"name":"Alyssa Ross","email":"hi@alyssa.is","date":"2020-07-23 20:53:04.000000000","tz":0},"subject":"feat(3p/cgit): add \"this commit\" option to switch form","message":"feat(3p/cgit): add \"this commit\" option to switch form\n\nBranches are grouped into their own section to make the \"this commit\"\noption visually distinct.\n\nAdding this option will result in two options being marked as selected\nif a branch has the same name as a commit oid.  But that would cause\nall sorts of other problems anyway (attempting to switch to the branch\nwould actually give you the commit, etc.), so let\u0027s not worry about\nthat.\n\nA \"permalink\" link on the blob view next to the \"plain\" link would\nprobably be more discoverable, but that would only work for the blob\nview.  The switch UI is visible everywhere.\n\nThis patch is in use already at \u003chttps://git.qyliss.net/\u003e and\n\u003chttps://spectrum-os.org/git/\u003e.\n\nSigned-off-by: Alyssa Ross \u003chi@alyssa.is\u003e\nMessage-Id: \u003c20200723204820.16776-1-hi@alyssa.is\u003e\nCc: Profpatsch \u003cmail@profpatsch.de\u003e\nChange-Id: I7e88d1231dd402e0ad764e16b28e9a51964c6293\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1382\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbe98295dc24492f6607cce04ba586e3897a83543"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbe98295dc24492f6607cce04ba586e3897a83543"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fa01f515e278d3b8d0c8af20d0668fb7baa98d6a","is_merged_in_target_branch":true,"change_id":"I704f0996d15199329bbd5450f3d959046bf13973","change_number":1337,"patch_set_number":21,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}
