)]}'
{"id":"depot~1426","triplet_id":"depot~canon~Ibc686b9f06ec68e79759ca2c989414bd5fbce696","project":"depot","branch":"canon","topic":"tvix","hashtags":[],"change_id":"Ibc686b9f06ec68e79759ca2c989414bd5fbce696","subject":"fix(3p/nix): Don\u0027t include depotPath in the main drv","status":"MERGED","created":"2020-07-25 01:31:58.000000000","updated":"2020-08-29 13:59:25.000000000","submitted":"2020-07-25 02:29:14.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1426","meta_rev_id":"f6ea6161fdc7250a15972685310538f238349119","_number":1426,"virtual_id_number":1426,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-25 02:29:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-25 02:29:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-25 01:32:59.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"state":"REVIEWER"},{"updated":"2020-07-25 01:32:59.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2020-07-25 01:38:33.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0200a31711ee19c55f1d335f2ec683c2c67b7fc6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-25 01:31:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db7c25691bef4ac38f37772cb4d9a7e24436167e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-25 01:32:27.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a267006a450f2cc9f1ad14086473a34eaae351fe","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-25 01:38:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/1831","accounts_in_message":[],"_revision_number":1},{"id":"3043bf59e4d8b1e24140e1f05352636c9108fdcf","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-25 01:39:25.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/1833","accounts_in_message":[],"_revision_number":2},{"id":"b57d1abdb4a4c95c4ffe9bda808cabddc8ec3655","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-25 01:54:21.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"99047c3be0e822e32d7ccb689870904334f3e623","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-25 01:56:55.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b68b4d5b75128df186af68aa7e6185dca7e9d608","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-25 02:01:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/1838","accounts_in_message":[],"_revision_number":3},{"id":"74ae38be83de9f9c0fd7a8ff321ffa9c360ce84f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-25 02:29:14.000000000","message":"Change has been successfully rebased and submitted as 2f85dfe50c1eb9622a1b409de95629bcced0992f by glittershark","accounts_in_message":[],"_revision_number":4},{"id":"e1afe83baab487759618c638e733d0cc509f4668","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-25 02:29:58.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/1844","accounts_in_message":[],"_revision_number":4},{"id":"f6ea6161fdc7250a15972685310538f238349119","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-29 13:59:25.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2f85dfe50c1eb9622a1b409de95629bcced0992f","revisions":{"5923f3329188628474ae55d4bec50ad8a6dd03f5":{"kind":"REWORK","_number":1,"created":"2020-07-25 01:31:58.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/26/1426/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/1426/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/1426/1"}}},"commit":{"parents":[{"commit":"391973083aa8150ec209e13ca23be922b5091752","subject":"feat(3p/nix): Add build for VM for testing tvix","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d391973083aa8150ec209e13ca23be922b5091752"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:30:42.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:30:42.000000000","tz":-240},"subject":"fix(3p/nix): Don\u0027t include depotPath in the main drv","message":"fix(3p/nix): Don\u0027t include depotPath in the main drv\n\nIncluding depotPath in the shellHook of the main derivation for tvix\nwas, unsurprisingly, causing spurious rebuilds. It\u0027s still useful when\ndeveloping locally, though, so I\u0027ve extracted it to a `build-shell`\nderivation as a passthru attribute and updated the documentation.\n\nFixes: #20\nChange-Id: Ibc686b9f06ec68e79759ca2c989414bd5fbce696\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5923f3329188628474ae55d4bec50ad8a6dd03f5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5923f3329188628474ae55d4bec50ad8a6dd03f5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"391973083aa8150ec209e13ca23be922b5091752","is_merged_in_target_branch":false,"change_id":"I3c7422bb10d3ce05a3094671cb770f1f745d814c","change_number":1423,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5dc87296a666ab3ace98b181267353273c268165":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-07-25 01:32:27.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/26/1426/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/1426/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/1426/2"}}},"commit":{"parents":[{"commit":"1689b57e81103e1e844286bc06677e5afd595a1f","subject":"feat(3p/nix): Add build for VM for testing tvix","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1689b57e81103e1e844286bc06677e5afd595a1f"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:30:42.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:32:23.000000000","tz":-240},"subject":"fix(3p/nix): Don\u0027t include depotPath in the main drv","message":"fix(3p/nix): Don\u0027t include depotPath in the main drv\n\nIncluding depotPath in the shellHook of the main derivation for tvix\nwas, unsurprisingly, causing spurious rebuilds. It\u0027s still useful when\ndeveloping locally, though, so I\u0027ve extracted it to a `build-shell`\nderivation as a passthru attribute and updated the documentation.\n\nFixes: #20\nChange-Id: Ibc686b9f06ec68e79759ca2c989414bd5fbce696\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5dc87296a666ab3ace98b181267353273c268165"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5dc87296a666ab3ace98b181267353273c268165"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1689b57e81103e1e844286bc06677e5afd595a1f","is_merged_in_target_branch":false,"change_id":"I3c7422bb10d3ce05a3094671cb770f1f745d814c","change_number":1423,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"028253c094d91d353c16b4364e47f0dadca25743":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2020-07-25 01:54:21.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/26/1426/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/1426/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/1426/3"}}},"commit":{"parents":[{"commit":"acbd240d03779ba69d777b8840ec654b5a14d387","subject":"feat(3p/nix): Add build for VM for testing tvix","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dacbd240d03779ba69d777b8840ec654b5a14d387"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:30:42.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:54:18.000000000","tz":-240},"subject":"fix(3p/nix): Don\u0027t include depotPath in the main drv","message":"fix(3p/nix): Don\u0027t include depotPath in the main drv\n\nIncluding depotPath in the shellHook of the main derivation for tvix\nwas, unsurprisingly, causing spurious rebuilds. It\u0027s still useful when\ndeveloping locally, though, so I\u0027ve extracted it to a `build-shell`\nderivation as a passthru attribute and updated the documentation.\n\nFixes: #20\nChange-Id: Ibc686b9f06ec68e79759ca2c989414bd5fbce696\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d028253c094d91d353c16b4364e47f0dadca25743"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d028253c094d91d353c16b4364e47f0dadca25743"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"acbd240d03779ba69d777b8840ec654b5a14d387","is_merged_in_target_branch":false,"change_id":"I3c7422bb10d3ce05a3094671cb770f1f745d814c","change_number":1423,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2f85dfe50c1eb9622a1b409de95629bcced0992f":{"kind":"REWORK","_number":4,"created":"2020-07-25 02:29:14.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/26/1426/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/1426/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/1426/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/1426/4"}}},"commit":{"parents":[{"commit":"4dca023385034839873b330cb6fcaf46807e0a59","subject":"feat(3p/nix): Add build for VM for testing tvix","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4dca023385034839873b330cb6fcaf46807e0a59"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-25 01:30:42.000000000","tz":-240},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-07-25 02:29:14.000000000","tz":0},"subject":"fix(3p/nix): Don\u0027t include depotPath in the main drv","message":"fix(3p/nix): Don\u0027t include depotPath in the main drv\n\nIncluding depotPath in the shellHook of the main derivation for tvix\nwas, unsurprisingly, causing spurious rebuilds. It\u0027s still useful when\ndeveloping locally, though, so I\u0027ve extracted it to a `build-shell`\nderivation as a passthru attribute and updated the documentation.\n\nFixes: #20\nChange-Id: Ibc686b9f06ec68e79759ca2c989414bd5fbce696\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1426\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2f85dfe50c1eb9622a1b409de95629bcced0992f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2f85dfe50c1eb9622a1b409de95629bcced0992f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4dca023385034839873b330cb6fcaf46807e0a59","is_merged_in_target_branch":true,"change_id":"I3c7422bb10d3ce05a3094671cb770f1f745d814c","change_number":1423,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}