)]}'
{"third_party/gerrit_plugins/builder.nix":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"78e816665ccd647b0f9e030efab9fe13713aff04","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ depot, pkgs, ... }:"},{"line_number":2,"context_line":"let"},{"line_number":3,"context_line":"  defaultOverlayPluginCmd \u003d attrs: \u0027\u0027"},{"line_number":4,"context_line":"      cp -R \"${attrs.src}\" \"$out/plugins/${attrs.name}\""},{"line_number":5,"context_line":"  \u0027\u0027;"},{"line_number":6,"context_line":"in"},{"line_number":7,"context_line":"{"}],"source_content_type":"text/x-nix","patch_set":7,"id":"094485b1_90599567","line":4,"updated":"2020-07-26 22:05:41.000000000","message":"this wouldn\u0027t need to exist if you just made the formals to buildGerritBazelPlugin look like\n\n    { name\n    , src\n    , overlayPluginCmd ? \u0027\u0027\n        cp -r \"${src}\" \"$out/plugins/${name}\"\n      \u0027\u0027\n    }:\n\nand then I don\u0027t think you\u0027d need `attrs` at all","commit_id":"0cbe52094fc9953f3d38a247bc70f5df7d6aae99"},{"author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"change_message_id":"077ed6da76bd545895d6fe9d48367ae985373c1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ depot, pkgs, ... }:"},{"line_number":2,"context_line":"let"},{"line_number":3,"context_line":"  defaultOverlayPluginCmd \u003d attrs: \u0027\u0027"},{"line_number":4,"context_line":"      cp -R \"${attrs.src}\" \"$out/plugins/${attrs.name}\""},{"line_number":5,"context_line":"  \u0027\u0027;"},{"line_number":6,"context_line":"in"},{"line_number":7,"context_line":"{"}],"source_content_type":"text/x-nix","patch_set":7,"id":"d435332a_09ee8030","line":4,"in_reply_to":"094485b1_90599567","updated":"2020-07-26 23:55:55.000000000","message":"Done","commit_id":"0cbe52094fc9953f3d38a247bc70f5df7d6aae99"}],"third_party/gerrit_plugins/default.nix":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"b124d715ec49b33401cffbc0bc31a941e61b44e4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"let"},{"line_number":4,"context_line":"  inherit (pkgs) fetchurl;"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  buildGerritBazelPlugin \u003d attrs: ((depot.third_party.gerrit.override rec {"},{"line_number":7,"context_line":"    name \u003d \"${attrs.name}.jar\";"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    overlayPluginCmd \u003d pkgs.lib.attrByPath [\"overlayPluginCmd\"] \u0027\u0027"}],"source_content_type":"text/x-nix","patch_set":6,"id":"31cab6e6_44d00bea","line":6,"range":{"start_line":6,"start_character":2,"end_line":6,"end_character":25},"updated":"2020-07-26 19:52:51.000000000","message":"this feels like it could go in its own file in `nix/` perhaps. But maybe that\u0027s too much indirection.","commit_id":"d7b5d4f6acb9cf88455c87fca16a2804329c962e"},{"author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"change_message_id":"3434a180f506c783757b0e6d927748109d648b55","unresolved":false,"context_lines":[{"line_number":3,"context_line":"let"},{"line_number":4,"context_line":"  inherit (pkgs) fetchurl;"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  buildGerritBazelPlugin \u003d attrs: ((depot.third_party.gerrit.override rec {"},{"line_number":7,"context_line":"    name \u003d \"${attrs.name}.jar\";"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    overlayPluginCmd \u003d pkgs.lib.attrByPath [\"overlayPluginCmd\"] \u0027\u0027"}],"source_content_type":"text/x-nix","patch_set":6,"id":"2becbf19_b61146ab","line":6,"range":{"start_line":6,"start_character":2,"end_line":6,"end_character":25},"in_reply_to":"31cab6e6_44d00bea","updated":"2020-07-26 21:40:59.000000000","message":"Done. I put it in builder.nix instead, because it feels more logical to just plonk it here.","commit_id":"d7b5d4f6acb9cf88455c87fca16a2804329c962e"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"b124d715ec49b33401cffbc0bc31a941e61b44e4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    bazelTarget \u003d \"//plugins/${attrs.name}\";"},{"line_number":20,"context_line":"  }).overrideAttrs (super: {"},{"line_number":21,"context_line":"    deps \u003d super.deps.overrideAttrs (superDeps: {"},{"line_number":22,"context_line":"      outputHash \u003d attrs.depsOutputHash;"},{"line_number":23,"context_line":"    });"},{"line_number":24,"context_line":"    installPhase \u003d \u0027\u0027"},{"line_number":25,"context_line":"      cp \"bazel-bin/plugins/${attrs.name}/${attrs.name}.jar\" \"$out\""}],"source_content_type":"text/x-nix","patch_set":6,"id":"4c88a1da_c7e592fc","line":22,"range":{"start_line":22,"start_character":19,"end_line":22,"end_character":39},"updated":"2020-07-26 19:52:51.000000000","message":"I feel like it\u0027s probably more readable (and self-documenting) to destructure this out of attrs","commit_id":"d7b5d4f6acb9cf88455c87fca16a2804329c962e"},{"author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"change_message_id":"aadc428b458873125887eb2f2d26b56a06551691","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    bazelTarget \u003d \"//plugins/${attrs.name}\";"},{"line_number":20,"context_line":"  }).overrideAttrs (super: {"},{"line_number":21,"context_line":"    deps \u003d super.deps.overrideAttrs (superDeps: {"},{"line_number":22,"context_line":"      outputHash \u003d attrs.depsOutputHash;"},{"line_number":23,"context_line":"    });"},{"line_number":24,"context_line":"    installPhase \u003d \u0027\u0027"},{"line_number":25,"context_line":"      cp \"bazel-bin/plugins/${attrs.name}/${attrs.name}.jar\" \"$out\""}],"source_content_type":"text/x-nix","patch_set":6,"id":"c3fc9bb7_e3b4be10","line":22,"range":{"start_line":22,"start_character":19,"end_line":22,"end_character":39},"in_reply_to":"4c88a1da_c7e592fc","updated":"2020-07-26 21:40:26.000000000","message":"Done","commit_id":"d7b5d4f6acb9cf88455c87fca16a2804329c962e"}]}
