)]}'
{"id":"depot~1471","triplet_id":"depot~canon~Ibc4242e3e0f974ac53fffc482d3724b0547425ab","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-07-26 22:00:52.000000000","reason":"manually removed"}},"hashtags":[],"change_id":"Ibc4242e3e0f974ac53fffc482d3724b0547425ab","subject":"fix(web/panettone): Don\u0027t log backtraces","status":"MERGED","created":"2020-07-26 21:43:39.000000000","updated":"2020-07-26 22:00:52.000000000","submitted":"2020-07-26 21:44:49.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1471","meta_rev_id":"a215b17d084df5273dd3c4456236ac48c2bfc544","_number":1471,"virtual_id_number":1471,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-26 21:44:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-26 21:44:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-26 21:44:20.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"734c045d0251fbc789541e330528a703319d2b9d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-26 21:43:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"961d136a5140df038c77fda68f9d9b1c022df839","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-26 21:44:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2b8572ac5fdeecb51094d0ec7b23af2d33a09759","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-26 21:44:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/1964","accounts_in_message":[],"_revision_number":1},{"id":"9ca155fdc3ad2df0caeec4251754ad04027fd1b3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-26 21:44:49.000000000","message":"Change has been successfully rebased and submitted as 273053dbf3287c02dda60b442cf138a412d8f75b","accounts_in_message":[],"_revision_number":2},{"id":"d4f0dfdc66718449e01665cf7a8e4143570f762f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-26 21:45:25.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/1965","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"273053dbf3287c02dda60b442cf138a412d8f75b","revisions":{"7b8a9b4e619c72cc01264c279b656137c1f5adb4":{"kind":"REWORK","_number":1,"created":"2020-07-26 21:43:39.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/71/1471/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/71/1471/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/71/1471/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/71/1471/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/71/1471/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/71/1471/1"}}},"commit":{"parents":[{"commit":"e231493ff4207e1fe3191ba13ece8c7477c3f242","subject":"feat(3p/lisp): Add ironclad","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de231493ff4207e1fe3191ba13ece8c7477c3f242"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-26 21:42:39.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-26 21:42:39.000000000","tz":-240},"subject":"fix(web/panettone): Don\u0027t log backtraces","message":"fix(web/panettone): Don\u0027t log backtraces\n\nThe default hunchentoot behavior is to log all local variables when\nlogging lisp backtraces - this is nice for debugging, but means that if\nwe hit an error when checking for auth with the ldap server we log the\npassword provided by the user. No good! Let\u0027s just turn off logging of\nbacktraces for now.\n\nChange-Id: Ibc4242e3e0f974ac53fffc482d3724b0547425ab\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7b8a9b4e619c72cc01264c279b656137c1f5adb4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7b8a9b4e619c72cc01264c279b656137c1f5adb4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e231493ff4207e1fe3191ba13ece8c7477c3f242","is_merged_in_target_branch":true,"change_id":"Id768717991404f959b003c7e2f28f1f4d532b94b","change_number":1333,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"273053dbf3287c02dda60b442cf138a412d8f75b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-07-26 21:44:49.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/71/1471/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/71/1471/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/71/1471/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/71/1471/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/71/1471/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/71/1471/2"}}},"commit":{"parents":[{"commit":"e231493ff4207e1fe3191ba13ece8c7477c3f242","subject":"feat(3p/lisp): Add ironclad","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de231493ff4207e1fe3191ba13ece8c7477c3f242"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-26 21:42:39.000000000","tz":-240},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-07-26 21:44:49.000000000","tz":0},"subject":"fix(web/panettone): Don\u0027t log backtraces","message":"fix(web/panettone): Don\u0027t log backtraces\n\nThe default hunchentoot behavior is to log all local variables when\nlogging lisp backtraces - this is nice for debugging, but means that if\nwe hit an error when checking for auth with the ldap server we log the\npassword provided by the user. No good! Let\u0027s just turn off logging of\nbacktraces for now.\n\nChange-Id: Ibc4242e3e0f974ac53fffc482d3724b0547425ab\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1471\nReviewed-by: glittershark \u003cgrfn@gws.fyi\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d273053dbf3287c02dda60b442cf138a412d8f75b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d273053dbf3287c02dda60b442cf138a412d8f75b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e231493ff4207e1fe3191ba13ece8c7477c3f242","is_merged_in_target_branch":true,"change_id":"Id768717991404f959b003c7e2f28f1f4d532b94b","change_number":1333,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}
