)]}'
{"id":"depot~1584","triplet_id":"depot~canon~I61c745f96420c02e089bd3c362ac3ccb117d3073","project":"depot","branch":"canon","topic":"tvix","attention_set":{},"removed_from_attention_set":{"1000002":{"account":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"last_update":"2020-08-03 02:45:19.000000000","reason":"manually removed in reply dialog"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2020-08-03 08:38:57.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2020-08-03 00:12:12.000000000","reason":"removed on reply"},"1000004":{"account":{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},"last_update":"2020-08-03 08:38:57.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-08-03 08:38:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I61c745f96420c02e089bd3c362ac3ccb117d3073","subject":"refactor(3p/nix): Only initialise garbage-collector where needed","status":"MERGED","created":"2020-08-02 22:56:41.000000000","updated":"2020-08-29 13:59:29.000000000","submitted":"2020-08-03 08:38:57.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1584","meta_rev_id":"3593274ef422548946d14169c04573be5d72b9d1","_number":1584,"virtual_id_number":1584,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-08-03 08:38:57.000000000","_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-08-03 08:38:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-08-03 08:38:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-02 22:57:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2020-08-02 22:57:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},"state":"REVIEWER"},{"updated":"2020-08-02 22:57:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2020-08-02 22:57:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"state":"REVIEWER"},{"updated":"2020-08-02 22:59:21.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"935bb57a1389c40560ac3b1b77906af1fbf7b96d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-02 22:56:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4910b91be0536abdd259ec72a5919523a5ea7628","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-02 22:59:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/2257","accounts_in_message":[],"_revision_number":1},{"id":"b8001f0c737fcef7179e043d977f4cdae79b76eb","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2020-08-03 00:12:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c935d69b43463dcfe9371eb4336afd2bf6bb0c3a","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-08-03 02:45:19.000000000","message":"Patch Set 1: Code-Review+2\n\nGood find!","accounts_in_message":[],"_revision_number":1},{"id":"3243c2ccfe58a23d3e7efce4da8ac6c8886de62e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-03 08:38:57.000000000","message":"Change has been successfully rebased and submitted as 46c78aa0f9e843554079f59bd104e6376a8c9141","accounts_in_message":[],"_revision_number":2},{"id":"d26d34fce3246066100b17979ebec36b41c0486e","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-03 08:39:32.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/2274","accounts_in_message":[],"_revision_number":2},{"id":"3593274ef422548946d14169c04573be5d72b9d1","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-29 13:59:29.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"46c78aa0f9e843554079f59bd104e6376a8c9141","revisions":{"ce6b39a9f1db17c92993c49902f8da543b18d30c":{"kind":"REWORK","_number":1,"created":"2020-08-02 22:56:41.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/84/1584/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/84/1584/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/84/1584/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/84/1584/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/84/1584/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/84/1584/1"}}},"commit":{"parents":[{"commit":"87d70d2a808849c7d64f499e13410378da200354","subject":"style(cheddar): Apply rustfmt","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d87d70d2a808849c7d64f499e13410378da200354"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-08-02 22:54:16.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-08-02 22:54:16.000000000","tz":60},"subject":"refactor(3p/nix): Only initialise garbage-collector where needed","message":"refactor(3p/nix): Only initialise garbage-collector where needed\n\nOnly libexpr depends on the garbage collector, specifically only\ninstantiations of EvalState actually require the GC to be initialised.\n\nRather than always starting it for the whole program, even if it is\nnot needed, this change moves the GC initialisation into libexpr,\nguarded by absl::call_once.\n\nThis should make it possible to run the nix daemon without the garbage\ncollector interfering, granted that things are correcty separated and\nthe daemon does not actually invoke the evaluator.\n\nBased on my investigation so far, the daemon logic itself does not\nrequire libexpr to be present at all - so I think it is safe - but the\ncurrent monobinary might have some tricks up its sleeve that will\ncause problems for us. We can deal with those if they arise.\n\nRelates to https://b.tvl.fyi/issues/30\n\nChange-Id: I61c745f96420c02e089bd3c362ac3ccb117d3073\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dce6b39a9f1db17c92993c49902f8da543b18d30c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dce6b39a9f1db17c92993c49902f8da543b18d30c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"87d70d2a808849c7d64f499e13410378da200354","is_merged_in_target_branch":true,"change_id":"I378b5ae618b01244edc090ad1495fbd56857d7c0","change_number":1562,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"46c78aa0f9e843554079f59bd104e6376a8c9141":{"kind":"REWORK","_number":2,"created":"2020-08-03 08:38:57.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/84/1584/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/84/1584/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/84/1584/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/84/1584/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/84/1584/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/84/1584/2"}}},"commit":{"parents":[{"commit":"6e04b235069e1f4f22218d0a56e452ce36cceff0","subject":"feat(edef/loxy): init","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6e04b235069e1f4f22218d0a56e452ce36cceff0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-08-02 22:54:16.000000000","tz":60},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2020-08-03 08:38:57.000000000","tz":0},"subject":"refactor(3p/nix): Only initialise garbage-collector where needed","message":"refactor(3p/nix): Only initialise garbage-collector where needed\n\nOnly libexpr depends on the garbage collector, specifically only\ninstantiations of EvalState actually require the GC to be initialised.\n\nRather than always starting it for the whole program, even if it is\nnot needed, this change moves the GC initialisation into libexpr,\nguarded by absl::call_once.\n\nThis should make it possible to run the nix daemon without the garbage\ncollector interfering, granted that things are correcty separated and\nthe daemon does not actually invoke the evaluator.\n\nBased on my investigation so far, the daemon logic itself does not\nrequire libexpr to be present at all - so I think it is safe - but the\ncurrent monobinary might have some tricks up its sleeve that will\ncause problems for us. We can deal with those if they arise.\n\nRelates to https://b.tvl.fyi/issues/30\n\nChange-Id: I61c745f96420c02e089bd3c362ac3ccb117d3073\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1584\nTested-by: BuildkiteCI\nReviewed-by: edef \u003cedef@edef.eu\u003e\nReviewed-by: kanepyork \u003crikingcoding@gmail.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d46c78aa0f9e843554079f59bd104e6376a8c9141"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d46c78aa0f9e843554079f59bd104e6376a8c9141"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6e04b235069e1f4f22218d0a56e452ce36cceff0","is_merged_in_target_branch":true,"change_id":"I78fd798ec32636cf38f877c364abc87ef9f14836","change_number":1587,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}