)]}'
{"id":"depot~1698","triplet_id":"depot~canon~Ie2d914688a80f42d0234d351a7cc0714fd15709e","project":"depot","branch":"canon","topic":"tvix","attention_set":{},"removed_from_attention_set":{"1000002":{"account":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"last_update":"2020-08-09 17:26:19.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2020-08-09 10:40:51.000000000","reason":"manually removed in reply dialog"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2020-08-09 17:26:19.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-08-09 17:26:15.000000000","reason":"manually removed in reply dialog"}},"hashtags":[],"change_id":"Ie2d914688a80f42d0234d351a7cc0714fd15709e","subject":"test(tvix): Cover scanForReferences in a test","status":"MERGED","created":"2020-08-09 04:31:14.000000000","updated":"2020-08-29 13:59:23.000000000","submitted":"2020-08-09 17:26:19.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1698","meta_rev_id":"92f9a40cd906677a5425e822ca6fd66e90d78e0b","_number":1698,"virtual_id_number":1698,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-08-09 17:26:19.000000000","_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-08-09 17:26:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-09 04:31:39.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2020-08-09 04:31:39.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"state":"REVIEWER"},{"updated":"2020-08-09 04:33:07.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-09 10:40:51.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"}],"messages":[{"id":"ab4e234b189660799578dce06619753acb34ce29","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 04:31:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c712263c7ed22a2bb73c4958a17788a7c8fc66b","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 04:33:07.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/2621","accounts_in_message":[],"_revision_number":1},{"id":"9dce80f4b66f7ff72440f3bf81ce3c15bddeb6d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 04:37:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"31b5f82e6c08d4fe9537d6abaa45bb208ddf3235","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 04:39:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f63dc503a166e2fc9aa8781f9f37d66bae32d926","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 04:40:15.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/2622","accounts_in_message":[],"_revision_number":2},{"id":"aac02563a9b8cf0c7efbb3934372cc0ba7401392","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 04:41:47.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/2623","accounts_in_message":[],"_revision_number":3},{"id":"d9b64d0e6bbd6122a1867cdef2934b046d8774c7","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 04:47:25.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/2623","accounts_in_message":[],"_revision_number":3},{"id":"2fce1abca3358fe41233e8c83434e44c9e80d3f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 04:48:34.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"534ceb6bfe927c378b3bd60a5b405c9be4a1c839","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 04:51:18.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/2624","accounts_in_message":[],"_revision_number":4},{"id":"3f9ca85d286ec496cef26718bdb8bdeaba291234","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-08-09 10:16:37.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"2e291cc33ed8bb67348c42f1e4f69774c47b8d2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 17:22:12.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b0d7b97fbbe544b6efd04e90e261e5b10a8c8de5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 17:24:02.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"7d5772521bf4c70cc46bc474aeef47f29243c857","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 17:24:39.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/2632","accounts_in_message":[],"_revision_number":6},{"id":"3af74bd95f7f15068143e109f2841f01e4e26b1c","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 17:24:55.000000000","message":"Patch Set 5: Verified-1\n\nBuild of patchset 5 failed: https://buildkite.com/tvl/depot/builds/2631","accounts_in_message":[],"_revision_number":5},{"id":"0d17850650dc70b5bc3d516c7be7bd6c42c4e05e","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 17:26:15.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"125eade6ba1771f9995bcfe573bde0e51db92f44","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-09 17:26:19.000000000","message":"Change has been successfully rebased and submitted as d1653533a6f6f70d1d95001abf3f80665ba135e7","accounts_in_message":[],"_revision_number":7},{"id":"9e729e73c60fd69f270ce47a09f7c21468b58e1f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-09 17:26:56.000000000","message":"Patch Set 7:\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/2633","accounts_in_message":[],"_revision_number":7},{"id":"92f9a40cd906677a5425e822ca6fd66e90d78e0b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-29 13:59:23.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"d1653533a6f6f70d1d95001abf3f80665ba135e7","revisions":{"7afbb64e5ef501ceff1eccffe7be6132aa53359c":{"kind":"REWORK","_number":1,"created":"2020-08-09 04:31:14.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/1"}}},"commit":{"parents":[{"commit":"ec7d3685465c0082f525afee8cb525edfbed07a1","subject":"fix(tvix): Make nix value structs inherit from GC","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dec7d3685465c0082f525afee8cb525edfbed07a1"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:31:09.000000000","tz":-240},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7afbb64e5ef501ceff1eccffe7be6132aa53359c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7afbb64e5ef501ceff1eccffe7be6132aa53359c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ec7d3685465c0082f525afee8cb525edfbed07a1","is_merged_in_target_branch":true,"change_id":"I057d8c9f7dafbee7de7644ff152c9cba1aa6bc03","change_number":1696,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4bbdc3b0157e2b9a94dd0d4da3c8094dd2b4dce4":{"kind":"REWORK","_number":2,"created":"2020-08-09 04:37:33.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/2"}}},"commit":{"parents":[{"commit":"ec7d3685465c0082f525afee8cb525edfbed07a1","subject":"fix(tvix): Make nix value structs inherit from GC","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dec7d3685465c0082f525afee8cb525edfbed07a1"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:37:29.000000000","tz":-240},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4bbdc3b0157e2b9a94dd0d4da3c8094dd2b4dce4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4bbdc3b0157e2b9a94dd0d4da3c8094dd2b4dce4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ec7d3685465c0082f525afee8cb525edfbed07a1","is_merged_in_target_branch":true,"change_id":"I057d8c9f7dafbee7de7644ff152c9cba1aa6bc03","change_number":1696,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3482451709ec933789b4f5d2b6aeba6576ab8443":{"kind":"REWORK","_number":3,"created":"2020-08-09 04:39:03.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/3"}}},"commit":{"parents":[{"commit":"ec7d3685465c0082f525afee8cb525edfbed07a1","subject":"fix(tvix): Make nix value structs inherit from GC","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dec7d3685465c0082f525afee8cb525edfbed07a1"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:38:54.000000000","tz":-240},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3482451709ec933789b4f5d2b6aeba6576ab8443"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3482451709ec933789b4f5d2b6aeba6576ab8443"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ec7d3685465c0082f525afee8cb525edfbed07a1","is_merged_in_target_branch":true,"change_id":"I057d8c9f7dafbee7de7644ff152c9cba1aa6bc03","change_number":1696,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"26e4fc417b0c17c01e3291dad700e3e58fd76214":{"kind":"REWORK","_number":4,"created":"2020-08-09 04:48:34.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/4"}}},"commit":{"parents":[{"commit":"ec7d3685465c0082f525afee8cb525edfbed07a1","subject":"fix(tvix): Make nix value structs inherit from GC","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dec7d3685465c0082f525afee8cb525edfbed07a1"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:48:31.000000000","tz":-240},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d26e4fc417b0c17c01e3291dad700e3e58fd76214"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d26e4fc417b0c17c01e3291dad700e3e58fd76214"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ec7d3685465c0082f525afee8cb525edfbed07a1","is_merged_in_target_branch":true,"change_id":"I057d8c9f7dafbee7de7644ff152c9cba1aa6bc03","change_number":1696,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0cdbfb526af667cd7bdda9a10af21f30c652741b":{"kind":"REWORK","_number":5,"created":"2020-08-09 17:22:12.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/5"}}},"commit":{"parents":[{"commit":"ec7d3685465c0082f525afee8cb525edfbed07a1","subject":"fix(tvix): Make nix value structs inherit from GC","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dec7d3685465c0082f525afee8cb525edfbed07a1"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 17:22:10.000000000","tz":-240},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0cdbfb526af667cd7bdda9a10af21f30c652741b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0cdbfb526af667cd7bdda9a10af21f30c652741b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ec7d3685465c0082f525afee8cb525edfbed07a1","is_merged_in_target_branch":true,"change_id":"I057d8c9f7dafbee7de7644ff152c9cba1aa6bc03","change_number":1696,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5861a27f94e23ef742fa8dd4305633437d9dabdc":{"kind":"REWORK","_number":6,"created":"2020-08-09 17:24:02.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/6"}}},"commit":{"parents":[{"commit":"ec7d3685465c0082f525afee8cb525edfbed07a1","subject":"fix(tvix): Make nix value structs inherit from GC","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dec7d3685465c0082f525afee8cb525edfbed07a1"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 17:24:01.000000000","tz":-240},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5861a27f94e23ef742fa8dd4305633437d9dabdc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5861a27f94e23ef742fa8dd4305633437d9dabdc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ec7d3685465c0082f525afee8cb525edfbed07a1","is_merged_in_target_branch":true,"change_id":"I057d8c9f7dafbee7de7644ff152c9cba1aa6bc03","change_number":1696,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d1653533a6f6f70d1d95001abf3f80665ba135e7":{"kind":"REWORK","_number":7,"created":"2020-08-09 17:26:19.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/98/1698/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/1698/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/1698/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/1698/7"}}},"commit":{"parents":[{"commit":"dfab786653c24b11a8e9338df29c22fd7a0c4959","subject":"feat(users/multi): init, add SSH keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddfab786653c24b11a8e9338df29c22fd7a0c4959"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-09 04:27:55.000000000","tz":-240},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-08-09 17:26:19.000000000","tz":0},"subject":"test(tvix): Cover scanForReferences in a test","message":"test(tvix): Cover scanForReferences in a test\n\nAded a few test cases covering the scanForReferences function, which had\nbeen accidentally broken in 976a36c (which is now partially-reverted).\nAs part of this, since the test needed to generate hashes for store\npaths, the logic in MakeStorePath to compress a sha256 hash down to 20\nbytes and convert it to base32 has been extracted to a member function\non the Hash class.\n\nFixes: #34\nChange-Id: Ie2d914688a80f42d0234d351a7cc0714fd15709e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1698\nTested-by: BuildkiteCI\nReviewed-by: kanepyork \u003crikingcoding@gmail.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd1653533a6f6f70d1d95001abf3f80665ba135e7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd1653533a6f6f70d1d95001abf3f80665ba135e7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"dfab786653c24b11a8e9338df29c22fd7a0c4959","is_merged_in_target_branch":true,"change_id":"I93d6733595c96e0d4e67281e4781e2e0ff424a63","change_number":1700,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}