)]}'
{"third_party/nix/src/nix-daemon/nix-daemon.cc":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b082d0a7a703b11983100a051b5418af92413845","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  ServerBuilder builder;"},{"line_number":105,"context_line":"  builder.RegisterService(worker);"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  auto n_fds \u003d sd_listen_fds(0);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if (n_fds \u003e 1) {"},{"line_number":110,"context_line":"    LOG(FATAL) \u003c\u003c \"Too many file descriptors (\" \u003c\u003c n_fds"}],"source_content_type":"text/x-c","patch_set":8,"id":"990b1ac7_925984b8","line":107,"range":{"start_line":107,"start_character":15,"end_line":107,"end_character":28},"updated":"2020-08-31 01:35:50.000000000","message":"I\u0027m wondering if we should mark locations that we know are platform dependent somehow, for a future where e.g. OS X support is considered again.\n\n(alternatively do the ifdef dance)","commit_id":"8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"49d14a2c7ef2a808357a9c22e77512abe2a40229","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  ServerBuilder builder;"},{"line_number":105,"context_line":"  builder.RegisterService(worker);"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  auto n_fds \u003d sd_listen_fds(0);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if (n_fds \u003e 1) {"},{"line_number":110,"context_line":"    LOG(FATAL) \u003c\u003c \"Too many file descriptors (\" \u003c\u003c n_fds"}],"source_content_type":"text/x-c","patch_set":8,"id":"5ca83b31_9916370d","line":107,"range":{"start_line":107,"start_character":15,"end_line":107,"end_character":28},"in_reply_to":"805abf42_8b3db35f","updated":"2020-09-01 00:59:48.000000000","message":"Ack","commit_id":"8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"075ded31dd015472f73401b860c9614292862293","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  ServerBuilder builder;"},{"line_number":105,"context_line":"  builder.RegisterService(worker);"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  auto n_fds \u003d sd_listen_fds(0);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if (n_fds \u003e 1) {"},{"line_number":110,"context_line":"    LOG(FATAL) \u003c\u003c \"Too many file descriptors (\" \u003c\u003c n_fds"}],"source_content_type":"text/x-c","patch_set":8,"id":"805abf42_8b3db35f","line":107,"range":{"start_line":107,"start_character":15,"end_line":107,"end_character":28},"in_reply_to":"990b1ac7_925984b8","updated":"2020-08-31 23:40:57.000000000","message":"I am 90% sure this will work on macos, as it\u0027s only looking up env vars anyway. If that ends up not being the case we\u0027ll have to revisit anyway.\n\nAs a general rule, I am in support of starting to require marking locations which we *know* will not be cross-platform","commit_id":"8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"},{"author":{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true},"change_message_id":"97e2902bada1f2422f029d59e4afab1009557c07","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  auto n_fds \u003d sd_listen_fds(0);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if (n_fds \u003e 1) {"},{"line_number":110,"context_line":"    LOG(FATAL) \u003c\u003c \"Too many file descriptors (\" \u003c\u003c n_fds"},{"line_number":111,"context_line":"               \u003c\u003c \") received from systemd socket activation\";"},{"line_number":112,"context_line":"  }"}],"source_content_type":"text/x-c","patch_set":8,"id":"ed5cdde6_021a9720","line":109,"updated":"2020-08-30 20:23:58.000000000","message":"Is there any reason why you\u0027re failing on \u003e 1 fd? Does grpc not let you add multiple listeners?","commit_id":"8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"ce9154219d06d9db6990212f6fdd65e31b9450da","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  auto n_fds \u003d sd_listen_fds(0);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if (n_fds \u003e 1) {"},{"line_number":110,"context_line":"    LOG(FATAL) \u003c\u003c \"Too many file descriptors (\" \u003c\u003c n_fds"},{"line_number":111,"context_line":"               \u003c\u003c \") received from systemd socket activation\";"},{"line_number":112,"context_line":"  }"}],"source_content_type":"text/x-c","patch_set":8,"id":"b9bbc8b4_b09fc288","line":109,"in_reply_to":"ed5cdde6_021a9720","updated":"2020-08-30 22:16:21.000000000","message":"well, no, but since we have to implement our own accept loop the extra complexity overhead doesn\u0027t really feel worth it yet without a compelling use case. down the road if the need presents itself to support multiple fds I think it\u0027d probably be fine to add support for.","commit_id":"8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"}]}