)]}'
{"id":"depot~1882","triplet_id":"depot~canon~I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e","project":"depot","branch":"canon","topic":"tvix","attention_set":{},"removed_from_attention_set":{"1000002":{"account":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"last_update":"2020-09-01 00:59:25.000000000","reason":"manually removed in reply dialog"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2020-09-01 01:07:11.000000000","reason":"Change was submitted"},"1000022":{"account":{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true},"last_update":"2020-09-01 01:07:11.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-09-01 00:59:48.000000000","reason":"manually removed in reply dialog"}},"hashtags":[],"change_id":"I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e","subject":"feat(tvix): Support systemd socket activation","status":"MERGED","created":"2020-08-29 03:17:56.000000000","updated":"2020-09-01 01:09:30.000000000","submitted":"2020-09-01 01:07:11.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1882-tvix","meta_rev_id":"c6af23cfd9b11398a756f4731ad715e851050379","_number":1882,"virtual_id_number":1882,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-09-01 01:07:11.000000000","_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-09-01 01:07:11.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2020-09-01 01:07:11.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-09-01 01:07:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true}],"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-29 03:20:34.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-29 03:59:20.000000000","updated_by":{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true},"reviewer":{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true},"state":"CC"},{"updated":"2020-08-30 17:56:32.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2020-08-30 17:56:46.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"state":"REVIEWER"}],"messages":[{"id":"91fdaeac2ac82d89e637706ef016f11405338e18","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-29 03:17:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d77004490d8bec19b0f36f1e4ac52d7730803ea7","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-29 03:20:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/3110","accounts_in_message":[],"_revision_number":1},{"id":"e1e7c58cb66855d32d7b0b107c08b6b2819082b3","author":{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true},"date":"2020-08-29 03:59:20.000000000","message":"Patch Set 1:\n\nConsider using sd_listen_fds from libsystemd, it\u0027s about 50 lines of code that handles everything for you.","accounts_in_message":[],"_revision_number":1},{"id":"a526eef3132eff33d5634f17c66509d4ca525c59","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-29 13:59:05.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":1},{"id":"6f5c4d5ccbab1df2b39d08615e14df90c412d992","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-29 16:45:01.000000000","message":"Patch Set 1:\n\ntesting this is blocked by https://b.tvl.fyi/issues/52","accounts_in_message":[],"_revision_number":1},{"id":"265cf62a5f799fa36723e026b7a5cb18776feacc","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-29 17:59:05.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Consider using sd_listen_fds from libsystemd, it\u0027s about 50 lines of code that handles everything for you.\n\ndone, thanks!","accounts_in_message":[],"_revision_number":1},{"id":"5f6daf7711e81c729790f6c5b599a228f7776e55","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-29 17:59:40.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e testing this is blocked by https://b.tvl.fyi/issues/52\n\nlooks like we can get around this by setting NIX_REMOTE\u003ddaemon explicitly, so we should be ok here. Bug still stands though.","accounts_in_message":[],"_revision_number":1},{"id":"eb55216b8c39fa5b11b4edbe618586bc7cebb08e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 15:18:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1b0b5b29ce77e7626857eb8e4d7b1685884d82da","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 15:20:20.000000000","message":"Patch Set 2:\n\nI\u0027m a little stuck on this. I\u0027ve got the daemon running, and it appears to be taking the socket from systemd, but all requests are timing out. Help would be appreciated","accounts_in_message":[],"_revision_number":2},{"id":"aa729994eef6956726e87fef9013ae97df85eb60","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 15:21:22.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"f4a08a76aa5af03bacf908636110b1fd84d1eeda","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 15:21:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/3117","accounts_in_message":[],"_revision_number":2},{"id":"65cabcf857c68d0a79abd2b28ccc4ad825d98f19","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 15:23:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/3119","accounts_in_message":[],"_revision_number":3},{"id":"3e7b023d11f90855796627d4fd5bfe51c71cc598","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 16:37:05.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"80637b932c7672bab2bb67b05d8008add1c24312","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 16:37:42.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/3129","accounts_in_message":[],"_revision_number":4},{"id":"274939c7e414dd1fd8673c3373d4f35bb22752f6","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 17:49:59.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":4},{"id":"17ff07c38016be1c09afa3f7cc948cc48dc3d803","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 17:50:18.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"02905fd72f4c1b6d09030949c3ae17676e2ee09f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 17:52:56.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/3133","accounts_in_message":[],"_revision_number":5},{"id":"584b81fbce8f3da3e7a1d450ec7c23b208f1635e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 17:58:18.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"65bd2bf4741e676b6d06aad1c30d76a9525f1898","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 18:00:35.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/3135","accounts_in_message":[],"_revision_number":6},{"id":"c2219259e7258f65bdea33a783fc7d624bfbd752","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 18:08:59.000000000","message":"Uploaded patch set 7: Commit message was updated.","accounts_in_message":[],"_revision_number":7},{"id":"4aebd482f4821b24651b8856958e2840b766c2c8","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 18:09:30.000000000","message":"Patch Set 7:\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/3139","accounts_in_message":[],"_revision_number":7},{"id":"1bbae8a80e99aef2bfef4dd3c18e25fdd93950a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 18:10:53.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"2cfb46cef3612484b042c424d407835b1358f2aa","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-30 18:13:31.000000000","message":"Patch Set 8: Verified+1\n\nBuild of patchset 8 passed: https://buildkite.com/tvl/depot/builds/3141","accounts_in_message":[],"_revision_number":8},{"id":"97e2902bada1f2422f029d59e4afab1009557c07","author":{"_account_id":1000022,"name":"V","email":"v@anomalous.eu","username":"v","inactive":true},"date":"2020-08-30 20:23:58.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"ce9154219d06d9db6990212f6fdd65e31b9450da","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-30 22:16:21.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"b082d0a7a703b11983100a051b5418af92413845","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-31 01:35:50.000000000","message":"Patch Set 8: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"6a47cbe65ff2956f55758e3e96ad3c7d15392750","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-31 15:31:10.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"1cb14db4f63cab68dbd8609a8b9f9b3ee0fdfa0a","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-08-31 15:33:49.000000000","message":"Patch Set 9: Verified+1\n\nBuild of patchset 9 passed: https://buildkite.com/tvl/depot/builds/3162","accounts_in_message":[],"_revision_number":9},{"id":"075ded31dd015472f73401b860c9614292862293","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-08-31 23:40:57.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"d82ae28f9b7853c0dc610061a043cb6380e8884c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-01 00:58:16.000000000","message":"Uploaded patch set 10: Code-Review+2: Patch Set 9 was rebased.","accounts_in_message":[],"_revision_number":10},{"id":"e434a35782c4372c925d42515662f06eb4421041","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-01 00:59:06.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.","accounts_in_message":[],"_revision_number":11},{"id":"fe2f87c188467ef42940077b4830e573c3b71d1e","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-09-01 00:59:25.000000000","message":"Patch Set 11: Code-Review+2\n\nLooks good now!","accounts_in_message":[],"_revision_number":11},{"id":"49d14a2c7ef2a808357a9c22e77512abe2a40229","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-01 00:59:48.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"06a3ba3874132bdf59a4595d9d9fbcf7a8987896","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-01 00:59:51.000000000","message":"Removed Code-Review+2 by glittershark \u003cgrfn@gws.fyi\u003e\n","accounts_in_message":[],"_revision_number":11},{"id":"76d793ef3e16140460b2da3b2f39457fc435f2e5","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-01 01:01:45.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/3196","accounts_in_message":[],"_revision_number":10},{"id":"2d57a796b9b337973d4d300c77a3d69a287d4128","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-01 01:06:58.000000000","message":"Patch Set 11: Verified+1\n\nBuild of patchset 11 passed: https://buildkite.com/tvl/depot/builds/3203","accounts_in_message":[],"_revision_number":11},{"id":"c72205c7291cda2420ce266e116be379e3430f83","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-01 01:07:11.000000000","message":"Change has been successfully rebased and submitted as c5f3b12f0484cd1a5152b6c64a336e9852d7c484","accounts_in_message":[],"_revision_number":12},{"id":"c6af23cfd9b11398a756f4731ad715e851050379","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-01 01:09:30.000000000","message":"Patch Set 12:\n\nBuild of patchset 12 passed: https://buildkite.com/tvl/depot/builds/3209","accounts_in_message":[],"_revision_number":12}],"current_revision_number":12,"current_revision":"c5f3b12f0484cd1a5152b6c64a336e9852d7c484","revisions":{"0984ac0cda88cc471cef1f51b97e502b4aa44b75":{"kind":"REWORK","_number":1,"created":"2020-08-29 03:17:56.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/1"}}},"commit":{"parents":[{"commit":"1dc78a2e124a006fc51732dbeb19b312dd93097f","subject":"fix(tvix): Chunk the AddTextToStore request","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1dc78a2e124a006fc51732dbeb19b312dd93097f"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nwippity wip - will write a message when I know this actually works\n\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0984ac0cda88cc471cef1f51b97e502b4aa44b75"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0984ac0cda88cc471cef1f51b97e502b4aa44b75"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1dc78a2e124a006fc51732dbeb19b312dd93097f","is_merged_in_target_branch":false,"change_id":"I6f0232cdbc98653484816b39855126873fc59a03","change_number":1835,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b3ab5e39e6b904a46a0f3ee0d196486b95f0686e":{"kind":"REWORK","_number":2,"created":"2020-08-30 15:18:54.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/2"}}},"commit":{"parents":[{"commit":"90af7b54fbbacde192f3a6706c2587fdc7e90973","subject":"refactor(tvix): Drop meson.build files","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d90af7b54fbbacde192f3a6706c2587fdc7e90973"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-30 15:18:51.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nwippity wip - will write a message when I know this actually works\n\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db3ab5e39e6b904a46a0f3ee0d196486b95f0686e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db3ab5e39e6b904a46a0f3ee0d196486b95f0686e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"90af7b54fbbacde192f3a6706c2587fdc7e90973","is_merged_in_target_branch":false,"change_id":"I6bb6b4257b7815932581ded7929437dba80961c9","change_number":1885,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a70b6a64528feca6dfdddb9a07e638c3a34ce26a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2020-08-30 15:21:22.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/3"}}},"commit":{"parents":[{"commit":"de851ec08b6a2796d0333a650d368de73fb8b923","subject":"feat(panettone): Add nav to the top of the page as well","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde851ec08b6a2796d0333a650d368de73fb8b923"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-08-30 15:21:22.000000000","tz":0},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nwippity wip - will write a message when I know this actually works\n\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da70b6a64528feca6dfdddb9a07e638c3a34ce26a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da70b6a64528feca6dfdddb9a07e638c3a34ce26a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de851ec08b6a2796d0333a650d368de73fb8b923","is_merged_in_target_branch":true,"change_id":"I1d07175fa07aee057ddd140a6864d01342fbb7ef","change_number":1868,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"df66269bf4d009f2b2a3a26362e71c5dbfbe5d04":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-08-30 16:37:05.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/4"}}},"commit":{"parents":[{"commit":"bc2ef1672568f47752ee36402d08ce0275ff5c0f","subject":"fix(tvix): localstatedir should be /nix/var","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbc2ef1672568f47752ee36402d08ce0275ff5c0f"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-30 16:36:56.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nwippity wip - will write a message when I know this actually works\n\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddf66269bf4d009f2b2a3a26362e71c5dbfbe5d04"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddf66269bf4d009f2b2a3a26362e71c5dbfbe5d04"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"bc2ef1672568f47752ee36402d08ce0275ff5c0f","is_merged_in_target_branch":false,"change_id":"I0d95f2cc5641f610c1bdb03b036fac61dac9842d","change_number":1890,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"20abb67428fbf1d33fb007786dace8aa5049569e":{"kind":"REWORK","_number":5,"created":"2020-08-30 17:50:18.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/5"}}},"commit":{"parents":[{"commit":"de84e491cf58e330a3a10cc217bb9154107819f0","subject":"fix(tvix): localstatedir should be /nix/var","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde84e491cf58e330a3a10cc217bb9154107819f0"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-30 17:50:14.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen. Making this happen,\nby the way, was a bit of a journey - at one point I attempted to\nServerBuilder\u0027s experimental AddExternalConnectionAcceptor API, and that\ndidn\u0027t work either - it appears that the final missing piece to getting\nthis working was explicitly fcntl(2)ing the client file descriptors to\nset O_NONBLOCK before passing them into gRPC. With that set, this all\nworks inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d20abb67428fbf1d33fb007786dace8aa5049569e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d20abb67428fbf1d33fb007786dace8aa5049569e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de84e491cf58e330a3a10cc217bb9154107819f0","is_merged_in_target_branch":true,"change_id":"I0d95f2cc5641f610c1bdb03b036fac61dac9842d","change_number":1890,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1eb106449170568f3e0d7d12a2250331f9802feb":{"kind":"REWORK","_number":6,"created":"2020-08-30 17:58:18.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/6"}}},"commit":{"parents":[{"commit":"de84e491cf58e330a3a10cc217bb9154107819f0","subject":"fix(tvix): localstatedir should be /nix/var","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde84e491cf58e330a3a10cc217bb9154107819f0"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-30 17:55:14.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen. Making this happen,\nby the way, was a bit of a journey - at one point I attempted to\nServerBuilder\u0027s experimental AddExternalConnectionAcceptor API, and that\ndidn\u0027t work either - it appears that the final missing piece to getting\nthis working was explicitly fcntl(2)ing the client file descriptors to\nset O_NONBLOCK before passing them into gRPC. With that set, this all\nworks inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1eb106449170568f3e0d7d12a2250331f9802feb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1eb106449170568f3e0d7d12a2250331f9802feb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de84e491cf58e330a3a10cc217bb9154107819f0","is_merged_in_target_branch":true,"change_id":"I0d95f2cc5641f610c1bdb03b036fac61dac9842d","change_number":1890,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"eb2d840c3b55d121ce9c0acce4fc1359d889329b":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2020-08-30 18:08:59.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/7"}}},"commit":{"parents":[{"commit":"de84e491cf58e330a3a10cc217bb9154107819f0","subject":"fix(tvix): localstatedir should be /nix/var","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde84e491cf58e330a3a10cc217bb9154107819f0"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-30 18:08:28.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen.\n\nMaking this happen, by the way, was a bit of a journey - at one point I\nattempted to ServerBuilder\u0027s experimental AddExternalConnectionAcceptor\nAPI, and that didn\u0027t work either - it appears that the final missing\npiece to getting this working was explicitly fcntl(2)ing the client file\ndescriptors to set O_NONBLOCK before passing them into gRPC. With that\nset, this all works inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003deb2d840c3b55d121ce9c0acce4fc1359d889329b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003deb2d840c3b55d121ce9c0acce4fc1359d889329b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de84e491cf58e330a3a10cc217bb9154107819f0","is_merged_in_target_branch":true,"change_id":"I0d95f2cc5641f610c1bdb03b036fac61dac9842d","change_number":1890,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56":{"kind":"REWORK","_number":8,"created":"2020-08-30 18:10:53.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/8"}}},"commit":{"parents":[{"commit":"de84e491cf58e330a3a10cc217bb9154107819f0","subject":"fix(tvix): localstatedir should be /nix/var","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde84e491cf58e330a3a10cc217bb9154107819f0"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-30 18:10:51.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen.\n\nMaking this happen, by the way, was a bit of a journey - at one point I\nattempted to ServerBuilder\u0027s experimental AddExternalConnectionAcceptor\nAPI, and that didn\u0027t work either - it appears that the final missing\npiece to getting this working was explicitly fcntl(2)ing the client file\ndescriptors to set O_NONBLOCK before passing them into gRPC. With that\nset, this all works inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8eb4fdae6044e4d7cb86f7b12f19e2c43accbc56"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de84e491cf58e330a3a10cc217bb9154107819f0","is_merged_in_target_branch":true,"change_id":"I0d95f2cc5641f610c1bdb03b036fac61dac9842d","change_number":1890,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"68c892d1645255d82a1539db07c655bf568599d7":{"kind":"REWORK","_number":9,"created":"2020-08-31 15:31:10.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/9"}}},"commit":{"parents":[{"commit":"de84e491cf58e330a3a10cc217bb9154107819f0","subject":"fix(tvix): localstatedir should be /nix/var","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde84e491cf58e330a3a10cc217bb9154107819f0"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-31 15:31:07.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen.\n\nMaking this happen, by the way, was a bit of a journey - at one point I\nattempted to ServerBuilder\u0027s experimental AddExternalConnectionAcceptor\nAPI, and that didn\u0027t work either - it appears that the final missing\npiece to getting this working was explicitly fcntl(2)ing the client file\ndescriptors to set O_NONBLOCK before passing them into gRPC. With that\nset, this all works inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d68c892d1645255d82a1539db07c655bf568599d7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d68c892d1645255d82a1539db07c655bf568599d7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de84e491cf58e330a3a10cc217bb9154107819f0","is_merged_in_target_branch":true,"change_id":"I0d95f2cc5641f610c1bdb03b036fac61dac9842d","change_number":1890,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5739d1d0d990b78f51e3717f50bf4315cdd8f0f7":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2020-09-01 00:58:16.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/10"}}},"commit":{"parents":[{"commit":"fcb014e43db8e1e21341d86534a5fcfe014140bb","subject":"chore(glittershark/system): Include chupacabraSystem in CI builds","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfcb014e43db8e1e21341d86534a5fcfe014140bb"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-01 00:57:55.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen.\n\nMaking this happen, by the way, was a bit of a journey - at one point I\nattempted to ServerBuilder\u0027s experimental AddExternalConnectionAcceptor\nAPI, and that didn\u0027t work either - it appears that the final missing\npiece to getting this working was explicitly fcntl(2)ing the client file\ndescriptors to set O_NONBLOCK before passing them into gRPC. With that\nset, this all works inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5739d1d0d990b78f51e3717f50bf4315cdd8f0f7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5739d1d0d990b78f51e3717f50bf4315cdd8f0f7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fcb014e43db8e1e21341d86534a5fcfe014140bb","is_merged_in_target_branch":true,"change_id":"Ic8a63f76a0b19f6b1f9ab836d1418849cce06aa0","change_number":1895,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8863d1a42f7641c5f5647ff997b944e73749b4d9":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2020-09-01 00:59:06.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/11"}}},"commit":{"parents":[{"commit":"8b671b66f4239ff940632bf62502f4b3e42f6844","subject":"feat(tvix): Expose depot in the test vm","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8b671b66f4239ff940632bf62502f4b3e42f6844"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-01 00:59:02.000000000","tz":-240},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen.\n\nMaking this happen, by the way, was a bit of a journey - at one point I\nattempted to ServerBuilder\u0027s experimental AddExternalConnectionAcceptor\nAPI, and that didn\u0027t work either - it appears that the final missing\npiece to getting this working was explicitly fcntl(2)ing the client file\ndescriptors to set O_NONBLOCK before passing them into gRPC. With that\nset, this all works inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8863d1a42f7641c5f5647ff997b944e73749b4d9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8863d1a42f7641c5f5647ff997b944e73749b4d9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8b671b66f4239ff940632bf62502f4b3e42f6844","is_merged_in_target_branch":false,"change_id":"I26314634895ab1339f5715c0b0b261028eefdaa3","change_number":1923,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c5f3b12f0484cd1a5152b6c64a336e9852d7c484":{"kind":"REWORK","_number":12,"created":"2020-09-01 01:07:11.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/82/1882/12","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/1882/12","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/1882/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/1882/12"}}},"commit":{"parents":[{"commit":"e472aa016e4d8bef79930d750c65e40ce21dba3a","subject":"feat(tvix): Expose depot in the test vm","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de472aa016e4d8bef79930d750c65e40ce21dba3a"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-08-29 03:17:28.000000000","tz":-240},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-09-01 01:07:11.000000000","tz":0},"subject":"feat(tvix): Support systemd socket activation","message":"feat(tvix): Support systemd socket activation\n\nWhen the nix daemon starts up, first check (using sd_listen_fds) whether\nwe have been systemd socket-activated. If so, instead of passing the nix\ndaemon socket path to grpc, start a manual accept(2) loop, passing the\nclient file descriptors to grpc via AddInsecureChannelFromFd. There\u0027s an\nopen grpc issue at https://github.com/grpc/grpc/issues/19133 for\nbuilding support into grpc to do this automatically, but as of right now\nthis appears to be the only way to make this happen.\n\nMaking this happen, by the way, was a bit of a journey - at one point I\nattempted to ServerBuilder\u0027s experimental AddExternalConnectionAcceptor\nAPI, and that didn\u0027t work either - it appears that the final missing\npiece to getting this working was explicitly fcntl(2)ing the client file\ndescriptors to set O_NONBLOCK before passing them into gRPC. With that\nset, this all works inside of the test vm.\n\nFixes: b/56\nChange-Id: I5d2ab2b5b02eb570249b30a9674e115c61b0ab0e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1882\nReviewed-by: kanepyork \u003crikingcoding@gmail.com\u003e\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5f3b12f0484cd1a5152b6c64a336e9852d7c484"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5f3b12f0484cd1a5152b6c64a336e9852d7c484"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e472aa016e4d8bef79930d750c65e40ce21dba3a","is_merged_in_target_branch":true,"change_id":"I26314634895ab1339f5715c0b0b261028eefdaa3","change_number":1923,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}