)]}'
{"id":"depot~1930","triplet_id":"depot~canon~I906869aba7d25156aaf92c090b169ce02785b85e","project":"depot","branch":"canon","hashtags":[],"change_id":"I906869aba7d25156aaf92c090b169ce02785b85e","subject":"fix(term-switcher.el): Explicitly fail if buffers are missing","status":"MERGED","created":"2020-09-05 11:42:27.000000000","updated":"2020-09-05 11:46:32.000000000","submitted":"2020-09-05 11:45:33.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1930","meta_rev_id":"ac96c7386065f0e2e96b77dfd1d2edd1a3141872","_number":1930,"virtual_id_number":1930,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-09-05 11:45:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-09-05 11:45:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-05 11:45:16.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"462fc01cbcbff94f6819fcdedfa4ea3a8ad3872a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-09-05 11:42:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a0e7f3f6019cf06fbc0c58c9ead8aed93bcb113","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-05 11:45:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/3259","accounts_in_message":[],"_revision_number":1},{"id":"f7d3b1f5fa24e03e77aa90b0b111e356941e5229","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-09-05 11:45:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5a89bc0d6195a2f02737f5ddf9fd719e6e0e7c8c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-09-05 11:45:33.000000000","message":"Change has been successfully rebased and submitted as 11430f4a4b3d4b2f6cfc103e574768dbcc64b517","accounts_in_message":[],"_revision_number":2},{"id":"ac96c7386065f0e2e96b77dfd1d2edd1a3141872","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-05 11:46:32.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/3260","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"11430f4a4b3d4b2f6cfc103e574768dbcc64b517","revisions":{"df4f02116263d5156af5299082f14148e7a1bf2c":{"kind":"REWORK","_number":1,"created":"2020-09-05 11:42:27.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/30/1930/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/30/1930/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/30/1930/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/30/1930/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/30/1930/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/30/1930/1"}}},"commit":{"parents":[{"commit":"67e8f477a1f02195228732a643d5dfce8e21caa7","subject":"fix(u/riking/dotfiles): source rbenv config correctly","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d67e8f477a1f02195228732a643d5dfce8e21caa7"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-09-05 11:40:26.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-09-05 11:40:26.000000000","tz":60},"subject":"fix(term-switcher.el): Explicitly fail if buffers are missing","message":"fix(term-switcher.el): Explicitly fail if buffers are missing\n\nSince upgrading to Emacs 27 I have observed a strange behaviour where\nthis terminal switcher sometimes fails to select a valid buffer, in\nwhich case it falls through to the case that just opens a new buffer\ninstead.\n\nThis is kind of annoying and to aid in debugging this change makes the\ncreation of new buffers explicit and fails if no matching buffer is\nfound.\n\nNote that this is likely not a fix for the issue itself, but it will\nhelp debug what is going on.\n\nChange-Id: I906869aba7d25156aaf92c090b169ce02785b85e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddf4f02116263d5156af5299082f14148e7a1bf2c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddf4f02116263d5156af5299082f14148e7a1bf2c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"67e8f477a1f02195228732a643d5dfce8e21caa7","is_merged_in_target_branch":true,"change_id":"I1cf3dfc2d1edd2cb97ca432de5eb03c434b566e3","change_number":1929,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"11430f4a4b3d4b2f6cfc103e574768dbcc64b517":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-09-05 11:45:33.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/30/1930/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/30/1930/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/30/1930/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/30/1930/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/30/1930/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/30/1930/2"}}},"commit":{"parents":[{"commit":"67e8f477a1f02195228732a643d5dfce8e21caa7","subject":"fix(u/riking/dotfiles): source rbenv config correctly","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d67e8f477a1f02195228732a643d5dfce8e21caa7"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-09-05 11:40:26.000000000","tz":60},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2020-09-05 11:45:33.000000000","tz":0},"subject":"fix(term-switcher.el): Explicitly fail if buffers are missing","message":"fix(term-switcher.el): Explicitly fail if buffers are missing\n\nSince upgrading to Emacs 27 I have observed a strange behaviour where\nthis terminal switcher sometimes fails to select a valid buffer, in\nwhich case it falls through to the case that just opens a new buffer\ninstead.\n\nThis is kind of annoying and to aid in debugging this change makes the\ncreation of new buffers explicit and fails if no matching buffer is\nfound.\n\nNote that this is likely not a fix for the issue itself, but it will\nhelp debug what is going on.\n\nChange-Id: I906869aba7d25156aaf92c090b169ce02785b85e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1930\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d11430f4a4b3d4b2f6cfc103e574768dbcc64b517"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d11430f4a4b3d4b2f6cfc103e574768dbcc64b517"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"67e8f477a1f02195228732a643d5dfce8e21caa7","is_merged_in_target_branch":true,"change_id":"I1cf3dfc2d1edd2cb97ca432de5eb03c434b566e3","change_number":1929,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}