)]}'
{"id":"depot~1938","triplet_id":"depot~canon~Ic8460276769491b287e6b594984baae3b66beaa8","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2020-09-06 22:29:44.000000000","reason":"Change was abandoned"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-09-06 22:25:16.000000000","reason":"manually removed in reply dialog"}},"hashtags":[],"change_id":"Ic8460276769491b287e6b594984baae3b66beaa8","subject":"refactor(tvix): Limit to only 1 thread","status":"ABANDONED","created":"2020-09-06 22:13:45.000000000","updated":"2022-09-11 17:44:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d0fedff38af522c5ea93d01556c5e0573128eca6","_number":1938,"virtual_id_number":1938,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"all":[{"value":2,"date":"2022-09-11 17:44:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":1,"date":"2022-09-11 17:44:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-06 22:14:43.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-06 22:22:00.000000000","updated_by":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"reviewer":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"state":"REVIEWER"},{"updated":"2020-09-06 22:25:16.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"f791b16f1e536617afb4701946dba4a42c85e8cc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-06 22:13:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b2b7002721b76250ba4f9da577c13569aefe535e","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-06 22:14:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/3291","accounts_in_message":[],"_revision_number":1},{"id":"1d530e488f1323b78a3b2463f4a83fa6f80f9b0f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-06 22:20:47.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d210e881b0d8bb3cc5d92baa6916da444fcb9c82","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-09-06 22:22:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a4b103fed118d520c97325f88996604412a01a58","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-06 22:22:44.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"c4ffad901f662e8b7c9216cc0572fc2749c25347","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-06 22:23:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/3292","accounts_in_message":[],"_revision_number":2},{"id":"c983e5195d3eabe925e9a5c9a6ecf3a86fe36109","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-06 22:23:51.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/3296","accounts_in_message":[],"_revision_number":3},{"id":"d35c40a28b4f22f6c050ccfb3a21cb2e502bcc3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-06 22:24:08.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"132e8b504348c297fdf7ebcb05ca042087ae0883","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-09-06 22:24:55.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/3298","accounts_in_message":[],"_revision_number":4},{"id":"5c6ace7a093c95bd1e413daf33a6e169aa9ebe84","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-09-06 22:29:44.000000000","message":"Abandoned\n\nThis doesn\u0027t work - it causes all RPC calls to fail with RESOURCE-EXHAUSTED. See https://buildkite.com/tvl/depot/builds/3300#8f00be4c-7ba1-4441-b492-5fe965a3d4b2","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"fa915c2d5f98a16fb67b57b3286ed6da853a9610","revisions":{"39bcc71d550e036c9166e7777ad6cd6194d3c147":{"kind":"REWORK","_number":1,"created":"2020-09-06 22:13:45.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/38/1938/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/38/1938/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/38/1938/1"}}},"commit":{"parents":[{"commit":"a2d57dcddd7a647b52fb161e741bcea47ac2597a","subject":"chore(tvix): dontStrip tvix build","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da2d57dcddd7a647b52fb161e741bcea47ac2597a"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:10:53.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:13:41.000000000","tz":-240},"subject":"refactor(tvix): Limit to only 1 thread","message":"refactor(tvix): Limit to only 1 thread\n\nThere\u0027s a bunch of global, static builder state that is not properly\nlocked or made thread-local that is causing problems with having more\nthan one builder. In this particular case, there\u0027s a global static flag\nfor whether we\u0027re currently building something to prevent accidental\nrecursive builds that *aborts* (:0) in the case that the invariant is\nbroken - obviously we\u0027d like to get rid of that, but in the meantime to\nget us to a point where tvix is actually usable let\u0027s just limit to 1\nthread at a time.\n\nChange-Id: Ic8460276769491b287e6b594984baae3b66beaa8\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d39bcc71d550e036c9166e7777ad6cd6194d3c147"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d39bcc71d550e036c9166e7777ad6cd6194d3c147"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a2d57dcddd7a647b52fb161e741bcea47ac2597a","is_merged_in_target_branch":false,"change_id":"Ib816a2a98bf3b8afa6e8b255a74ccb93af6508c5","change_number":1937,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ffb4ad30e4127492af97b207d13baa83d2131baf":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-09-06 22:20:47.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/38/1938/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/38/1938/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/38/1938/2"}}},"commit":{"parents":[{"commit":"a2d57dcddd7a647b52fb161e741bcea47ac2597a","subject":"chore(tvix): dontStrip tvix build","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da2d57dcddd7a647b52fb161e741bcea47ac2597a"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:10:53.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:19:46.000000000","tz":-240},"subject":"refactor(tvix): Limit to only 1 thread","message":"refactor(tvix): Limit to only 1 thread\n\nSince upstream nix forks a process per connection, there\u0027s a bunch of\nglobal, static builder state that is not properly locked or made\nthread-local that is causing problems with having more than one builder.\nIn this particular case, there\u0027s a global static flag for whether we\u0027re\ncurrently building something to prevent accidental recursive builds\nthat *aborts* (:0) in the case that the invariant is broken - obviously\nwe\u0027d like to get rid of that at some point, but in the meantime to get\nus to a point where tvix is actually usable let\u0027s just limit to 1 thread\nat a time. This will cause a bit of a perf hit, but it will hopefully\nget us closer to self-hosting.\n\nChange-Id: Ic8460276769491b287e6b594984baae3b66beaa8\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dffb4ad30e4127492af97b207d13baa83d2131baf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dffb4ad30e4127492af97b207d13baa83d2131baf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a2d57dcddd7a647b52fb161e741bcea47ac2597a","is_merged_in_target_branch":false,"change_id":"Ib816a2a98bf3b8afa6e8b255a74ccb93af6508c5","change_number":1937,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ca4cc4dbcd8c9d338957d438427d62b4fef48795":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-09-06 22:22:44.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/38/1938/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/38/1938/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/38/1938/3"}}},"commit":{"parents":[{"commit":"2ca20da43faf90bf301ea5d2cbaaae62305b395c","subject":"chore(tvix): dontStrip tvix build","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2ca20da43faf90bf301ea5d2cbaaae62305b395c"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:10:53.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:22:39.000000000","tz":-240},"subject":"refactor(tvix): Limit to only 1 thread","message":"refactor(tvix): Limit to only 1 thread\n\nSince upstream nix forks a process per connection, there\u0027s a bunch of\nglobal, static builder state that is not properly locked or made\nthread-local that is causing problems with having more than one builder.\nIn this particular case, there\u0027s a global static flag for whether we\u0027re\ncurrently building something to prevent accidental recursive builds\nthat *aborts* (:0) in the case that the invariant is broken - obviously\nwe\u0027d like to get rid of that at some point, but in the meantime to get\nus to a point where tvix is actually usable let\u0027s just limit to 1 thread\nat a time. This will cause a bit of a perf hit, but it will hopefully\nget us closer to self-hosting.\n\nFixes: b/61\nChange-Id: Ic8460276769491b287e6b594984baae3b66beaa8\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dca4cc4dbcd8c9d338957d438427d62b4fef48795"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dca4cc4dbcd8c9d338957d438427d62b4fef48795"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2ca20da43faf90bf301ea5d2cbaaae62305b395c","is_merged_in_target_branch":true,"change_id":"Ib816a2a98bf3b8afa6e8b255a74ccb93af6508c5","change_number":1937,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"fa915c2d5f98a16fb67b57b3286ed6da853a9610":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2020-09-06 22:24:08.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/38/1938/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/38/1938/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/38/1938/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/38/1938/4"}}},"commit":{"parents":[{"commit":"2ca20da43faf90bf301ea5d2cbaaae62305b395c","subject":"chore(tvix): dontStrip tvix build","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2ca20da43faf90bf301ea5d2cbaaae62305b395c"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:10:53.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-09-06 22:23:57.000000000","tz":-240},"subject":"refactor(tvix): Limit to only 1 thread","message":"refactor(tvix): Limit to only 1 thread\n\nSince upstream nix forks a process per connection, there\u0027s a bunch of\nglobal, static builder state that is not properly locked or made\nthread-local that is causing problems with having more than one builder.\nIn this particular case, there\u0027s a global static flag for whether we\u0027re\ncurrently building something to prevent accidental recursive builds\nthat *aborts* (:0) in the case that the invariant is broken - obviously\nwe\u0027d like to get rid of that at some point, but in the meantime to get\nus to a point where tvix is actually usable let\u0027s just limit to 1 thread\nat a time. This will cause a bit of a perf hit, but it will hopefully\nget us closer to self-hosting.\n\nFixes: b/58\nChange-Id: Ic8460276769491b287e6b594984baae3b66beaa8\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa915c2d5f98a16fb67b57b3286ed6da853a9610"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa915c2d5f98a16fb67b57b3286ed6da853a9610"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2ca20da43faf90bf301ea5d2cbaaae62305b395c","is_merged_in_target_branch":true,"change_id":"Ib816a2a98bf3b8afa6e8b255a74ccb93af6508c5","change_number":1937,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[],"submit_requirements":[]}