)]}'
{"id":"depot~2172","triplet_id":"depot~canon~I70d00f0c7cb8f8cf2f744f58974c21e7a70a715b","project":"depot","branch":"canon","topic":"tvix","attention_set":{},"removed_from_attention_set":{"1000002":{"account":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"last_update":"2020-11-27 20:04:03.000000000","reason":"manually removed in reply dialog"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-11-27 20:08:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I70d00f0c7cb8f8cf2f744f58974c21e7a70a715b","subject":"fix(txix): Override overflow in BuildLogStreambuf","status":"MERGED","created":"2020-11-27 19:54:26.000000000","updated":"2020-11-27 20:12:04.000000000","submitted":"2020-11-27 20:08:45.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2172-tvix","meta_rev_id":"5a512b7016c8db9a370195d62425c55c76765c37","_number":2172,"virtual_id_number":2172,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-11-27 20:08:45.000000000","_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-11-27 20:08:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-27 19:55:33.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"state":"REVIEWER"},{"updated":"2020-11-27 19:58:14.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e9c20ef3057125328b4f33fa39888bbef24f99f6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 19:54:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f8c666430a3990da754894cb39a6218de19897d","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 19:55:48.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":1},{"id":"c0957f69e0b54a1c492fc86b0891d4f8994bd3b1","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-11-27 19:58:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/3913","accounts_in_message":[],"_revision_number":1},{"id":"85c474817b51fa47fabe3dee36be414477538c92","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-11-27 20:04:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e0b594a70cae41c625f3e3869c75008c8abcf3c1","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-11-27 20:04:15.000000000","message":"Patch Set 1:\n\ngood pairing session","accounts_in_message":[],"_revision_number":1},{"id":"1c5e7cf8ebd48d6299464c823836d84d8877e234","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 20:05:15.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"ec298a7c0fc739f671c05e29eacc3b6589d853ab","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-11-27 20:08:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/3920","accounts_in_message":[],"_revision_number":2},{"id":"2521590f4059c7f47a10c06468ef4fa914929624","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 20:08:45.000000000","message":"Change has been successfully rebased and submitted as 39f96c4d9f5799aad1c064ef80c6fb1aed45f4e3","accounts_in_message":[],"_revision_number":3},{"id":"5a512b7016c8db9a370195d62425c55c76765c37","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-11-27 20:12:04.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/3923","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"39f96c4d9f5799aad1c064ef80c6fb1aed45f4e3","revisions":{"57aabda18d38c7c1075a5a8bf6a5957c702e3320":{"kind":"REWORK","_number":1,"created":"2020-11-27 19:54:26.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/72/2172/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/2172/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/2172/1"}}},"commit":{"parents":[{"commit":"65b7635d7cf9b19741baa00c6324cb230beb8736","subject":"fix(tvix): Remove more superfluous log output","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d65b7635d7cf9b19741baa00c6324cb230beb8736"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 19:49:57.000000000","tz":-300},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 19:54:23.000000000","tz":-300},"subject":"fix(txix): Override overflow in BuildLogStreambuf","message":"fix(txix): Override overflow in BuildLogStreambuf\n\nSubclasses of std::streambuf are expected to override overflow in\naddition to xsputn, as it\u0027s called in certain cases by the non-virtual\nmethods. In our case, this was preventing endlines from getting sent\nover the log stream.\n\nChange-Id: I70d00f0c7cb8f8cf2f744f58974c21e7a70a715b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d57aabda18d38c7c1075a5a8bf6a5957c702e3320"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d57aabda18d38c7c1075a5a8bf6a5957c702e3320"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"65b7635d7cf9b19741baa00c6324cb230beb8736","is_merged_in_target_branch":false,"change_id":"Ib4b514a18fcb63c7191f4d7cf0a9b857aaa3f3fa","change_number":2171,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"56eba0a3d1d1d1d8869e7cf25875e06598e384c6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-11-27 20:05:15.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/72/2172/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/2172/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/2172/2"}}},"commit":{"parents":[{"commit":"db5290358104764155c53235394a07608d7fcf75","subject":"feat(tvix): Bump nlohmann-json version to 3.9.1","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddb5290358104764155c53235394a07608d7fcf75"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 19:49:57.000000000","tz":-300},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-11-27 20:05:15.000000000","tz":0},"subject":"fix(txix): Override overflow in BuildLogStreambuf","message":"fix(txix): Override overflow in BuildLogStreambuf\n\nSubclasses of std::streambuf are expected to override overflow in\naddition to xsputn, as it\u0027s called in certain cases by the non-virtual\nmethods. In our case, this was preventing endlines from getting sent\nover the log stream.\n\nChange-Id: I70d00f0c7cb8f8cf2f744f58974c21e7a70a715b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d56eba0a3d1d1d1d8869e7cf25875e06598e384c6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d56eba0a3d1d1d1d8869e7cf25875e06598e384c6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"db5290358104764155c53235394a07608d7fcf75","is_merged_in_target_branch":true,"change_id":"Iefde47ff6f24d21e9b37c9b52a615bd8c9f2fdb2","change_number":2141,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"39f96c4d9f5799aad1c064ef80c6fb1aed45f4e3":{"kind":"REWORK","_number":3,"created":"2020-11-27 20:08:45.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/72/2172/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/2172/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/2172/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/2172/3"}}},"commit":{"parents":[{"commit":"afdf08ead56370efabd6e9e9e154fe013a428419","subject":"fix(tvix): Remove more superfluous log output","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dafdf08ead56370efabd6e9e9e154fe013a428419"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 19:49:57.000000000","tz":-300},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-11-27 20:08:45.000000000","tz":0},"subject":"fix(txix): Override overflow in BuildLogStreambuf","message":"fix(txix): Override overflow in BuildLogStreambuf\n\nSubclasses of std::streambuf are expected to override overflow in\naddition to xsputn, as it\u0027s called in certain cases by the non-virtual\nmethods. In our case, this was preventing endlines from getting sent\nover the log stream.\n\nChange-Id: I70d00f0c7cb8f8cf2f744f58974c21e7a70a715b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2172\nTested-by: BuildkiteCI\nReviewed-by: kanepyork \u003crikingcoding@gmail.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d39f96c4d9f5799aad1c064ef80c6fb1aed45f4e3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d39f96c4d9f5799aad1c064ef80c6fb1aed45f4e3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"afdf08ead56370efabd6e9e9e154fe013a428419","is_merged_in_target_branch":true,"change_id":"Ib4b514a18fcb63c7191f4d7cf0a9b857aaa3f3fa","change_number":2171,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}