)]}'
{"id":"depot~2175","triplet_id":"depot~canon~If9aa96de2cd8ab941c098a9f122b8b302a92ec38","project":"depot","branch":"canon","topic":"tvix","attention_set":{},"removed_from_attention_set":{"1000002":{"account":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"last_update":"2020-11-27 21:28:22.000000000","reason":"manually removed in reply dialog"},"1000004":{"account":{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},"last_update":"2020-11-27 21:28:40.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2020-11-27 21:28:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If9aa96de2cd8ab941c098a9f122b8b302a92ec38","subject":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder","status":"MERGED","created":"2020-11-27 21:25:12.000000000","updated":"2021-03-15 14:01:32.000000000","submitted":"2020-11-27 21:28:40.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2175","meta_rev_id":"b8b8476c9ece076d3cdb31b8d7d09416e0166d73","_number":2175,"virtual_id_number":2175,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-11-27 21:28:40.000000000","_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-11-27 21:28:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-27 21:25:56.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},"state":"REVIEWER"},{"updated":"2020-11-27 21:25:56.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"state":"REVIEWER"},{"updated":"2020-11-27 21:28:14.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d7f3b835e2102c81766e6503aebec02fbd88ce39","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 21:25:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b0650de2378513c8a7e27e6a0bd5cf86d165e6c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 21:25:45.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1c1961bbc5553778db02e982335bca99a361b9b6","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-11-27 21:28:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/3939","accounts_in_message":[],"_revision_number":1},{"id":"d3e979ec6fd00999b572332780b86fe6a6416fe0","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-11-27 21:28:15.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/3940","accounts_in_message":[],"_revision_number":2},{"id":"f496c6d44b6c6493f5b4e2dec54200e2fda9f932","author":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"},"date":"2020-11-27 21:28:22.000000000","message":"Patch Set 2: Code-Review+2\n\nSeems correct to me, based on investigation","accounts_in_message":[],"_revision_number":2},{"id":"ba1c237b482ced88a7c2f9494b9a4cfe5d9b9c64","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-11-27 21:28:40.000000000","message":"Change has been successfully rebased and submitted as 1d22874ab29f696c38146750bdd26645d4d75ccc","accounts_in_message":[],"_revision_number":3},{"id":"37c934ac9b0493bc53f3f21daddae12f04e91f84","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-11-27 21:31:56.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/3941","accounts_in_message":[],"_revision_number":3},{"id":"b8b8476c9ece076d3cdb31b8d7d09416e0166d73","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-15 14:01:32.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1d22874ab29f696c38146750bdd26645d4d75ccc","revisions":{"6f26f32b0fb8d46896a9e7daea4455541bf4dda9":{"kind":"REWORK","_number":1,"created":"2020-11-27 21:25:12.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/75/2175/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/75/2175/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/75/2175/1"}}},"commit":{"parents":[{"commit":"5c3d58bb60c846f503d10af7fc5ba6e9f42fbae9","subject":"refactor(tvix): Prefer absl::StrFormat/StrAppend","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5c3d58bb60c846f503d10af7fc5ba6e9f42fbae9"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 21:24:08.000000000","tz":-300},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 21:24:08.000000000","tz":-300},"subject":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder","message":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder\n\nUpstream doesn\u0027t, and for good reason - this might not be a store path,\nfor example if it\u0027s /bin/sh\n\nChange-Id: If9aa96de2cd8ab941c098a9f122b8b302a92ec38\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f26f32b0fb8d46896a9e7daea4455541bf4dda9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f26f32b0fb8d46896a9e7daea4455541bf4dda9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5c3d58bb60c846f503d10af7fc5ba6e9f42fbae9","is_merged_in_target_branch":true,"change_id":"I2a3b1006c285170ab3374d1c8d81fc53e82a7b05","change_number":2174,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f961b0f7cf4ce9c3b20244bb29e0446493290dad":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-11-27 21:25:45.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/75/2175/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/75/2175/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/75/2175/2"}}},"commit":{"parents":[{"commit":"5c3d58bb60c846f503d10af7fc5ba6e9f42fbae9","subject":"refactor(tvix): Prefer absl::StrFormat/StrAppend","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5c3d58bb60c846f503d10af7fc5ba6e9f42fbae9"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 21:24:08.000000000","tz":-300},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 21:25:27.000000000","tz":-300},"subject":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder","message":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder\n\nUpstream doesn\u0027t, and for good reason - this might not be a store path,\nfor example if it\u0027s /bin/sh\n\nFixes: b/73\nChange-Id: If9aa96de2cd8ab941c098a9f122b8b302a92ec38\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df961b0f7cf4ce9c3b20244bb29e0446493290dad"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df961b0f7cf4ce9c3b20244bb29e0446493290dad"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5c3d58bb60c846f503d10af7fc5ba6e9f42fbae9","is_merged_in_target_branch":true,"change_id":"I2a3b1006c285170ab3374d1c8d81fc53e82a7b05","change_number":2174,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1d22874ab29f696c38146750bdd26645d4d75ccc":{"kind":"REWORK","_number":3,"created":"2020-11-27 21:28:40.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/75/2175/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/75/2175/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/75/2175/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/75/2175/3"}}},"commit":{"parents":[{"commit":"c885bd0274ba878d336e440651994c5d265c54dd","subject":"fix(tvix): globally reintroduce --quiet and --verbose flags.","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc885bd0274ba878d336e440651994c5d265c54dd"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-11-27 21:24:08.000000000","tz":-300},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-11-27 21:28:40.000000000","tz":0},"subject":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder","message":"fix(tvix): Don\u0027t call assertStorePath on BasicDerivation.builder\n\nUpstream doesn\u0027t, and for good reason - this might not be a store path,\nfor example if it\u0027s /bin/sh\n\nFixes: b/73\nChange-Id: If9aa96de2cd8ab941c098a9f122b8b302a92ec38\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2175\nReviewed-by: kanepyork \u003crikingcoding@gmail.com\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1d22874ab29f696c38146750bdd26645d4d75ccc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1d22874ab29f696c38146750bdd26645d4d75ccc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c885bd0274ba878d336e440651994c5d265c54dd","is_merged_in_target_branch":true,"change_id":"I13d860ebbb78541d9f1236691a1efe8bd2163c67","change_number":2170,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"kanepyork","email":"rikingcoding@gmail.com","username":"riking"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}