)]}'
{"id":"depot~2419","triplet_id":"depot~canon~I35caaaab70a5578c47cedc7f33077dd513766290","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-01-18 23:18:55.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-01-18 21:03:56.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I35caaaab70a5578c47cedc7f33077dd513766290","subject":"feat(todolist): use static slapd user data for knownUsers","status":"MERGED","created":"2021-01-18 11:14:27.000000000","updated":"2021-01-18 23:19:59.000000000","submitted":"2021-01-18 23:18:55.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2419","meta_rev_id":"e541b66bd982c7b839480b717b19f684bf826f00","_number":2419,"virtual_id_number":2419,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-01-18 23:18:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-01-18 23:18:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-18 11:14:44.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2021-01-18 11:15:26.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a8f3d70d3f9cbba5efa4a59b468d490149699741","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-18 11:14:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"635be2ea6f7b3d9ea5ac29a1b31da6f85a76a73c","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-18 11:15:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/4718","accounts_in_message":[],"_revision_number":1},{"id":"bfae68f8c3a588e371b0cb96d8aac6ca77a7d991","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-01-18 11:18:48.000000000","message":"Patch Set 1:\n\nIf you move the user list to a separate folder, e.g. somewhere under //ops, then it is read by readTree and just becomes available in the depot tree. That might be preferable?","accounts_in_message":[],"_revision_number":1},{"id":"a13dcbdf4d1ab8054185097e6e268c58f4eac1e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-18 11:32:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0f58e8087be468c89e96eec770fe539a5b830178","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-18 11:33:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/4719","accounts_in_message":[],"_revision_number":2},{"id":"ec4f9969f64feb9359433fe07b25351842d2e1a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-18 19:10:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dc66ac1dce745e32d35a667db07cb9a0647483b2","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-18 19:11:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/4720","accounts_in_message":[],"_revision_number":3},{"id":"4ccdc56d95b28225e1ecef547c4396e4f958386f","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-01-18 21:03:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ebf099b66d54402331a4073013087cf9000fd4f4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-18 23:18:55.000000000","message":"Change has been successfully rebased and submitted as 2d136e03279e481021a23948fdf5556f25394cd3","accounts_in_message":[],"_revision_number":4},{"id":"e541b66bd982c7b839480b717b19f684bf826f00","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-18 23:19:59.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/4721","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2d136e03279e481021a23948fdf5556f25394cd3","revisions":{"98c089ad89e27c5966ae8384778149945cab04a4":{"kind":"REWORK","_number":1,"created":"2021-01-18 11:14:27.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/2419/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/2419/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/2419/1"}}},"commit":{"parents":[{"commit":"c033229a6141f11a8df492532f3dcdde4fe57939","subject":"chore(ops/whitby): Move ACME registrations to an @tvl.fyi address","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc033229a6141f11a8df492532f3dcdde4fe57939"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 11:10:33.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 11:10:33.000000000","tz":60},"subject":"feat(todolist): use static slapd user data for knownUsers","message":"feat(todolist): use static slapd user data for knownUsers\n\nTo access the slapd data we simply utilize the data used to generate its\nstatic LDIF data which is checked into depot. This requires moving the\nusers list out of ops/nixos/tvl-slapd/default.nix into a separate nix\nexpression, so we can conveniently import it without evaluating a\nhypothetical nixos configuration module.\n\nOne question is if maybe ops/nixos/tvl-slapd/users.nix should be moved\nto a more apt location as it is essentially a general purpose user\nregistry in depot with this change.\n\nChange-Id: I35caaaab70a5578c47cedc7f33077dd513766290\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d98c089ad89e27c5966ae8384778149945cab04a4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d98c089ad89e27c5966ae8384778149945cab04a4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c033229a6141f11a8df492532f3dcdde4fe57939","is_merged_in_target_branch":true,"change_id":"I371550aa456c0fb64da4789feed494cc50497522","change_number":2410,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f9be3066454146c829ea33a7d3948e2c44e95cf5":{"kind":"REWORK","_number":2,"created":"2021-01-18 11:32:59.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/2419/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/2419/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/2419/2"}}},"commit":{"parents":[{"commit":"c033229a6141f11a8df492532f3dcdde4fe57939","subject":"chore(ops/whitby): Move ACME registrations to an @tvl.fyi address","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc033229a6141f11a8df492532f3dcdde4fe57939"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 11:10:33.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 11:30:43.000000000","tz":60},"subject":"feat(todolist): use static slapd user data for knownUsers","message":"feat(todolist): use static slapd user data for knownUsers\n\nSince the slapd data is static and generated using nix, we can simply\nmove the user list into ops/users, so it\u0027s recognized by readTree and we\ncan use it as ops.users both in ops/nixos/tvl-slapd and web/todolist as\na general purpose user registry for depot.\n\nChange-Id: I35caaaab70a5578c47cedc7f33077dd513766290\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df9be3066454146c829ea33a7d3948e2c44e95cf5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df9be3066454146c829ea33a7d3948e2c44e95cf5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c033229a6141f11a8df492532f3dcdde4fe57939","is_merged_in_target_branch":true,"change_id":"I371550aa456c0fb64da4789feed494cc50497522","change_number":2410,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9bb73b49afbce5c6d667bc9465726ed1d6ea3038":{"kind":"REWORK","_number":3,"created":"2021-01-18 19:10:53.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/2419/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/2419/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/2419/3"}}},"commit":{"parents":[{"commit":"c033229a6141f11a8df492532f3dcdde4fe57939","subject":"chore(ops/whitby): Move ACME registrations to an @tvl.fyi address","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc033229a6141f11a8df492532f3dcdde4fe57939"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 11:10:33.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 19:10:39.000000000","tz":60},"subject":"feat(todolist): use static slapd user data for knownUsers","message":"feat(todolist): use static slapd user data for knownUsers\n\nSince the slapd data is static and generated using nix, we can simply\nmove the user list into ops/users, so it\u0027s recognized by readTree and we\ncan use it as ops.users both in ops/nixos/tvl-slapd and web/todolist as\na general purpose user registry for depot.\n\nUpdate docs/REVIEWS.md as well.\n\nChange-Id: I35caaaab70a5578c47cedc7f33077dd513766290\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9bb73b49afbce5c6d667bc9465726ed1d6ea3038"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9bb73b49afbce5c6d667bc9465726ed1d6ea3038"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c033229a6141f11a8df492532f3dcdde4fe57939","is_merged_in_target_branch":true,"change_id":"I371550aa456c0fb64da4789feed494cc50497522","change_number":2410,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2d136e03279e481021a23948fdf5556f25394cd3":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-01-18 23:18:55.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/2419/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/2419/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/2419/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/2419/4"}}},"commit":{"parents":[{"commit":"c033229a6141f11a8df492532f3dcdde4fe57939","subject":"chore(ops/whitby): Move ACME registrations to an @tvl.fyi address","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc033229a6141f11a8df492532f3dcdde4fe57939"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 11:10:33.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-18 23:18:55.000000000","tz":0},"subject":"feat(todolist): use static slapd user data for knownUsers","message":"feat(todolist): use static slapd user data for knownUsers\n\nSince the slapd data is static and generated using nix, we can simply\nmove the user list into ops/users, so it\u0027s recognized by readTree and we\ncan use it as ops.users both in ops/nixos/tvl-slapd and web/todolist as\na general purpose user registry for depot.\n\nUpdate docs/REVIEWS.md as well.\n\nChange-Id: I35caaaab70a5578c47cedc7f33077dd513766290\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2419\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d136e03279e481021a23948fdf5556f25394cd3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d136e03279e481021a23948fdf5556f25394cd3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c033229a6141f11a8df492532f3dcdde4fe57939","is_merged_in_target_branch":true,"change_id":"I371550aa456c0fb64da4789feed494cc50497522","change_number":2410,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}