)]}'
{"id":"depot~2443","triplet_id":"depot~canon~Ic21d2e3e6ac0c6e1f045bf2c9d3e9c5af446fcff","project":"depot","branch":"canon","hashtags":[],"change_id":"Ic21d2e3e6ac0c6e1f045bf2c9d3e9c5af446fcff","subject":"fix(users/Profpatsch/netencode): remove Boxes in AST struct","status":"MERGED","created":"2021-01-26 10:28:35.000000000","updated":"2021-01-27 13:42:20.000000000","submitted":"2021-01-27 13:41:18.000000000","submitter":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2447","meta_rev_id":"d49df480f678fd124dc4db10090411401848d571","_number":2443,"virtual_id_number":2443,"owner":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-01-27 13:41:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-01-27 13:41:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-26 10:29:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d7d3f30f747397e8317a3916588639087fa4ae55","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-01-26 10:28:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1aeab8892223db95724eca329e48f88a9d6fe53","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-26 10:29:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/4779","accounts_in_message":[],"_revision_number":1},{"id":"4f90d5f2cbf1b3e7a80838c57529a8c7ced65333","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-01-26 12:21:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d9eb7556814de94dcb49796765d067cc4ae0f5b0","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-26 12:22:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/4782","accounts_in_message":[],"_revision_number":2},{"id":"d98ee70f403b13f74fe38694690e2235f4f377e9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-01-27 13:39:19.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"23dbcdd63d5f02386f704eb5eaf3de190c6ec3a1","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-01-27 13:39:40.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"56b5623b9ed25351d0a14eacf0e29ad98b74d4d9","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-27 13:40:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/4792","accounts_in_message":[],"_revision_number":3},{"id":"5b4bd5c2e2fb4e022002dde4225724d89d3368b3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-01-27 13:41:18.000000000","message":"Change has been successfully rebased and submitted as a044a870849d03b3a71df17e589112e0c228a06e","accounts_in_message":[],"_revision_number":4},{"id":"d49df480f678fd124dc4db10090411401848d571","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-27 13:42:20.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/4796","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"a044a870849d03b3a71df17e589112e0c228a06e","revisions":{"9580b2cfc1f545631b6f61e803da2317c4ec0470":{"kind":"REWORK","_number":1,"created":"2021-01-26 10:28:35.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/43/2443/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/43/2443/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/43/2443/1"}}},"commit":{"parents":[{"commit":"82d197282bee76c4ac25c4e1aa2fe84d1baca077","subject":"WIP feat(nix): add nix.rec","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d82d197282bee76c4ac25c4e1aa2fe84d1baca077"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-26 10:27:42.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-26 10:27:42.000000000","tz":60},"subject":"fix(users/Profpatsch/netencode): remove box inside HashMap","message":"fix(users/Profpatsch/netencode): remove box inside HashMap\n\nApparently HashMap already does internal boxing, so the extra\nindirection isn’t needed.\n\nChange-Id: Ic21d2e3e6ac0c6e1f045bf2c9d3e9c5af446fcff\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9580b2cfc1f545631b6f61e803da2317c4ec0470"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9580b2cfc1f545631b6f61e803da2317c4ec0470"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"82d197282bee76c4ac25c4e1aa2fe84d1baca077","is_merged_in_target_branch":false,"change_id":"I0f8c8d1cf16f654fc77fe07c0c032561b26bef2c","change_number":2435,"patch_set_number":1,"change_status":"NEW"}],"branch":"refs/heads/canon"},"adef8ade91dd0eb1a317665b83add89f7e7cf4e0":{"kind":"REWORK","_number":2,"created":"2021-01-26 12:21:03.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/43/2443/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/43/2443/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/43/2443/2"}}},"commit":{"parents":[{"commit":"82d197282bee76c4ac25c4e1aa2fe84d1baca077","subject":"WIP feat(nix): add nix.rec","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d82d197282bee76c4ac25c4e1aa2fe84d1baca077"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-26 10:27:42.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-26 12:19:45.000000000","tz":60},"subject":"fix(users/Profpatsch/netencode): remove Boxes in AST struct","message":"fix(users/Profpatsch/netencode): remove Boxes in AST struct\n\nApparently HashMap and Vec already do internal boxing, so the extra\nindirection in the value isn’t needed.\n\nThen, in order to make things uniform, move the boxing of `Sum` into\nthe `Tag` value. No extra boxing in the recursion! \\o/\n\nChange-Id: Ic21d2e3e6ac0c6e1f045bf2c9d3e9c5af446fcff\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dadef8ade91dd0eb1a317665b83add89f7e7cf4e0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dadef8ade91dd0eb1a317665b83add89f7e7cf4e0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"82d197282bee76c4ac25c4e1aa2fe84d1baca077","is_merged_in_target_branch":false,"change_id":"I0f8c8d1cf16f654fc77fe07c0c032561b26bef2c","change_number":2435,"patch_set_number":1,"change_status":"NEW"}],"branch":"refs/heads/canon"},"c0232631de54d1db89a15eed9a2594af371cc7b5":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-01-27 13:39:19.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/43/2443/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/43/2443/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/43/2443/3"}}},"commit":{"parents":[{"commit":"83465be599f2ed8d55dae0262156869fb78240a1","subject":"feat(3p/telega): Pin tdlib version used for telega","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d83465be599f2ed8d55dae0262156869fb78240a1"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-26 10:27:42.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-27 13:38:55.000000000","tz":60},"subject":"fix(users/Profpatsch/netencode): remove Boxes in AST struct","message":"fix(users/Profpatsch/netencode): remove Boxes in AST struct\n\nApparently HashMap and Vec already do internal boxing, so the extra\nindirection in the value isn’t needed.\n\nThen, in order to make things uniform, move the boxing of `Sum` into\nthe `Tag` value. No extra boxing in the recursion! \\o/\n\nChange-Id: Ic21d2e3e6ac0c6e1f045bf2c9d3e9c5af446fcff\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc0232631de54d1db89a15eed9a2594af371cc7b5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc0232631de54d1db89a15eed9a2594af371cc7b5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"83465be599f2ed8d55dae0262156869fb78240a1","is_merged_in_target_branch":true,"change_id":"I9c994f783e1cc17e933432507cd13b65697efd4a","change_number":2445,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a044a870849d03b3a71df17e589112e0c228a06e":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-01-27 13:41:18.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/43/2443/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/43/2443/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/43/2443/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/43/2443/4"}}},"commit":{"parents":[{"commit":"83465be599f2ed8d55dae0262156869fb78240a1","subject":"feat(3p/telega): Pin tdlib version used for telega","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d83465be599f2ed8d55dae0262156869fb78240a1"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-26 10:27:42.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-01-27 13:41:18.000000000","tz":0},"subject":"fix(users/Profpatsch/netencode): remove Boxes in AST struct","message":"fix(users/Profpatsch/netencode): remove Boxes in AST struct\n\nApparently HashMap and Vec already do internal boxing, so the extra\nindirection in the value isn’t needed.\n\nThen, in order to make things uniform, move the boxing of `Sum` into\nthe `Tag` value. No extra boxing in the recursion! \\o/\n\nChange-Id: Ic21d2e3e6ac0c6e1f045bf2c9d3e9c5af446fcff\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2443\nReviewed-by: Profpatsch \u003cmail@profpatsch.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da044a870849d03b3a71df17e589112e0c228a06e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da044a870849d03b3a71df17e589112e0c228a06e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"83465be599f2ed8d55dae0262156869fb78240a1","is_merged_in_target_branch":true,"change_id":"I9c994f783e1cc17e933432507cd13b65697efd4a","change_number":2445,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}