)]}'
{"id":"depot~2448","triplet_id":"depot~canon~I0a84eb0631c4a49f1664bed6d03afa60dce6eb47","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-01-29 17:18:06.000000000","reason":"sterni replied on the change"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-01-29 17:38:41.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2021-01-29 16:10:42.000000000","reason":"glittershark replied on the change"}},"hashtags":[],"change_id":"I0a84eb0631c4a49f1664bed6d03afa60dce6eb47","subject":"fix(panettone): handle missing DNs when looking up displaynames","status":"MERGED","created":"2021-01-29 11:27:34.000000000","updated":"2021-01-29 17:40:06.000000000","submitted":"2021-01-29 17:38:41.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2448","meta_rev_id":"0916d147e00bc0db18e9ed0be0cd72bbdc4bee3f","_number":2448,"virtual_id_number":2448,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-01-29 17:38:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-01-29 17:38:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-29 11:28:01.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2021-01-29 11:28:01.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2021-01-29 11:28:37.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"65de95e41589b5f561b35765a659e06e149a49ae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 11:27:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d9889d068e57eb7ad343a9611d41ff5bd9366b4","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-29 11:28:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/4801","accounts_in_message":[],"_revision_number":1},{"id":"d7980ae17b942e0b4bfd3ad8b8ebd6d52b0b22e8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 11:28:49.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e533b68928561afa1794c115fd01af79e8ac6228","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-29 11:29:50.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/4802","accounts_in_message":[],"_revision_number":2},{"id":"f1fd198b040856e90637a81daf0a341e511dfaa3","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-01-29 13:11:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c003a89020ac669a2ce81b1cd708faf7e64f28a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 13:26:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"728507b3b1821ced0a982c784854673f5b3db503","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-29 13:27:18.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/4803","accounts_in_message":[],"_revision_number":3},{"id":"d3575bb9abdc5cb3f18188b46138b924d5b75bfb","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 13:33:01.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"20d45bfa46bfb7f362dd062f1d4bf33b4723716c","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-01-29 16:10:42.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8dd4a9aa2360df19b5ec7bf646190ccb01e169d6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 17:17:27.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6107c7e76bde563222cf03a276f9ce2c6d1ac84b","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 17:18:06.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"019842b4dc295ca2ff8d0806830705976e612648","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-29 17:20:02.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/4826","accounts_in_message":[],"_revision_number":4},{"id":"28b153a3fe399d7f7fa2c6aaaaabae809be00704","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-01-29 17:38:41.000000000","message":"Change has been successfully rebased and submitted as 0176a9e300062ae2edf2f0ba2e365a8c2c4dbc99","accounts_in_message":[],"_revision_number":5},{"id":"0916d147e00bc0db18e9ed0be0cd72bbdc4bee3f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-01-29 17:40:06.000000000","message":"Patch Set 5:\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/4830","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"0176a9e300062ae2edf2f0ba2e365a8c2c4dbc99","revisions":{"60528d24adce84af5c78ea0a2c92fde627399d79":{"kind":"REWORK","_number":1,"created":"2021-01-29 11:27:34.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/48/2448/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/2448/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/2448/1"}}},"commit":{"parents":[{"commit":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","subject":"feat(users/Profpatsch): add read-http","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fb5a17f1430840da4990ffa35a04aca96f06d0a"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:22:40.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:22:40.000000000","tz":60},"subject":"fix(panettone): handle missing DNs when looking up an user\u0027s displayname","message":"fix(panettone): handle missing DNs when looking up an user\u0027s displayname\n\n* Fix find-user-by-dn raising an error condition if the search returns\n  no results, return nil instead.\n* Adopt strategy of defaulting to “someone” as displayname if lookup\n  fails for all usage of displaynames in panettone.\n\nI\u0027ve tested this change for issues and comments created by missing users.\nAdjusting the displayname seems to fix all 500 being created by missing\nusers both logged out and logged in.\n\nChange-Id: I0a84eb0631c4a49f1664bed6d03afa60dce6eb47\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d60528d24adce84af5c78ea0a2c92fde627399d79"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d60528d24adce84af5c78ea0a2c92fde627399d79"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","is_merged_in_target_branch":true,"change_id":"Ie99faa6d4bbd4996fa4e43fb119a11d85b611c99","change_number":2447,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"85b8b0992e17cd0d9b2f63e502b3ed5d8d182f7c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-01-29 11:28:49.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/48/2448/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/2448/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/2448/2"}}},"commit":{"parents":[{"commit":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","subject":"feat(users/Profpatsch): add read-http","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fb5a17f1430840da4990ffa35a04aca96f06d0a"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:22:40.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:28:15.000000000","tz":60},"subject":"fix(panettone): handle missing DNs when looking up displaynames","message":"fix(panettone): handle missing DNs when looking up displaynames\n\n* Fix find-user-by-dn raising an error condition if the search returns\n  no results, return nil instead.\n* Adopt strategy of defaulting to “someone” as displayname if lookup\n  fails for all usage of displaynames in panettone.\n\nI\u0027ve tested this change for issues and comments created by missing\nusers. Adjusting the displayname seems to fix all 500 being created\nby missing users both logged out and logged in.\n\nChange-Id: I0a84eb0631c4a49f1664bed6d03afa60dce6eb47\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d85b8b0992e17cd0d9b2f63e502b3ed5d8d182f7c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d85b8b0992e17cd0d9b2f63e502b3ed5d8d182f7c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","is_merged_in_target_branch":true,"change_id":"Ie99faa6d4bbd4996fa4e43fb119a11d85b611c99","change_number":2447,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d5836c84a264a9366da099716199ba3af8178298":{"kind":"REWORK","_number":3,"created":"2021-01-29 13:26:19.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/48/2448/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/2448/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/2448/3"}}},"commit":{"parents":[{"commit":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","subject":"feat(users/Profpatsch): add read-http","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fb5a17f1430840da4990ffa35a04aca96f06d0a"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:22:40.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 13:26:14.000000000","tz":60},"subject":"fix(panettone): handle missing DNs when looking up displaynames","message":"fix(panettone): handle missing DNs when looking up displaynames\n\n* Fix find-user-by-dn raising an error condition if the search returns\n  no results, return nil instead.\n* Adopt strategy of defaulting to “someone” as displayname if lookup\n  fails for all usage of displaynames in panettone.\n\nI\u0027ve tested this change for issues and comments created by missing\nusers. Adjusting the displayname seems to fix all 500 being created\nby missing users both logged out and logged in.\n\nChange-Id: I0a84eb0631c4a49f1664bed6d03afa60dce6eb47\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5836c84a264a9366da099716199ba3af8178298"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5836c84a264a9366da099716199ba3af8178298"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","is_merged_in_target_branch":true,"change_id":"Ie99faa6d4bbd4996fa4e43fb119a11d85b611c99","change_number":2447,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1cf97f0c1f85892af8be682dad684723241dfa33":{"kind":"REWORK","_number":4,"created":"2021-01-29 17:17:27.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/48/2448/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/2448/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/2448/4"}}},"commit":{"parents":[{"commit":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","subject":"feat(users/Profpatsch): add read-http","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fb5a17f1430840da4990ffa35a04aca96f06d0a"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:22:40.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 17:17:23.000000000","tz":60},"subject":"fix(panettone): handle missing DNs when looking up displaynames","message":"fix(panettone): handle missing DNs when looking up displaynames\n\n* Fix find-user-by-dn raising an error condition if the search returns\n  no results, return nil instead.\n* Adopt strategy of defaulting to “someone” as displayname if lookup\n  fails for all usage of displaynames in panettone.\n\nI\u0027ve tested this change for issues and comments created by missing\nusers. Adjusting the displayname seems to fix all 500 being created\nby missing users both logged out and logged in.\n\nChange-Id: I0a84eb0631c4a49f1664bed6d03afa60dce6eb47\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1cf97f0c1f85892af8be682dad684723241dfa33"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1cf97f0c1f85892af8be682dad684723241dfa33"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1fb5a17f1430840da4990ffa35a04aca96f06d0a","is_merged_in_target_branch":true,"change_id":"Ie99faa6d4bbd4996fa4e43fb119a11d85b611c99","change_number":2447,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0176a9e300062ae2edf2f0ba2e365a8c2c4dbc99":{"kind":"REWORK","_number":5,"created":"2021-01-29 17:38:41.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/48/2448/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/2448/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/2448/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/2448/5"}}},"commit":{"parents":[{"commit":"001ee91169c4e25bd3696fc3c69e5151f5547a7f","subject":"feat(users/sterni): move clhs.clhs-lookup to clhs-lookup","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d001ee91169c4e25bd3696fc3c69e5151f5547a7f"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 11:22:40.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-01-29 17:38:41.000000000","tz":0},"subject":"fix(panettone): handle missing DNs when looking up displaynames","message":"fix(panettone): handle missing DNs when looking up displaynames\n\n* Fix find-user-by-dn raising an error condition if the search returns\n  no results, return nil instead.\n* Adopt strategy of defaulting to “someone” as displayname if lookup\n  fails for all usage of displaynames in panettone.\n\nI\u0027ve tested this change for issues and comments created by missing\nusers. Adjusting the displayname seems to fix all 500 being created\nby missing users both logged out and logged in.\n\nChange-Id: I0a84eb0631c4a49f1664bed6d03afa60dce6eb47\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2448\nTested-by: BuildkiteCI\nReviewed-by: glittershark \u003cgrfn@gws.fyi\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0176a9e300062ae2edf2f0ba2e365a8c2c4dbc99"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0176a9e300062ae2edf2f0ba2e365a8c2c4dbc99"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"001ee91169c4e25bd3696fc3c69e5151f5547a7f","is_merged_in_target_branch":true,"change_id":"I6c5aeba1b58ca650700c6efa0913e4b42685ea6b","change_number":2461,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}