)]}'
{"id":"depot~2488","triplet_id":"depot~canon~Ibc476e028102944a65c2b64621047086cfc09aa5","project":"depot","branch":"canon","hashtags":[],"change_id":"Ibc476e028102944a65c2b64621047086cfc09aa5","subject":"feat(users/Profpatsch/netencode): nest Us in U::List","status":"MERGED","created":"2021-02-06 19:36:33.000000000","updated":"2021-02-06 19:44:38.000000000","submitted":"2021-02-06 19:43:06.000000000","submitter":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2488","meta_rev_id":"cd7eabbb240c93826a9054e7dc11fb9230d08eeb","_number":2488,"virtual_id_number":2488,"owner":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-06 19:43:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-06 19:43:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-06 19:38:09.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5f3795ea9ed0962d793f2237bf9d15b38181aeae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-02-06 19:36:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0506457e46b6a2d872d50006b72ca8f50055d5db","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-02-06 19:37:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1d822f34d7baa6ebf7debab6c3e01dbd068560a6","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-06 19:38:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/4989","accounts_in_message":[],"_revision_number":1},{"id":"def26e2fc813df6ba5761dc9c8e895753e1be4e5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-02-06 19:43:06.000000000","message":"Change has been successfully rebased and submitted as 42974ddd6494097bf8a85a123b8637115977dda4","accounts_in_message":[],"_revision_number":2},{"id":"cd7eabbb240c93826a9054e7dc11fb9230d08eeb","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-06 19:44:38.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/4992","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"42974ddd6494097bf8a85a123b8637115977dda4","revisions":{"d55a3dabb23aab5ec7ccdb774dfee73609f03ef8":{"kind":"REWORK","_number":1,"created":"2021-02-06 19:36:33.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/88/2488/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/2488/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/2488/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/2488/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/2488/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/2488/1"}}},"commit":{"parents":[{"commit":"44f73730244c71f0b42fb1424c9f318e965f9a90","subject":"fix(users/Profpatsch/netencode): decode U::Text directly into str","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d44f73730244c71f0b42fb1424c9f318e965f9a90"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 19:31:56.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 19:36:31.000000000","tz":60},"subject":"feat(users/Profpatsch/netencode): nest Us in U::List","message":"feat(users/Profpatsch/netencode): nest Us in U::List\n\nEarlier we left the next level of values unencoded, since lists are\njust concatenated netencode values. But I noticed that you can’t write\ne.g. a `t_to_u` function, because only in the case of lists you need\nto allocate memory.\n\nTurns out that if we read the next level of values, everything is\nhandled the same as in `Record` and things suddenly start working.\n\nWe can also throw away some of the strange and ad-hoc parser helpers\nwe needed before, `skip` and `list_take`, since now those are just\nnormal `Vec::iter().skip()` and take.\n\nChange-Id: Ibc476e028102944a65c2b64621047086cfc09aa5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd55a3dabb23aab5ec7ccdb774dfee73609f03ef8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd55a3dabb23aab5ec7ccdb774dfee73609f03ef8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"44f73730244c71f0b42fb1424c9f318e965f9a90","is_merged_in_target_branch":false,"change_id":"I36e4d228fbf35374d7c1addb4b24828cf6e927e5","change_number":2478,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"42974ddd6494097bf8a85a123b8637115977dda4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-06 19:43:06.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/88/2488/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/2488/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/2488/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/2488/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/2488/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/2488/2"}}},"commit":{"parents":[{"commit":"14f9a22f4641ea214af1513bc1f9ef12b1350cbe","subject":"fix(users/Profpatsch/netencode): decode U::Text directly into str","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d14f9a22f4641ea214af1513bc1f9ef12b1350cbe"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 19:31:56.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 19:43:06.000000000","tz":0},"subject":"feat(users/Profpatsch/netencode): nest Us in U::List","message":"feat(users/Profpatsch/netencode): nest Us in U::List\n\nEarlier we left the next level of values unencoded, since lists are\njust concatenated netencode values. But I noticed that you can’t write\ne.g. a `t_to_u` function, because only in the case of lists you need\nto allocate memory.\n\nTurns out that if we read the next level of values, everything is\nhandled the same as in `Record` and things suddenly start working.\n\nWe can also throw away some of the strange and ad-hoc parser helpers\nwe needed before, `skip` and `list_take`, since now those are just\nnormal `Vec::iter().skip()` and take.\n\nChange-Id: Ibc476e028102944a65c2b64621047086cfc09aa5\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2488\nReviewed-by: Profpatsch \u003cmail@profpatsch.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d42974ddd6494097bf8a85a123b8637115977dda4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d42974ddd6494097bf8a85a123b8637115977dda4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"14f9a22f4641ea214af1513bc1f9ef12b1350cbe","is_merged_in_target_branch":true,"change_id":"I36e4d228fbf35374d7c1addb4b24828cf6e927e5","change_number":2478,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}