)]}'
{"id":"depot~2490","triplet_id":"depot~canon~Ifd594916f76e5acf9d08e705e0dec2c10a0081c9","project":"depot","branch":"canon","hashtags":[],"change_id":"Ifd594916f76e5acf9d08e705e0dec2c10a0081c9","subject":"feat(users/Profpatsch/{netencode,http-parse}): use HashMap","status":"MERGED","created":"2021-02-06 21:37:09.000000000","updated":"2021-02-06 21:40:29.000000000","submitted":"2021-02-06 21:38:57.000000000","submitter":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2490","meta_rev_id":"c69bd5e2eef98215ab90c75ad2ca51265845667f","_number":2490,"virtual_id_number":2490,"owner":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-06 21:38:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-06 21:38:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-06 21:38:36.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fe91547effe5483297650eaf7e8f4378eaacea78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-02-06 21:37:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87a9629640142a2ec1fc3b3a1ff31250068b93ba","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-06 21:38:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/4997","accounts_in_message":[],"_revision_number":1},{"id":"15f2cf3a4508a5af796e75b97acf61ab8878617c","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-02-06 21:38:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0e6adb9020f98ffa6ceca378e88d0245c10250b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2021-02-06 21:38:57.000000000","message":"Change has been successfully rebased and submitted as e207785e1fc78d06381b369c3b71b7e6becdbf80","accounts_in_message":[],"_revision_number":2},{"id":"c69bd5e2eef98215ab90c75ad2ca51265845667f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-06 21:40:29.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5000","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e207785e1fc78d06381b369c3b71b7e6becdbf80","revisions":{"129b3edde319eaa6e8441981e60da1f3034e6581":{"kind":"REWORK","_number":1,"created":"2021-02-06 21:37:09.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/90/2490/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/2490/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/2490/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/2490/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/2490/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/2490/1"}}},"commit":{"parents":[{"commit":"3895095335dcd42e0b1369a887a1a8761f0040d2","subject":"fix(users/Profpatsch/execline): fix exec_into_args off-by-1","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3895095335dcd42e0b1369a887a1a8761f0040d2"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 21:33:39.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 21:37:07.000000000","tz":60},"subject":"feat(users/Profpatsch/{netencode,http-parse}): use HashMap","message":"feat(users/Profpatsch/{netencode,http-parse}): use HashMap\n\n`U::Record` is required to be a hash map (later keys should be\nignored), so why not do the hash map immediately.\n\nThis surfaced a problem with read-http, because duplicate headers in\nhttp are possible, but before they’d be silently ignored.\nNow we merge them into a `U::List` in case, to be handled by\nconsumers of read-http.\n\nChange-Id: Ifd594916f76e5acf9d08e705e0dec2c10a0081c9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d129b3edde319eaa6e8441981e60da1f3034e6581"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d129b3edde319eaa6e8441981e60da1f3034e6581"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3895095335dcd42e0b1369a887a1a8761f0040d2","is_merged_in_target_branch":false,"change_id":"I664f9f717e4f82bfc1b1da3bd7114124b7582d5f","change_number":2489,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e207785e1fc78d06381b369c3b71b7e6becdbf80":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-06 21:38:57.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/90/2490/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/2490/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/2490/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/2490/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/2490/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/2490/2"}}},"commit":{"parents":[{"commit":"7d28f121c7baba31f5bd731de8aff023fa23bdc0","subject":"fix(users/Profpatsch/execline): fix exec_into_args off-by-1","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7d28f121c7baba31f5bd731de8aff023fa23bdc0"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 21:33:39.000000000","tz":60},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2021-02-06 21:38:57.000000000","tz":0},"subject":"feat(users/Profpatsch/{netencode,http-parse}): use HashMap","message":"feat(users/Profpatsch/{netencode,http-parse}): use HashMap\n\n`U::Record` is required to be a hash map (later keys should be\nignored), so why not do the hash map immediately.\n\nThis surfaced a problem with read-http, because duplicate headers in\nhttp are possible, but before they’d be silently ignored.\nNow we merge them into a `U::List` in case, to be handled by\nconsumers of read-http.\n\nChange-Id: Ifd594916f76e5acf9d08e705e0dec2c10a0081c9\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2490\nTested-by: BuildkiteCI\nReviewed-by: Profpatsch \u003cmail@profpatsch.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de207785e1fc78d06381b369c3b71b7e6becdbf80"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de207785e1fc78d06381b369c3b71b7e6becdbf80"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7d28f121c7baba31f5bd731de8aff023fa23bdc0","is_merged_in_target_branch":true,"change_id":"I664f9f717e4f82bfc1b1da3bd7114124b7582d5f","change_number":2489,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}