)]}'
{"id":"depot~2535","triplet_id":"depot~canon~Ibf3be2bd189d48881c82ee795c50151bfb365627","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-02-18 00:07:14.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-02-17 23:08:26.000000000","reason":"tazjin replied on the change"},"1000013":{"account":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"last_update":"2021-02-18 00:07:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibf3be2bd189d48881c82ee795c50151bfb365627","subject":"fix(nix/readTree): make nixFileName only match .nix extensions","status":"MERGED","created":"2021-02-17 22:55:40.000000000","updated":"2021-02-18 00:08:24.000000000","submitted":"2021-02-18 00:07:14.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2535","meta_rev_id":"479efce22e1b47470996725df8204e510d09b91b","_number":2535,"virtual_id_number":2535,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-18 00:07:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-18 00:07:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-17 22:55:55.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2021-02-17 22:55:55.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"state":"REVIEWER"},{"updated":"2021-02-17 22:56:59.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"53ae40fbca565accc32a68046a95d18a76018321","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-02-17 22:55:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"23c17c066d871284859bae1d2e772877eb4da132","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-02-17 22:56:33.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bbd61cecde587ab8a4d7320f3a77ec701e4bc0ec","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-17 22:56:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5123","accounts_in_message":[],"_revision_number":1},{"id":"317746e53e845d0ec5bda1634af8e23787c2b92b","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-17 22:57:53.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5124","accounts_in_message":[],"_revision_number":2},{"id":"bd6e4161343e10cce922ba57e0272921ac1a6994","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-17 23:08:26.000000000","message":"Patch Set 2: Code-Review+2\n\nOof. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"f9a4e80ec2d6f9d7fd07731fa5115479c140f8f6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-02-18 00:07:14.000000000","message":"Change has been successfully rebased and submitted as 2469f0b423518ef4bee1641f04c3283bed374567","accounts_in_message":[],"_revision_number":3},{"id":"479efce22e1b47470996725df8204e510d09b91b","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-18 00:08:24.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/5125","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2469f0b423518ef4bee1641f04c3283bed374567","revisions":{"c326ebf758209e63dd8a9557122155e2bb729600":{"kind":"REWORK","_number":1,"created":"2021-02-17 22:55:40.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/35/2535/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/35/2535/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/35/2535/1"}}},"commit":{"parents":[{"commit":"fa99c128f806d5015b6f4c31585c78f76a5e07df","subject":"test(users/Profpatsch/writers): use testRustSimple on transitive lib","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa99c128f806d5015b6f4c31585c78f76a5e07df"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-02-17 22:48:54.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-02-17 22:48:54.000000000","tz":60},"subject":"fix(nix/readTree): make nixFileName only match .nix extensions","message":"fix(nix/readTree): make nixFileName only match .nix extensions\n\nNix unfortunately has terrible escaping semantics: If something is an\nescape sequence it does not know, like \\0, it just swallows the\nbackslash and returns the second character (byte) as is (yes,\n\"\\0\" \u003d\u003d \"0\" is true). This created the following bug in nixFileName\nwhich should have resulted in at least a parse error: \"(.*)\\.nix\" is\nthe same as \"(.*).nix\" which meant that nixFileName matched anything\nthat is at least 4 characters long and ends in \"nix\". This lead to\nreadTree creating double attributes when directories are involved or\nattributes for non-nix files.\n\nChange-Id: Ibf3be2bd189d48881c82ee795c50151bfb365627\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc326ebf758209e63dd8a9557122155e2bb729600"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc326ebf758209e63dd8a9557122155e2bb729600"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fa99c128f806d5015b6f4c31585c78f76a5e07df","is_merged_in_target_branch":true,"change_id":"Ia4ea7425432b8b0da09f63054f51f0c480300aa4","change_number":2531,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"fa9a923b3384f092f866671c1490ff2aa1aba971":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-17 22:56:33.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/35/2535/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/35/2535/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/35/2535/2"}}},"commit":{"parents":[{"commit":"fa99c128f806d5015b6f4c31585c78f76a5e07df","subject":"test(users/Profpatsch/writers): use testRustSimple on transitive lib","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa99c128f806d5015b6f4c31585c78f76a5e07df"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-02-17 22:48:54.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-02-17 22:56:22.000000000","tz":60},"subject":"fix(nix/readTree): make nixFileName only match .nix extensions","message":"fix(nix/readTree): make nixFileName only match .nix extensions\n\nNix unfortunately has terrible escaping syntax: If something is an\nescape sequence it does not know, like \\0, it just swallows the\nbackslash and returns the second character (byte) as is (yes,\n\"\\0\" \u003d\u003d \"0\" is true). This created the following bug in nixFileName\nwhich should have resulted in at least a parse error: \"(.*)\\.nix\" is\nthe same as \"(.*).nix\" which meant that nixFileName matched anything\nthat is at least 4 characters long and ends in \"nix\". This lead to\nreadTree creating double attributes when directories are involved or\nattributes for non-nix files.\n\nChange-Id: Ibf3be2bd189d48881c82ee795c50151bfb365627\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa9a923b3384f092f866671c1490ff2aa1aba971"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa9a923b3384f092f866671c1490ff2aa1aba971"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fa99c128f806d5015b6f4c31585c78f76a5e07df","is_merged_in_target_branch":true,"change_id":"Ia4ea7425432b8b0da09f63054f51f0c480300aa4","change_number":2531,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2469f0b423518ef4bee1641f04c3283bed374567":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-02-18 00:07:14.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/35/2535/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/35/2535/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/35/2535/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/35/2535/3"}}},"commit":{"parents":[{"commit":"fa99c128f806d5015b6f4c31585c78f76a5e07df","subject":"test(users/Profpatsch/writers): use testRustSimple on transitive lib","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfa99c128f806d5015b6f4c31585c78f76a5e07df"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-02-17 22:48:54.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-02-18 00:07:14.000000000","tz":0},"subject":"fix(nix/readTree): make nixFileName only match .nix extensions","message":"fix(nix/readTree): make nixFileName only match .nix extensions\n\nNix unfortunately has terrible escaping syntax: If something is an\nescape sequence it does not know, like \\0, it just swallows the\nbackslash and returns the second character (byte) as is (yes,\n\"\\0\" \u003d\u003d \"0\" is true). This created the following bug in nixFileName\nwhich should have resulted in at least a parse error: \"(.*)\\.nix\" is\nthe same as \"(.*).nix\" which meant that nixFileName matched anything\nthat is at least 4 characters long and ends in \"nix\". This lead to\nreadTree creating double attributes when directories are involved or\nattributes for non-nix files.\n\nChange-Id: Ibf3be2bd189d48881c82ee795c50151bfb365627\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2535\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2469f0b423518ef4bee1641f04c3283bed374567"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2469f0b423518ef4bee1641f04c3283bed374567"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fa99c128f806d5015b6f4c31585c78f76a5e07df","is_merged_in_target_branch":true,"change_id":"Ia4ea7425432b8b0da09f63054f51f0c480300aa4","change_number":2531,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}