)]}'
{"id":"depot~2556","triplet_id":"depot~canon~Icfa0bd4729d9df786e08f7e49a25cba1b9989a91","project":"depot","branch":"canon","hashtags":[],"change_id":"Icfa0bd4729d9df786e08f7e49a25cba1b9989a91","subject":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler","status":"MERGED","created":"2021-02-27 12:19:18.000000000","updated":"2021-02-27 13:08:03.000000000","submitted":"2021-02-27 13:05:18.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2556","meta_rev_id":"5fd8b8016e351842ee1ab9cc8d5ce98fc8c8be30","_number":2556,"virtual_id_number":2556,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-27 13:05:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-27 13:05:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-27 12:22:04.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7c7dc6c15bda16306b95e8659c1a5111aed2f827","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-27 12:19:18.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"8518458bab32c567624011f22280ca49634e5540","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-27 12:22:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5199","accounts_in_message":[],"_revision_number":1},{"id":"4fa20acd10d353d74e7e52bc597cb50470216391","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-27 13:02:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fb8600a7295599f51b25379e9c35c81a46ab2d68","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-27 13:04:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5203","accounts_in_message":[],"_revision_number":2},{"id":"e076589e5d0769fcbadd49866f9377de0c58b465","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-27 13:05:18.000000000","message":"Change has been successfully rebased and submitted as ee974b3eddffa47d0d16beeada6658f37a21a8d4","accounts_in_message":[],"_revision_number":3},{"id":"5fd8b8016e351842ee1ab9cc8d5ce98fc8c8be30","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-27 13:08:03.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/5208","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ee974b3eddffa47d0d16beeada6658f37a21a8d4","revisions":{"b16eea6dc694539eab062c4e68265677a44825d1":{"kind":"REWORK","_number":1,"created":"2021-02-27 12:19:18.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/56/2556/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/56/2556/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/56/2556/1"}}},"commit":{"parents":[{"commit":"ef93ca96ce1f3e58210cf4d88c83691c8a2d3310","subject":"chore(tazjin/rlox): Add From\u003cError\u003e for Vec\u003cError\u003e","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003def93ca96ce1f3e58210cf4d88c83691c8a2d3310"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-27 12:18:05.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-27 12:18:05.000000000","tz":120},"subject":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler","message":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler\n\nThis one necessarily has to diverge more from the book than the\ntreewalk interpreter did, so some of this is expected to change, but\nI\u0027m happy with the rough shape.\n\nSince we\u0027re reusing the old scanner, the compiler/parser struct owns\nan iterator over all tokens with which the pull-scanner from the\nbytecode chapters is simulated.\n\nChange-Id: Icfa0bd4729d9df786e08f7e49a25cba1b9989a91\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db16eea6dc694539eab062c4e68265677a44825d1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db16eea6dc694539eab062c4e68265677a44825d1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ef93ca96ce1f3e58210cf4d88c83691c8a2d3310","is_merged_in_target_branch":false,"change_id":"Ie027f4700da463a549be6f0d4a0022a9b8dc0d61","change_number":2555,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3ded6d3043d7fffca25fe7d48371acb980eff181":{"kind":"REWORK","_number":2,"created":"2021-02-27 13:02:01.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/56/2556/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/56/2556/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/56/2556/2"}}},"commit":{"parents":[{"commit":"f489ab2798751876cb6cfaa75718e97e12c51a5c","subject":"chore(tazjin/rlox): Add From\u003cError\u003e for Vec\u003cError\u003e","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df489ab2798751876cb6cfaa75718e97e12c51a5c"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-27 12:18:05.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-27 13:01:54.000000000","tz":120},"subject":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler","message":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler\n\nThis one necessarily has to diverge more from the book than the\ntreewalk interpreter did, so some of this is expected to change, but\nI\u0027m happy with the rough shape.\n\nSince we\u0027re reusing the old scanner, the compiler/parser struct owns\nan iterator over all tokens with which the pull-scanner from the\nbytecode chapters is simulated.\n\nChange-Id: Icfa0bd4729d9df786e08f7e49a25cba1b9989a91\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ded6d3043d7fffca25fe7d48371acb980eff181"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ded6d3043d7fffca25fe7d48371acb980eff181"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f489ab2798751876cb6cfaa75718e97e12c51a5c","is_merged_in_target_branch":false,"change_id":"Ie027f4700da463a549be6f0d4a0022a9b8dc0d61","change_number":2555,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ee974b3eddffa47d0d16beeada6658f37a21a8d4":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-02-27 13:05:18.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/56/2556/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/56/2556/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/56/2556/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/56/2556/3"}}},"commit":{"parents":[{"commit":"da2dfb42c6c1cb3a63686be06e9ff04f445506b2","subject":"chore(tazjin/rlox): Add From\u003cError\u003e for Vec\u003cError\u003e","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dda2dfb42c6c1cb3a63686be06e9ff04f445506b2"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-27 12:18:05.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-02-27 13:05:18.000000000","tz":0},"subject":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler","message":"feat(tazjin/rlox): Bootstrap rough shape of bytecode compiler\n\nThis one necessarily has to diverge more from the book than the\ntreewalk interpreter did, so some of this is expected to change, but\nI\u0027m happy with the rough shape.\n\nSince we\u0027re reusing the old scanner, the compiler/parser struct owns\nan iterator over all tokens with which the pull-scanner from the\nbytecode chapters is simulated.\n\nChange-Id: Icfa0bd4729d9df786e08f7e49a25cba1b9989a91\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2556\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee974b3eddffa47d0d16beeada6658f37a21a8d4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee974b3eddffa47d0d16beeada6658f37a21a8d4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"da2dfb42c6c1cb3a63686be06e9ff04f445506b2","is_merged_in_target_branch":true,"change_id":"Ie027f4700da463a549be6f0d4a0022a9b8dc0d61","change_number":2555,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}