)]}'
{"id":"depot~2567","triplet_id":"depot~canon~If2bed4569fbf566027011037165a9b3c09b7427c","project":"depot","branch":"canon","hashtags":[],"change_id":"If2bed4569fbf566027011037165a9b3c09b7427c","subject":"fix(tazjin/rlox): Fix selection of next parser precedence rule","status":"MERGED","created":"2021-02-28 11:09:29.000000000","updated":"2021-02-28 11:15:50.000000000","submitted":"2021-02-28 11:14:03.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2569","meta_rev_id":"59cb2eb365058267e442717eaaae3a1f97560f5c","_number":2567,"virtual_id_number":2567,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-28 11:14:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-28 11:14:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-28 11:10:58.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7bc7374ba19e86234cf9c83c4743b4933efebb30","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 11:09:29.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"60e75b80576ba4dc4babfa27ca55aa75c9598e23","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 11:10:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5231","accounts_in_message":[],"_revision_number":1},{"id":"1f3d203b416fd909d8b0a28a86c6b3d6525d0125","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 11:14:03.000000000","message":"Change has been successfully rebased and submitted as 47c1a9a2804ebbc5acb83ab40ef75beb319f28e3","accounts_in_message":[],"_revision_number":2},{"id":"59cb2eb365058267e442717eaaae3a1f97560f5c","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 11:15:50.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5237","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"47c1a9a2804ebbc5acb83ab40ef75beb319f28e3","revisions":{"d9b214e663607d7ed4ea3f38086a6ba4921ca51d":{"kind":"REWORK","_number":1,"created":"2021-02-28 11:09:29.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/67/2567/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/67/2567/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/67/2567/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/67/2567/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/67/2567/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/67/2567/1"}}},"commit":{"parents":[{"commit":"815acc8389527aed1fc4db23490f35c8ae2cc651","subject":"feat(tazjin/rlox): Wire up bytecode interpreter \u0026 print results","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d815acc8389527aed1fc4db23490f35c8ae2cc651"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 11:01:02.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 11:01:02.000000000","tz":120},"subject":"fix(tazjin/rlox): Fix selection of next parser precedence rule","message":"fix(tazjin/rlox): Fix selection of next parser precedence rule\n\nWithout this fix we would keep parsing in the same precedence level\nand get weird things like:\n\n    10 - -10 + 10\n    \u003d\u003e 10\n\nChange-Id: If2bed4569fbf566027011037165a9b3c09b7427c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd9b214e663607d7ed4ea3f38086a6ba4921ca51d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd9b214e663607d7ed4ea3f38086a6ba4921ca51d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"815acc8389527aed1fc4db23490f35c8ae2cc651","is_merged_in_target_branch":false,"change_id":"I24afc7ce461c6673dc42581378f6e14da7aece5c","change_number":2566,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"47c1a9a2804ebbc5acb83ab40ef75beb319f28e3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-28 11:14:03.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/67/2567/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/67/2567/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/67/2567/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/67/2567/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/67/2567/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/67/2567/2"}}},"commit":{"parents":[{"commit":"995d024f03d99726de5b22bdf5aaa04a88e00b4a","subject":"feat(tazjin/rlox): Wire up bytecode interpreter \u0026 print results","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d995d024f03d99726de5b22bdf5aaa04a88e00b4a"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 11:01:02.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-02-28 11:14:03.000000000","tz":0},"subject":"fix(tazjin/rlox): Fix selection of next parser precedence rule","message":"fix(tazjin/rlox): Fix selection of next parser precedence rule\n\nWithout this fix we would keep parsing in the same precedence level\nand get weird things like:\n\n    10 - -10 + 10\n    \u003d\u003e 10\n\nChange-Id: If2bed4569fbf566027011037165a9b3c09b7427c\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2567\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47c1a9a2804ebbc5acb83ab40ef75beb319f28e3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47c1a9a2804ebbc5acb83ab40ef75beb319f28e3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"995d024f03d99726de5b22bdf5aaa04a88e00b4a","is_merged_in_target_branch":true,"change_id":"I24afc7ce461c6673dc42581378f6e14da7aece5c","change_number":2566,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}