)]}'
{"id":"depot~2570","triplet_id":"depot~canon~I325b5e31e395c62d8819ab2af6d398e1277333c0","project":"depot","branch":"canon","hashtags":[],"change_id":"I325b5e31e395c62d8819ab2af6d398e1277333c0","subject":"refactor(tazjin/rlox): Represent VM values as enums","status":"MERGED","created":"2021-02-28 12:38:50.000000000","updated":"2021-02-28 12:55:25.000000000","submitted":"2021-02-28 12:54:29.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2570","meta_rev_id":"17214de7150c499c36f25d662fe4a5d077630615","_number":2570,"virtual_id_number":2570,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-28 12:54:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-28 12:54:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-28 12:39:50.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"af3c84705e8d18ae3deedc2ec94e996645bef52f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 12:38:50.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"c3be65cb7ccd9359aa78fcd1b49ea97e29e501a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 12:39:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c5b49ef4719a3c2f3a381439d1b7ad76aed674d2","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 12:39:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5240","accounts_in_message":[],"_revision_number":1},{"id":"55519467cc111a6b5a406359e55bc528e6bfe91b","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 12:40:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5241","accounts_in_message":[],"_revision_number":2},{"id":"6f87af9ed9526333053b93d2442510c5364323c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 12:54:29.000000000","message":"Change has been successfully rebased and submitted as 127ef984865500d70176347861b2e8bad29a39be","accounts_in_message":[],"_revision_number":3},{"id":"17214de7150c499c36f25d662fe4a5d077630615","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 12:55:25.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/5242","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"127ef984865500d70176347861b2e8bad29a39be","revisions":{"20589a86589f9052631b47f9537626bb2c78c4cb":{"kind":"REWORK","_number":1,"created":"2021-02-28 12:38:50.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/70/2570/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/70/2570/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/70/2570/1"}}},"commit":{"parents":[{"commit":"6b990a757186da0f2766fefac53ce5de140d9174","subject":"test(tazjin/rlox): Add some tests for numerical operations","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6b990a757186da0f2766fefac53ce5de140d9174"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 12:37:35.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 12:38:46.000000000","tz":120},"subject":"refactor(tazjin/rlox): Represent VM values as enums","message":"refactor(tazjin/rlox): Represent VM values as enums\n\nIntroduces a new enum which represents the different types of possible\nvalues, and modifies the rest of the existing code to wrap/unwrap\nthese enum variants correctly.\n\nNotably in the vm module, a new macro has been introduced that makes\nit possible to encode a type expectation and return a runtime error in\ncase of a type mismatch.\n\nChange-Id: I325b5e31e395c62d8819ab2af6d398e1277333c0\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d20589a86589f9052631b47f9537626bb2c78c4cb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d20589a86589f9052631b47f9537626bb2c78c4cb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6b990a757186da0f2766fefac53ce5de140d9174","is_merged_in_target_branch":true,"change_id":"Ia801d041479d1a88c59ef9e0fe1460b3640382e3","change_number":2569,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6972568981fcc2ef0f1271055f332bab41d150f6":{"kind":"REWORK","_number":2,"created":"2021-02-28 12:39:35.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/70/2570/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/70/2570/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/70/2570/2"}}},"commit":{"parents":[{"commit":"6b990a757186da0f2766fefac53ce5de140d9174","subject":"test(tazjin/rlox): Add some tests for numerical operations","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6b990a757186da0f2766fefac53ce5de140d9174"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 12:37:35.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 12:39:31.000000000","tz":120},"subject":"refactor(tazjin/rlox): Represent VM values as enums","message":"refactor(tazjin/rlox): Represent VM values as enums\n\nIntroduces a new enum which represents the different types of possible\nvalues, and modifies the rest of the existing code to wrap/unwrap\nthese enum variants correctly.\n\nNotably in the vm module, a new macro has been introduced that makes\nit possible to encode a type expectation and return a runtime error in\ncase of a type mismatch.\n\nChange-Id: I325b5e31e395c62d8819ab2af6d398e1277333c0\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6972568981fcc2ef0f1271055f332bab41d150f6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6972568981fcc2ef0f1271055f332bab41d150f6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6b990a757186da0f2766fefac53ce5de140d9174","is_merged_in_target_branch":true,"change_id":"Ia801d041479d1a88c59ef9e0fe1460b3640382e3","change_number":2569,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"127ef984865500d70176347861b2e8bad29a39be":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-02-28 12:54:29.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/70/2570/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/70/2570/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/70/2570/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/70/2570/3"}}},"commit":{"parents":[{"commit":"6b990a757186da0f2766fefac53ce5de140d9174","subject":"test(tazjin/rlox): Add some tests for numerical operations","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6b990a757186da0f2766fefac53ce5de140d9174"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 12:37:35.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-02-28 12:54:29.000000000","tz":0},"subject":"refactor(tazjin/rlox): Represent VM values as enums","message":"refactor(tazjin/rlox): Represent VM values as enums\n\nIntroduces a new enum which represents the different types of possible\nvalues, and modifies the rest of the existing code to wrap/unwrap\nthese enum variants correctly.\n\nNotably in the vm module, a new macro has been introduced that makes\nit possible to encode a type expectation and return a runtime error in\ncase of a type mismatch.\n\nChange-Id: I325b5e31e395c62d8819ab2af6d398e1277333c0\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2570\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d127ef984865500d70176347861b2e8bad29a39be"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d127ef984865500d70176347861b2e8bad29a39be"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6b990a757186da0f2766fefac53ce5de140d9174","is_merged_in_target_branch":true,"change_id":"Ia801d041479d1a88c59ef9e0fe1460b3640382e3","change_number":2569,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}