)]}'
{"id":"depot~2571","triplet_id":"depot~canon~I405b5b09496dcf99d514d3411c083e0834377167","project":"depot","branch":"canon","hashtags":[],"change_id":"I405b5b09496dcf99d514d3411c083e0834377167","subject":"feat(tazjin/rlox): Support trivial literals in bytecode compiler","status":"MERGED","created":"2021-02-28 13:16:27.000000000","updated":"2021-02-28 14:37:38.000000000","submitted":"2021-02-28 14:36:40.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2575","meta_rev_id":"770cbd4cfa0ed051f797d0f1419b64fe90c44602","_number":2571,"virtual_id_number":2571,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-02-28 14:36:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-02-28 14:36:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-28 13:17:24.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7a854a54c551802aec58852211a1b8b5c6cc8dc3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 13:16:27.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"4e9cacdf7160f062234283474913acca2028b4e6","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 13:17:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5244","accounts_in_message":[],"_revision_number":1},{"id":"ad906b161838788770a6168a2dccd43cc6d8d665","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-02-28 14:36:40.000000000","message":"Change has been successfully rebased and submitted as 47ffa8071152bcafb4b6ff87a3142bf12dbce12b","accounts_in_message":[],"_revision_number":2},{"id":"770cbd4cfa0ed051f797d0f1419b64fe90c44602","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-02-28 14:37:38.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5249","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"47ffa8071152bcafb4b6ff87a3142bf12dbce12b","revisions":{"988b68f6366926cf44ddc4ebee92dee8c7ca12d4":{"kind":"REWORK","_number":1,"created":"2021-02-28 13:16:27.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/71/2571/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/71/2571/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/71/2571/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/71/2571/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/71/2571/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/71/2571/1"}}},"commit":{"parents":[{"commit":"127ef984865500d70176347861b2e8bad29a39be","subject":"refactor(tazjin/rlox): Represent VM values as enums","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d127ef984865500d70176347861b2e8bad29a39be"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 13:15:46.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 13:16:22.000000000","tz":120},"subject":"feat(tazjin/rlox): Support trivial literals in bytecode compiler","message":"feat(tazjin/rlox): Support trivial literals in bytecode compiler\n\nAdds support for true, false \u0026 nil. These each come with a new\nseparate opcode and are pushed directly on the stack.\n\nChange-Id: I405b5b09496dcf99d514d3411c083e0834377167\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d988b68f6366926cf44ddc4ebee92dee8c7ca12d4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d988b68f6366926cf44ddc4ebee92dee8c7ca12d4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"127ef984865500d70176347861b2e8bad29a39be","is_merged_in_target_branch":true,"change_id":"I325b5e31e395c62d8819ab2af6d398e1277333c0","change_number":2570,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"47ffa8071152bcafb4b6ff87a3142bf12dbce12b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-28 14:36:40.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/71/2571/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/71/2571/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/71/2571/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/71/2571/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/71/2571/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/71/2571/2"}}},"commit":{"parents":[{"commit":"127ef984865500d70176347861b2e8bad29a39be","subject":"refactor(tazjin/rlox): Represent VM values as enums","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d127ef984865500d70176347861b2e8bad29a39be"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 13:15:46.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-02-28 14:36:40.000000000","tz":0},"subject":"feat(tazjin/rlox): Support trivial literals in bytecode compiler","message":"feat(tazjin/rlox): Support trivial literals in bytecode compiler\n\nAdds support for true, false \u0026 nil. These each come with a new\nseparate opcode and are pushed directly on the stack.\n\nChange-Id: I405b5b09496dcf99d514d3411c083e0834377167\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2571\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47ffa8071152bcafb4b6ff87a3142bf12dbce12b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47ffa8071152bcafb4b6ff87a3142bf12dbce12b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"127ef984865500d70176347861b2e8bad29a39be","is_merged_in_target_branch":true,"change_id":"I325b5e31e395c62d8819ab2af6d398e1277333c0","change_number":2570,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}