)]}'
{"id":"depot~2577","triplet_id":"depot~canon~I374a0461d627cfafc26b2b54bfefac8b7c574d00","project":"depot","branch":"canon","hashtags":[],"change_id":"I374a0461d627cfafc26b2b54bfefac8b7c574d00","subject":"feat(tazjin/rlox): Add initial support for strings","status":"MERGED","created":"2021-03-01 12:37:16.000000000","updated":"2021-03-01 21:10:45.000000000","submitted":"2021-03-01 21:09:37.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2578","meta_rev_id":"aab4048d2e7cca099f2ea7855c7151ceed91006d","_number":2577,"virtual_id_number":2577,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-01 21:09:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-01 21:09:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-01 12:38:14.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed2189cb8ab01f7f29040a6f075e8ce8db5cdea0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-01 12:37:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01811197a1b7df7b3768b1fd1910436e658c44b8","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-01 12:38:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5260","accounts_in_message":[],"_revision_number":1},{"id":"b38efe6b10e60c524ab1e10b542fc7e01c5962a2","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-01 17:40:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"849ceb46dd1afba7facb2ae7655027430961660d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-01 21:09:37.000000000","message":"Change has been successfully rebased and submitted as 6f600c8300c028beb07bf224baf7dfdaa6490fd3","accounts_in_message":[],"_revision_number":2},{"id":"aab4048d2e7cca099f2ea7855c7151ceed91006d","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-01 21:10:45.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5272","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6f600c8300c028beb07bf224baf7dfdaa6490fd3","revisions":{"394ea5867c02291b0d4b9953caa52f8d4baed2a1":{"kind":"REWORK","_number":1,"created":"2021-03-01 12:37:16.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/77/2577/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/77/2577/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/77/2577/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/77/2577/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/77/2577/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/77/2577/1"}}},"commit":{"parents":[{"commit":"369f504250fe6508d3b927c6c8320a2525edfad1","subject":"feat(tazjin/rlox): Implement comparison operators","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d369f504250fe6508d3b927c6c8320a2525edfad1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 20:35:26.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-01 12:35:43.000000000","tz":120},"subject":"feat(tazjin/rlox): Add initial support for strings","message":"feat(tazjin/rlox): Add initial support for strings\n\n... including concatenation.\n\nThis diverges significantly from the book, as I\u0027m using std::String\ninstead of implementing the book\u0027s whole heap object management\nsystem.\n\nIt\u0027s possible that Lox in Rust actually doesn\u0027t need a GC and the\nownership model works just fine.\n\nChange-Id: I374a0461d627cfafc26b2b54bfefac8b7c574d00\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d394ea5867c02291b0d4b9953caa52f8d4baed2a1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d394ea5867c02291b0d4b9953caa52f8d4baed2a1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"369f504250fe6508d3b927c6c8320a2525edfad1","is_merged_in_target_branch":true,"change_id":"I03b751db52a3bd502fb4fbda6e89cad087ccad74","change_number":2575,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6f600c8300c028beb07bf224baf7dfdaa6490fd3":{"kind":"REWORK","_number":2,"created":"2021-03-01 21:09:37.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/77/2577/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/77/2577/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/77/2577/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/77/2577/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/77/2577/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/77/2577/2"}}},"commit":{"parents":[{"commit":"3b33c1bd7627c9427a410276c2a49c2b04f70edc","subject":"feat(users/sterni/nix): add sternis nix lib","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c1bd7627c9427a410276c2a49c2b04f70edc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-02-28 20:35:26.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-01 21:09:37.000000000","tz":0},"subject":"feat(tazjin/rlox): Add initial support for strings","message":"feat(tazjin/rlox): Add initial support for strings\n\n... including concatenation.\n\nThis diverges significantly from the book, as I\u0027m using std::String\ninstead of implementing the book\u0027s whole heap object management\nsystem.\n\nIt\u0027s possible that Lox in Rust actually doesn\u0027t need a GC and the\nownership model works just fine.\n\nChange-Id: I374a0461d627cfafc26b2b54bfefac8b7c574d00\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2577\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f600c8300c028beb07bf224baf7dfdaa6490fd3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f600c8300c028beb07bf224baf7dfdaa6490fd3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c1bd7627c9427a410276c2a49c2b04f70edc","is_merged_in_target_branch":true,"change_id":"I33ab08ca4e62dbc16b86c66c653935686e6b0e79","change_number":2541,"patch_set_number":18,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}