)]}'
{"id":"depot~2578","triplet_id":"depot~canon~Ia3dae988f33f8e5e7d8dc0c1a9216914a945b036","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-03-01 21:09:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia3dae988f33f8e5e7d8dc0c1a9216914a945b036","subject":"feat(tazjin/rlox): Add a simple string interner","status":"MERGED","created":"2021-03-01 16:35:01.000000000","updated":"2021-03-01 21:11:21.000000000","submitted":"2021-03-01 21:09:37.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2578","meta_rev_id":"5ab8b8b11d73e5f58e80df359d4d9b544d6784d5","_number":2578,"virtual_id_number":2578,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-01 21:09:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-01 21:09:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-01 16:36:04.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"624c5b9418414227e3caef78fd31957214253bfd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-01 16:35:01.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"c86b28d2fa8afb246778a29d4c40903dbef9e7c6","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-01 16:36:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/5266","accounts_in_message":[],"_revision_number":1},{"id":"86ec11d883fb77127726bd54b5cbff20a3ec6a5c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-01 16:54:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"803121bb56e8fd8167eb70ea948bbad32f717efa","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-01 16:55:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5267","accounts_in_message":[],"_revision_number":2},{"id":"4dbbd30a2097fe75110ebee49a961444009a07c9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-01 21:09:37.000000000","message":"Change has been successfully rebased and submitted as ef7a0da8cb22601d8cdd466644413877126c70df","accounts_in_message":[],"_revision_number":3},{"id":"5ab8b8b11d73e5f58e80df359d4d9b544d6784d5","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-01 21:11:21.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/5274","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ef7a0da8cb22601d8cdd466644413877126c70df","revisions":{"fe59c50957ab6ba96b4ee4ba472c98c38c0f7c69":{"kind":"REWORK","_number":1,"created":"2021-03-01 16:35:01.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/78/2578/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/78/2578/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/78/2578/1"}}},"commit":{"parents":[{"commit":"394ea5867c02291b0d4b9953caa52f8d4baed2a1","subject":"feat(tazjin/rlox): Add initial support for strings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d394ea5867c02291b0d4b9953caa52f8d4baed2a1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-01 16:31:17.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-01 16:31:17.000000000","tz":120},"subject":"feat(tazjin/rlox): Add a simple string interner","message":"feat(tazjin/rlox): Add a simple string interner\n\nThis is based on this matklad post:\n\nhttps://matklad.github.io/2020/03/22/fast-simple-rust-interner.html\n\nIt\u0027s modified slightly to provide a safer interface and slightly more\nreadable implementation:\n\n* interned string IDs are wrapped in a newtype that is not publicly\n  constructible\n\n* unsafe block is reduced to only the small scope in which it is\n  needed\n\n* lookup lifetime is pinned explicitly to make the intent clearer when\n  reading this code\n\nChange-Id: Ia3dae988f33f8e5e7d8dc0c1a9216914a945b036\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfe59c50957ab6ba96b4ee4ba472c98c38c0f7c69"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfe59c50957ab6ba96b4ee4ba472c98c38c0f7c69"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"394ea5867c02291b0d4b9953caa52f8d4baed2a1","is_merged_in_target_branch":false,"change_id":"I374a0461d627cfafc26b2b54bfefac8b7c574d00","change_number":2577,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ede1f9ca8fefe3d967c1a7e848dc8d763d42454a":{"kind":"REWORK","_number":2,"created":"2021-03-01 16:54:49.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/78/2578/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/78/2578/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/78/2578/2"}}},"commit":{"parents":[{"commit":"394ea5867c02291b0d4b9953caa52f8d4baed2a1","subject":"feat(tazjin/rlox): Add initial support for strings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d394ea5867c02291b0d4b9953caa52f8d4baed2a1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-01 16:31:17.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-01 16:54:42.000000000","tz":120},"subject":"feat(tazjin/rlox): Add a simple string interner","message":"feat(tazjin/rlox): Add a simple string interner\n\nThis is based on this matklad post:\n\nhttps://matklad.github.io/2020/03/22/fast-simple-rust-interner.html\n\nIt\u0027s modified slightly to provide a safer interface and slightly more\nreadable implementation:\n\n* interned string IDs are wrapped in a newtype that is not publicly\n  constructible\n\n* unsafe block is reduced to only the small scope in which it is\n  needed\n\n* lookup lifetime is pinned explicitly to make the intent clearer when\n  reading this code\n\nChange-Id: Ia3dae988f33f8e5e7d8dc0c1a9216914a945b036\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dede1f9ca8fefe3d967c1a7e848dc8d763d42454a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dede1f9ca8fefe3d967c1a7e848dc8d763d42454a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"394ea5867c02291b0d4b9953caa52f8d4baed2a1","is_merged_in_target_branch":false,"change_id":"I374a0461d627cfafc26b2b54bfefac8b7c574d00","change_number":2577,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ef7a0da8cb22601d8cdd466644413877126c70df":{"kind":"REWORK","_number":3,"created":"2021-03-01 21:09:37.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/78/2578/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/78/2578/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/78/2578/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/78/2578/3"}}},"commit":{"parents":[{"commit":"6f600c8300c028beb07bf224baf7dfdaa6490fd3","subject":"feat(tazjin/rlox): Add initial support for strings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6f600c8300c028beb07bf224baf7dfdaa6490fd3"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-01 16:31:17.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-01 21:09:37.000000000","tz":0},"subject":"feat(tazjin/rlox): Add a simple string interner","message":"feat(tazjin/rlox): Add a simple string interner\n\nThis is based on this matklad post:\n\nhttps://matklad.github.io/2020/03/22/fast-simple-rust-interner.html\n\nIt\u0027s modified slightly to provide a safer interface and slightly more\nreadable implementation:\n\n* interned string IDs are wrapped in a newtype that is not publicly\n  constructible\n\n* unsafe block is reduced to only the small scope in which it is\n  needed\n\n* lookup lifetime is pinned explicitly to make the intent clearer when\n  reading this code\n\nChange-Id: Ia3dae988f33f8e5e7d8dc0c1a9216914a945b036\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2578\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003def7a0da8cb22601d8cdd466644413877126c70df"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003def7a0da8cb22601d8cdd466644413877126c70df"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6f600c8300c028beb07bf224baf7dfdaa6490fd3","is_merged_in_target_branch":true,"change_id":"I374a0461d627cfafc26b2b54bfefac8b7c574d00","change_number":2577,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}