)]}'
{"id":"depot~2582","triplet_id":"depot~canon~If4f04309446e01b8ff2db51094e9710d465dbc50","project":"depot","branch":"canon","hashtags":[],"change_id":"If4f04309446e01b8ff2db51094e9710d465dbc50","subject":"feat(tazjin/rlox): Intern all string constants","status":"MERGED","created":"2021-03-02 11:12:57.000000000","updated":"2021-03-02 19:50:11.000000000","submitted":"2021-03-02 19:48:46.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2582","meta_rev_id":"67ed9e07d20cc753ec9ce409fd12151d0913691c","_number":2582,"virtual_id_number":2582,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-02 19:48:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-02 19:48:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-02 11:14:13.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8eec06c38a35bd3eac607f5397984332f1322755","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-02 11:12:57.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"a5d8e9a07f28ca5bdb86876eec1958c68a2e8cd9","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-02 11:14:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5284","accounts_in_message":[],"_revision_number":1},{"id":"f0f584f559b1b895dfc3785a7a6c8d630118f2b0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-02 19:48:46.000000000","message":"Change has been successfully rebased and submitted as 432e7a7dddf56224297285c9f47f0aa3963eb5b5","accounts_in_message":[],"_revision_number":2},{"id":"67ed9e07d20cc753ec9ce409fd12151d0913691c","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-02 19:50:11.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5287","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"432e7a7dddf56224297285c9f47f0aa3963eb5b5","revisions":{"72c8c2843a801d566de3109df9c42aea45d8247d":{"kind":"REWORK","_number":1,"created":"2021-03-02 11:12:57.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/82/2582/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/2582/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/2582/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/2582/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/2582/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/2582/1"}}},"commit":{"parents":[{"commit":"407639fe6e287dffbd6bca433ce50b7a7b4cfac4","subject":"test(tazjin/rlox): Add simple string assertions","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d407639fe6e287dffbd6bca433ce50b7a7b4cfac4"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 11:11:21.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 11:12:53.000000000","tz":120},"subject":"feat(tazjin/rlox): Intern all string constants","message":"feat(tazjin/rlox): Intern all string constants\n\nThis is again a step closer to the book, but there are some notable\ndifferences:\n\n* Only constants encountered by the compiler are interned, all other\n  string operations (well, concatenation) happen with heap objects.\n\n* OpReturn will always ensure that a returned string value is newly\n  heap allocated and does not reference the interner.\n\nChange-Id: If4f04309446e01b8ff2db51094e9710d465dbc50\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72c8c2843a801d566de3109df9c42aea45d8247d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72c8c2843a801d566de3109df9c42aea45d8247d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"407639fe6e287dffbd6bca433ce50b7a7b4cfac4","is_merged_in_target_branch":false,"change_id":"I6c60934d57170157d877e71cc87a97ab773342b5","change_number":2581,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"432e7a7dddf56224297285c9f47f0aa3963eb5b5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-03-02 19:48:46.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/82/2582/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/82/2582/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/82/2582/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/82/2582/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/82/2582/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/82/2582/2"}}},"commit":{"parents":[{"commit":"bcea8e0d169974ba57a54ca098f480d6294a7fb1","subject":"test(tazjin/rlox): Add simple string assertions","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbcea8e0d169974ba57a54ca098f480d6294a7fb1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 11:11:21.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-02 19:48:46.000000000","tz":0},"subject":"feat(tazjin/rlox): Intern all string constants","message":"feat(tazjin/rlox): Intern all string constants\n\nThis is again a step closer to the book, but there are some notable\ndifferences:\n\n* Only constants encountered by the compiler are interned, all other\n  string operations (well, concatenation) happen with heap objects.\n\n* OpReturn will always ensure that a returned string value is newly\n  heap allocated and does not reference the interner.\n\nChange-Id: If4f04309446e01b8ff2db51094e9710d465dbc50\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2582\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d432e7a7dddf56224297285c9f47f0aa3963eb5b5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d432e7a7dddf56224297285c9f47f0aa3963eb5b5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"bcea8e0d169974ba57a54ca098f480d6294a7fb1","is_merged_in_target_branch":true,"change_id":"I6c60934d57170157d877e71cc87a97ab773342b5","change_number":2581,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}